Skip to content

Commit cb6291f

Browse files
Apply review comments
Co-Authored-By: Abel Braaksma <abel.online@xs4all.nl>
1 parent 452c282 commit cb6291f

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

src/FSharp.Control.TaskSeq.Test/TaskSeq.Do.Tests.fs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ let ``CE taskSeq: use 'do!' with a task<unit>`` () =
2222
|> Task.map (fun _ -> value |> should equal 1)
2323

2424
[<Fact>]
25-
let ``CE taskSeq: use 'do!' with a valueTask<unit>`` () =
25+
let ``CE taskSeq: use 'do!' with a ValueTask<unit>`` () =
2626
let mutable value = 0
2727

2828
taskSeq { do! ValueTask.ofTask (task { do value <- value + 1 }) }
2929
|> verifyEmpty
3030
|> Task.map (fun _ -> value |> should equal 1)
3131

3232
[<Fact>]
33-
let ``CE taskSeq: use 'do!' with a non-generic valueTask`` () =
33+
let ``CE taskSeq: use 'do!' with a non-generic ValueTask`` () =
3434
let mutable value = 0
3535

3636
taskSeq { do! ValueTask(task { do value <- value + 1 }) }
@@ -92,8 +92,8 @@ let ``CE taskSeq: use 'do!' with all kinds of overloads at once`` () =
9292
do! task { do value <- value + 1 } |> Task.ignore
9393
do! ValueTask <| task { do value <- value + 1 }
9494
do! ValueTask.ofTask (task { do value <- value + 1 })
95-
do! ValueTask<_>(()) // unit valueTask that completes immediately
96-
do! Task.fromResult () // unit Task that completes immediately
95+
do! ValueTask<_>(()) // unit ValueTask that completes immediately
96+
do! Task.fromResult (()) // unit Task that completes immediately
9797
do! Task.Delay 0
9898
do! Async.Sleep 0
9999
do! async { value <- value + 1 } // eq 4

src/FSharp.Control.TaskSeq.Test/TaskSeq.Let.Tests.fs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ let ``CE taskSeq: use 'let!' with a task<string>`` () =
4040
|> Task.map (should equal "test")
4141

4242
[<Fact>]
43-
let ``CE taskSeq: use 'let!' with a valueTask<unit>`` () =
43+
let ``CE taskSeq: use 'let!' with a ValueTask<unit>`` () =
4444
let mutable value = 0
4545

4646
taskSeq {
@@ -51,7 +51,7 @@ let ``CE taskSeq: use 'let!' with a valueTask<unit>`` () =
5151
|> Task.map (fun _ -> value |> should equal 1)
5252

5353
[<Fact>]
54-
let ``CE taskSeq: use 'let!' with a valueTask<string>`` () =
54+
let ``CE taskSeq: use 'let!' with a ValueTask<string>`` () =
5555
taskSeq {
5656
let! test = ValueTask.ofTask (task { return "test" })
5757
yield test
@@ -60,7 +60,7 @@ let ``CE taskSeq: use 'let!' with a valueTask<string>`` () =
6060
|> Task.map (should equal "test")
6161

6262
[<Fact>]
63-
let ``CE taskSeq: use 'let!' with a non-generic valueTask`` () =
63+
let ``CE taskSeq: use 'let!' with a non-generic ValueTask`` () =
6464
let mutable value = 0
6565

6666
taskSeq {
@@ -135,7 +135,7 @@ let ``CE taskSeq: use 'let!' with all kinds of overloads at once`` () =
135135
}
136136
|> ValueTask<int>
137137

138-
let! c = ValueTask<_>(4) // valueTask that completes immediately
138+
let! c = ValueTask<_>(4) // ValueTask that completes immediately
139139
let! _ = Task.Factory.StartNew(fun () -> value <- value + 1) // non-generic Task with side effect
140140
let! d = Task.fromResult 99 // normal Task that completes immediately
141141
let! _ = Async.Sleep 0 // unit Async

src/FSharp.Control.TaskSeq.Test/TaskSeq.StateTransitionBug.Tests.CE.fs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,16 @@ let ``CE empty taskSeq with MoveNextAsync -- typed`` variant = task {
3232
[<Theory; ClassData(typeof<TestEmptyVariants>)>]
3333
let ``CE empty taskSeq, GetAsyncEnumerator multiple times`` variant = task {
3434
let tskSeq = Gen.getEmptyVariant variant
35-
use _e = tskSeq.GetAsyncEnumerator()
36-
use _e = tskSeq.GetAsyncEnumerator()
37-
use _e = tskSeq.GetAsyncEnumerator()
35+
use _ = tskSeq.GetAsyncEnumerator()
36+
use _ = tskSeq.GetAsyncEnumerator()
37+
use _ = tskSeq.GetAsyncEnumerator()
3838
()
3939
}
4040

4141
[<Theory; ClassData(typeof<TestEmptyVariants>)>]
4242
let ``CE empty taskSeq, GetAsyncEnumerator multiple times and then MoveNextAsync`` variant = task {
4343
let tskSeq = Gen.getEmptyVariant variant
44-
use _enumerator = tskSeq.GetAsyncEnumerator()
44+
use _ = tskSeq.GetAsyncEnumerator()
4545
use enumerator = tskSeq.GetAsyncEnumerator()
4646
do! Assert.moveNextAndCheck false enumerator
4747
}

0 commit comments

Comments
 (0)