Skip to content

Commit 2692bb1

Browse files
authored
Merge pull request #224 from bartelink/static-state-machine-wae
Enable `TreatWarningsAsErrors` across the board
2 parents 9186f71 + 6a743a7 commit 2692bb1

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

src/FSharp.Control.TaskSeq.SmokeTests/FSharp.Control.TaskSeq.SmokeTests.fsproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFramework>net6.0</TargetFramework>
5+
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
56
</PropertyGroup>
67

78
<ItemGroup>

src/FSharp.Control.TaskSeq.Test/FSharp.Control.TaskSeq.Test.fsproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
44
<TargetFramework>net6.0</TargetFramework>
5+
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
56
</PropertyGroup>
67

78
<ItemGroup>

src/FSharp.Control.TaskSeq.Test/TaskSeq.MaxMin.Tests.fs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ module SideSeffects =
296296
}
297297

298298
[<Theory; ClassData(typeof<JustMinMaxBy>)>]
299-
let ``TaskSeq-minBy, maxBy with sequence that changes length`` (minMax: MinMax) = task {
299+
let ``TaskSeq-minBy, maxBy with sequence that changes length`` (minMax: MinMax) =
300300
let mutable i = 0
301301

302302
let ts = taskSeq {
@@ -311,7 +311,8 @@ module SideSeffects =
311311
else
312312
minMaxFn id ts |> Task.map (should equal v)
313313

314-
do! test (MinMax.getByFunction minMax) 10
315-
do! test (MinMax.getByFunction minMax) 20
316-
do! test (MinMax.getByFunction minMax) 30
317-
}
314+
task {
315+
do! test (MinMax.getByFunction minMax) 10
316+
do! test (MinMax.getByFunction minMax) 20
317+
do! test (MinMax.getByFunction minMax) 30
318+
}

src/FSharp.Control.TaskSeq/FSharp.Control.TaskSeq.fsproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFramework>netstandard2.1</TargetFramework>
5+
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
56
<GenerateDocumentationFile>true</GenerateDocumentationFile>
67
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
78
<Title>Computation expression 'taskSeq' for processing IAsyncEnumerable sequences and module functions</Title>
@@ -27,11 +28,9 @@ Generates optimized IL code through resumable state machines, and comes with a c
2728
</PropertyGroup>
2829

2930
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
30-
<OtherFlags></OtherFlags>
3131
</PropertyGroup>
3232

3333
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
34-
<OtherFlags></OtherFlags>
3534
<Tailcalls>True</Tailcalls>
3635
</PropertyGroup>
3736

0 commit comments

Comments
 (0)