Skip to content

Commit f3cb5b0

Browse files
authored
Merge pull request #146 from rneatherway/fix-error-msg-parsing
Understand FSAC 0.34 error msgs
2 parents f410ba6 + 39f7423 commit f3cb5b0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

fsharp-mode-completion.el

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -816,7 +816,7 @@ has requested a popup tooltip, display a popup."
816816
(gethash "Logs" data)))))
817817

818818
(defun fsharp-ac-handle-process-error (str)
819-
(fsharp-ac-message-safely str)
819+
(fsharp-ac-message-safely (gethash "Message" str))
820820
(when (not (eq fsharp-ac-status 'idle))
821821
(setq fsharp-ac-status 'idle
822822
fsharp-ac-current-candidate nil)))

test/fsharp-mode-completion-tests.el

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ function bound to VAR in BODY. "
144144

145145
(check-handler "prints message on error"
146146
(stub-fn message err
147-
(fsharp-ac-filter-output nil "{\"Kind\": \"error\", \"Data\": \"foo\"}\n")
147+
(fsharp-ac-filter-output nil "{\"Kind\": \"error\", \"Data\": {\"Code\":1,\"Message\":\"foo\",\"AdditionalData\":{}}}\n")
148148
(should-match "foo" err)))
149149

150150
;;; Tooltips and typesigs

0 commit comments

Comments
 (0)