Use flycheck-fsharp--can-make-request-p instead of lambda expression

This allows flet mocking in tests. Refs #167

Author: juergenhoetzel

flycheck-fsharp.el

@@ -34,6 +34,9 @@
 
 (defvar flycheck-fsharp--lint-callback-info nil)
 
+(defun flycheck-fsharp--can-make-request-p ()
+  (fsharp-ac-can-make-request t))
+
 (defun flycheck-fsharp-fsautocomplete-lint-start (checker callback)
   "Start a F# syntax check with CHECKER.
 CALLBACK is the status callback passed by Flycheck."
@@ -48,7 +51,7 @@ CALLBACK is the status callback passed by Flycheck."
   "A syntax checker for F# using FSharp.AutoComplete.
 See URL `https://github.com/fsharp/FsAutoComplete'."
   :start #'flycheck-fsharp-fsautocomplete-lint-start
-  :predicate (lambda () (fsharp-ac-can-make-request t))
+  :predicate #'flycheck-fsharp--can-make-request-p
   :modes '(fsharp-mode))
 
 (defvar flycheck-fsharp--error-callback-info nil)
@@ -64,7 +67,7 @@ CALLBACK is the status callback passed by Flycheck."
 See URL `https://github.com/fsharp/FsAutoComplete'."
   :start #'flycheck-fsharp-fsautocomplete-start
   :modes '(fsharp-mode)
-  :predicate (lambda () (fsharp-ac-can-make-request t))
+  :predicate #'flycheck-fsharp--can-make-request-p
   :next-checkers '((info . fsharp-fsautocomplete-lint)))
 
 (defun flycheck-fsharp-handle-lint (data)

test/test-common.el

@@ -29,6 +29,7 @@
 (defmacro stubbing-process-functions (&rest body)
   `(noflet ((process-live-p (p) t)
             (fsharp-ac--process-live-p (host) t)
+	    (flycheck-fsharp--can-make-request-p () t)
             (start-process (&rest args))
             (set-process-filter (&rest args))
             (set-process-query-on-exit-flag (&rest args))