Merge pull request #10 from drupol/use-php-conventions

Use drupol/php-conventions for code-style and standards.

Author: shulard

.gitattributes

@@ -4,8 +4,10 @@
 .editorconfig export-ignore
 .gitattributes export-ignore
 .gitignore export-ignore
+.scrutinizer export-ignore
 .travis.yml export-ignore
 CHANGELOG.md export-ignore
+grumphp.yml.dist export-ignore
 LICENSE export-ignore
 phpspec.yml export-ignore
 README.md export-ignore

.travis.yml

@@ -29,8 +29,7 @@ before_script:
 script:
   - composer validate
   - composer update
-  # - bin/phpcs
-  - vendor/bin/phpspec run --no-code-generation
+  - composer grumphp
 
 install:
     - travis_retry composer install

composer.json

@@ -43,7 +43,7 @@
         "phpunit/php-code-coverage": "^5.0 || ^6.0 || ^7.0"
     },
     "require-dev": {
-        "squizlabs/php_codesniffer": "^3.2",
+        "drupol/php-conventions": "^1",
         "scrutinizer/ocular": "^1"
     },
     "suggest": {
@@ -62,6 +62,7 @@
     },
     "minimum-stability": "stable",
     "scripts": {
+        "grumphp": "./vendor/bin/grumphp run",
         "scrutinizer": "./vendor/bin/ocular code-coverage:upload --format=php-clover build/coverage.xml"
     },
     "support": {

grumphp.yml.dist

@@ -0,0 +1,9 @@
+imports:
+  - { resource: vendor/drupol/php-conventions/config/php71/grumphp.yml }
+
+parameters:
+  extra_tasks:
+    phpspec:
+      verbose: true
+      metadata:
+        priority: 3000

spec/CodeCoverageExtensionSpec.php

@@ -1,55 +1,58 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\LeanPHP\PhpSpec\CodeCoverage;
 
+use LeanPHP\PhpSpec\CodeCoverage\CodeCoverageExtension;
 use PhpSpec\ObjectBehavior;
 use PhpSpec\ServiceContainer\IndexedServiceContainer;
-use Prophecy\Argument;
-use LeanPHP\PhpSpec\CodeCoverage\CodeCoverageExtension;
 
 /**
  * @author Henrik Bjornskov
  */
 class CodeCoverageExtensionSpec extends ObjectBehavior
 {
-    function it_is_initializable()
+    public function it_is_initializable(): void
     {
         $this->shouldHaveType(CodeCoverageExtension::class);
     }
 
-    function it_should_use_html_format_by_default()
+    public function it_should_transform_format_into_array(): void
     {
-        $container = new IndexedServiceContainer;
-        $this->load($container, []);
+        $container = new IndexedServiceContainer();
+        $container->setParam('code_coverage', ['format' => 'html']);
+        $this->load($container);
 
         $options = $container->get('code_coverage.options');
+
         if ($options['format'] !== ['html']) {
-            throw new Exception("Default format is not html");
+            throw new Exception('Default format is not transformed to an array');
         }
     }
 
-    function it_should_transform_format_into_array()
+    public function it_should_use_html_format_by_default(): void
     {
-        $container = new IndexedServiceContainer;
-        $container->setParam('code_coverage', array('format' => 'html'));
-        $this->load($container);
+        $container = new IndexedServiceContainer();
+        $this->load($container, []);
 
         $options = $container->get('code_coverage.options');
+
         if ($options['format'] !== ['html']) {
-            throw new Exception("Default format is not transformed to an array");
+            throw new Exception('Default format is not html');
         }
-
     }
 
-    function it_should_use_singular_output()
+    public function it_should_use_singular_output(): void
     {
-        $container = new IndexedServiceContainer;
-        $container->setParam('code_coverage', array('output' => 'test', 'format' => 'foo'));
+        $container = new IndexedServiceContainer();
+        $container->setParam('code_coverage', ['output' => 'test', 'format' => 'foo']);
         $this->load($container);
 
         $options = $container->get('code_coverage.options');
-        if ($options['output'] !== ['foo' => 'test']) {
-            throw new Exception("Default format is not singular output");
+
+        if (['foo' => 'test'] !== $options['output']) {
+            throw new Exception('Default format is not singular output');
         }
     }
 }

spec/Exception/NoCoverageDriverAvailableExceptionSpec.php

@@ -1,16 +1,18 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\LeanPHP\PhpSpec\CodeCoverage\Exception;
 
-use PhpSpec\ObjectBehavior;
 use LeanPHP\PhpSpec\CodeCoverage\Exception\NoCoverageDriverAvailableException;
+use PhpSpec\ObjectBehavior;
 
 /**
  * @author Stéphane Hulard
  */
 class NoCoverageDriverAvailableExceptionSpec extends ObjectBehavior
 {
-    function it_is_initializable()
+    public function it_is_initializable(): void
     {
         $this->shouldBeAnInstanceOf(\RuntimeException::class);
         $this->shouldHaveType(NoCoverageDriverAvailableException::class);