#13 #11 #10

Author: jenstornell

changelog.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 1.2 beta
+
+- Added exceptions for quality out of range
+- Removed quality argument from gif conversion
+
 ## 1.1
 
 - Changed namespace from `Jens\ImageConverter` to `ImageConverter`

readme.md

@@ -1,6 +1,6 @@
 # PHP Image Converter
 
-*Version 1.1 beta*
+*Version 1.2 beta*
 
 PHP library to convert between **gif**, **jpeg**, **png** and **webp** image files.
 

src/ImageConverter.php

@@ -87,16 +87,25 @@ private function saveImage($to, $image, $quality)
 
         switch ($extension) {
           case 'gif':
-              $image = imagegif($image, $to, $quality);
+              $image = imagegif($image, $to);
               break;
           case 'jpg':
           case 'jpeg':
+              if (isset($quality) && ($quality < -1 && $quality > 100)) {
+                  throw new \InvalidArgumentException(sprintf('The %s quality is out of range', $quality));
+              }
               $image = imagejpeg($image, $to, $quality);
               break;          
           case 'png':
+              if (isset($quality) && ($quality < -1 && $quality > 9)) {
+                  throw new \InvalidArgumentException(sprintf('The %s quality is out of range', $quality));
+              }
               $image = imagepng($image, $to, $quality);
               break;
           case 'webp':
+              if (isset($quality) && ($quality < 0 || $quality > 100)) {
+                  throw new \InvalidArgumentException(sprintf('The %s quality is out of range', $quality));
+              }
               $image = imagewebp($image, $to, $quality);
               break;
           default:
@@ -167,5 +176,5 @@ private function makeDirectory($to)
  */
 function convert($from, $to, $quality = -1) {
   $converter = new ImageConverter();
-  return $converter->convert($from, $to, 5);
+  return $converter->convert($from, $to, $quality);
 }