Skip to content

Commit 402d57a

Browse files
committed
Added switch case #7
1 parent 625dd26 commit 402d57a

File tree

1 file changed

+35
-5
lines changed

1 file changed

+35
-5
lines changed

src/ImageConverter.php

Lines changed: 35 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,23 @@ private function loadImage($from)
4848
throw new \InvalidArgumentException(sprintf('The %s extension is unsupported', $extension));
4949
}
5050

51-
$method = 'imagecreatefrom' . $this->constImageFormat[$extension];
52-
53-
return $method($from);
51+
$format = $this->constImageFormat[$extension];
52+
53+
switch ($format) {
54+
case 'jpg':
55+
case 'jpeg':
56+
$image = imagecreatefromjpeg($from);
57+
break;
58+
case 'gif':
59+
$image = imagecreatefromgif($from);
60+
break;
61+
case 'png':
62+
$image = imagecreatefrompng($from);
63+
break;
64+
default:
65+
$image = null;
66+
}
67+
return $image;
5468
}
5569

5670
private function saveImage($to, $image, $quality)
@@ -68,9 +82,25 @@ private function saveImage($to, $image, $quality)
6882
$this->makeDirectory($to);
6983
}
7084

71-
$method = 'image' . $extension;
85+
switch ($extension) {
86+
case 'jpg':
87+
case 'jpeg':
88+
$image = imagejpeg($image, $to, $quality);
89+
break;
90+
case 'gif':
91+
$image = imagegif($image, $to, $quality);
92+
break;
93+
case 'png':
94+
$image = imagepng($image, $to, $quality);
95+
break;
96+
case 'webp':
97+
$image = imagewebp($image, $to, $quality);
98+
break;
99+
default:
100+
$image = null;
101+
}
72102

73-
return $method($image, $to, $quality);
103+
return $image;
74104
}
75105

76106
/**

0 commit comments

Comments
 (0)