chore(testdata): fix solidity warnings: shadowing of builtin symbol and unhandled low-level calls (#12189)

* fix shadowed variables, shadowed globals, unhandled results

* clean up

* re-apply 2519

* Fix testdata

---------

Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com>

Author: zerosnacks

crates/forge/tests/fixtures/ExpectEmitFailures.t.sol

@@ -109,7 +109,8 @@ contract Emitter {
 /// Emulates `Emitter` in #760
 contract LowLevelCaller {
     function f() external {
-        address(this).call(abi.encodeWithSignature("g()"));
+        (bool success,) = address(this).call(abi.encodeWithSignature("g()"));
+        require(success, "call failed");
     }
 
     function g() public {}

testdata/default/cheats/Broadcast.t.sol

@@ -21,7 +21,7 @@ contract Test is ForgeTest {
         return b;
     }
 
-    function inc() public returns (uint256) {
+    function inc() public {
         changed += 1;
     }
 
@@ -539,7 +539,7 @@ contract SignatureTester {
         owner = msg.sender;
     }
 
-    function verifySignature(bytes32 digest, uint8 v, bytes32 r, bytes32 s) public view returns (bool) {
+    function verifySignature(bytes32 digest, uint8 v, bytes32 r, bytes32 s) public view {
         require(ecrecover(digest, v, r, s) == owner, "Invalid signature");
     }
 }

testdata/default/cheats/ExpectCall.t.sol

@@ -55,7 +55,8 @@ contract SimpleCall {
 
 contract ProxyWithDelegateCall {
     function delegateCall(SimpleCall simpleCall) public {
-        address(simpleCall).delegatecall(abi.encodeWithSignature("call()"));
+        (bool success,) = address(simpleCall).delegatecall(abi.encodeWithSignature("call()"));
+        require(success, "delegatecall failed");
     }
 }
 

testdata/default/cheats/ExpectEmit.t.sol

@@ -108,7 +108,8 @@ contract Emitter {
 /// Emulates `Emitter` in #760
 contract LowLevelCaller {
     function f() external {
-        address(this).call(abi.encodeWithSignature("g()"));
+        (bool success,) = address(this).call(abi.encodeWithSignature("g()"));
+        require(success, "call failed");
     }
 
     function g() public {}

testdata/default/cheats/Fork2.t.sol

@@ -11,7 +11,7 @@ contract MyContract {
     uint256 forkId;
     bytes32 blockHash;
 
-    constructor(uint256 _forkId) public {
+    constructor(uint256 _forkId) {
         forkId = _forkId;
         blockHash = blockhash(block.number - 1);
     }
@@ -94,14 +94,14 @@ contract ForkTest is Test {
     // test that we can "roll" blocks until a transaction
     function testCanRollForkUntilTransaction() public {
         // block to run transactions from
-        uint256 block = 16261704;
+        uint256 blockNumber = 16261704;
 
         // fork until previous block
-        uint256 fork = vm.createSelectFork("mainnet", block - 1);
+        uint256 fork = vm.createSelectFork("mainnet", blockNumber - 1);
 
         // block transactions in order: https://beaconcha.in/block/16261704#transactions
         // run transactions from current block until tx
-        bytes32 tx = 0x67cbad73764049e228495a3f90144aab4a37cb4b5fd697dffc234aa5ed811ace;
+        bytes32 transaction = 0x67cbad73764049e228495a3f90144aab4a37cb4b5fd697dffc234aa5ed811ace;
 
         // account that sends ether in 2 transaction before tx
         address account = 0xAe45a8240147E6179ec7c9f92c5A18F9a97B3fCA;
@@ -115,7 +115,7 @@ contract ForkTest is Test {
         uint256 newBalance = account.balance - transferAmount;
 
         // execute transactions in block until tx
-        vm.rollFork(tx);
+        vm.rollFork(transaction);
 
         // balance must be less than newBalance due to gas spent
         assert(account.balance < newBalance);
@@ -152,7 +152,7 @@ contract ForkTest is Test {
         DummyContract dummy = new DummyContract();
 
         // this will succeed since `dummy` is deployed on the currently active fork
-        string memory msg = dummy.hello();
+        string memory message = dummy.hello();
 
         address dummyAddress = address(dummy);
 

testdata/default/cheats/Prank.t.sol

@@ -198,7 +198,8 @@ contract PrankTest is Test {
         vm.expectRevert("vm.prank: cannot `prank` delegate call from an EOA");
         vm.prank(alice, true);
         // Should fail when EOA pranked with delegatecall.
-        address(impl).delegatecall(abi.encodeWithSignature("assertCorrectCaller(address)", alice));
+        (bool success,) = address(impl).delegatecall(abi.encodeWithSignature("assertCorrectCaller(address)", alice));
+        require(success, "delegate call failed");
     }
 
     function testPrankSender(address sender) public {

testdata/default/cheats/RecordAccountAccesses.t.sol

@@ -223,7 +223,8 @@ contract RecordAccountAccessesTest is Test {
         Proxy proxy = new Proxy(address(one));
 
         vm.startStateDiffRecording();
-        address(proxy).call(abi.encodeCall(StorageAccessor.read, bytes32(uint256(1234))));
+        (bool success,) = address(proxy).call(abi.encodeCall(StorageAccessor.read, bytes32(uint256(1234))));
+        require(success, "call failed");
         Vm.AccountAccess[] memory called = filterExtcodesizeForLegacyTests(vm.stopAndReturnStateDiff());
 
         assertEq(called.length, 2, "incorrect length");

testdata/default/repros/Issue6293.t.sol

@@ -7,7 +7,8 @@ import "utils/Test.sol";
 contract Issue6293Test is Test {
     constructor() {
         require(address(this).balance > 0);
-        payable(address(1)).call{value: 1}("");
+        (bool success,) = payable(address(1)).call{value: 1}("");
+        require(success, "call failed");
     }
 
     function test() public {

testdata/default/repros/Issue7481.t.sol

@@ -12,7 +12,8 @@ contract Issue7481Test is Test {
         vm.createSelectFork("mainnet", 19514903);
 
         // Transfer some funds to sender of tx being transacted to ensure that it appears in journaled state
-        payable(address(0x5C60cD7a3D50877Bfebd484750FBeb245D936dAD)).call{value: 1}("");
+        (bool success,) = payable(address(0x5C60cD7a3D50877Bfebd484750FBeb245D936dAD)).call{value: 1}("");
+        console.log(success);
         vm.transact(0xccfd66fc409a633a99b5b75b0e9a2040fcf562d03d9bee3fefc1a5c0eb49c999);
 
         // Revert the current call to ensure that revm can revert state journal

testdata/foundry.toml

@@ -8,9 +8,9 @@ ignored_error_codes = [
     1878, # SPDX license identifier not provided
     2018, # Function state mutability can be restricted
     2072, # Unused local variable
-    2319, # This declaration shadows a builtin symbol
     2519, # This declaration shadows an existing declaration
     3860, # Contract init code size exceeds limit
+    5159, # Selfdestruct has been deprecated
     5574, # Contract code size exceeds limit
     5667, # Unused function parameter
 ]