Revert "PR27345, binutils/arsup.c: lstat() not available on all targets"

nickclifton · nickclifton · commit 86cb5ea5639c · 2021-02-05T14:08:16.000Z
This reverts commit c0034ac. Given the problems associated with this patch and the others intended to fix the smart_rename CVE, the decision has been taken to revert the patches for the 2.36.1 point release.
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
@@ -1,8 +1,3 @@
-2021-02-05  Alan Modra  <amodra@gmail.com>
-
-	PR 27345
-	* arsup.c (ar_save): Use stat rather than lstat.
-
 2021-02-03  Alan Modra  <amodra@gmail.com>
 
 	PR 27270
diff --git a/binutils/arsup.c b/binutils/arsup.c
@@ -357,7 +357,7 @@ ar_save (void)
 #endif
       bfd_close (obfd);
 
-      if (stat (real_name, &target_stat) != 0)
+      if (lstat (real_name, &target_stat) != 0)
 	{
 	  /* The temp file created in ar_open has mode 0600 as per mkstemp.
 	     Create the real empty output file here so smart_rename will

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ ar_save (void)`
`357`	`357`	`#endif`
`358`	`358`	`bfd_close (obfd);`
`359`	`359`
`360`		`- if (stat (real_name, &target_stat) != 0)`
	`360`	`+ if (lstat (real_name, &target_stat) != 0)`
`361`	`361`	`{`
`362`	`362`	`/* The temp file created in ar_open has mode 0600 as per mkstemp.`
`363`	`363`	`Create the real empty output file here so smart_rename will`