removed size component, changed the logic of len function, modified constructor, commented test cases

Author: aman-godara

src/stdlib_stringlist.f90

@@ -51,7 +51,6 @@ module stdlib_stringlist
 
     type stringlist_type
         private
-        integer :: size = 0
         type(string_type), dimension(:), allocatable :: stringarray
 
     contains
@@ -98,7 +97,6 @@ module stdlib_stringlist
     interface stringlist_type
         module procedure new_stringlist
         module procedure new_stringlist_carray
-        module procedure new_stringlist_sarray
     end interface
 
     !> Version: experimental
@@ -154,7 +152,7 @@ pure function new_stringlist()
         type(stringlist_type)                           :: new_stringlist
         type(string_type), dimension(0)                 :: sarray
 
-        new_stringlist = stringlist_type( 0, sarray )
+        new_stringlist = stringlist_type( sarray )
 
     end function new_stringlist
 
@@ -174,16 +172,6 @@ pure function new_stringlist_carray( array )
 
     end function new_stringlist_carray
 
-    !> Constructor to convert stringarray to stringlist
-    !> Returns a new instance of type stringlist
-    pure function new_stringlist_sarray( array )
-        type(string_type), dimension(:), intent(in)     :: array
-        type(stringlist_type)                           :: new_stringlist_sarray
-
-        new_stringlist_sarray = stringlist_type( size(array), array )
-    
-    end function new_stringlist_sarray
-
   ! constructor for stringlist_index_type:
 
     !> Returns an instance of type 'stringlist_index_type' representing forward index 'idx'
@@ -455,7 +443,6 @@ end function ineq_sarray_stringlist
     subroutine clear_list( list )
         class(stringlist_type), intent(inout) :: list
 
-        list%size = 0
         if ( allocated( list%stringarray ) ) then
             deallocate( list%stringarray )
         end if
@@ -471,7 +458,10 @@ end subroutine clear_list
     pure integer function length_list( list )
         class(stringlist_type), intent(in) :: list
 
-        length_list = list%size
+        length_list = 0
+        if ( allocated( list%stringarray ) ) then
+            length_list = size( list%stringarray )
+        end if
 
     end function length_list
 
@@ -609,8 +599,6 @@ subroutine insert_before_empty_positions( list, idxn, positions )
 
             call move_alloc( new_stringarray, list%stringarray )
 
-            list%size = new_len
-
         end if
 
     end subroutine insert_before_empty_positions

src/tests/stringlist/test_insert_at.f90

@@ -368,12 +368,12 @@ subroutine test_constructor
         call check( work_list == sarray, "test_constructor:&
             & test_case 2 work_list == sarray" )
 
-        write (*,*) "test_constructor:        Starting test case 3!"
-        work_list = stringlist_type( sarray )
-        call check( work_list == carray, "test_constructor:&
-            & test_case 3 work_list == carray" )
-        call check( work_list == sarray, "test_constructor:&
-            & test_case 3 work_list == sarray" )
+        ! write (*,*) "test_constructor:        Starting test case 3!"
+        ! work_list = stringlist_type( sarray )
+        ! call check( work_list == carray, "test_constructor:&
+        !     & test_case 3 work_list == carray" )
+        ! call check( work_list == sarray, "test_constructor:&
+        !     & test_case 3 work_list == sarray" )
 
     end subroutine test_constructor