cleanup test

Author: perazz

test/linalg/test_linalg_lstsq.fypp

@@ -110,22 +110,25 @@ module test_linalg_least_squares
         ! Dimension of the problem.
         integer(ilp), parameter :: n = 42
         ! Data for the least-squares problem.
-        complex(dp) :: A(n+1, n), b(n+1), x_true(n), x_lstsq(n+1)
+        complex(dp) :: A(n+1, n), b(n+1), x_true(n), x_lstsq(n)
         ! Internal variables.
         real(dp), allocatable :: tmp(:, :, :), tmp_vec(:, :)
         ! Error handler
         type(linalg_state_type) :: state
 
         ! Zero-out data.
-        A = 0.0_dp ; b = 0.0_dp ; x_true = 0.0_dp ; x_lstsq = 0.0_dp
-        allocate(tmp(n+1, n, 2))  ; tmp = 0.0_dp
-        allocate(tmp_vec(n, 2)) ; tmp_vec = 0.0_dp
+        A = 0.0_dp
+        b = 0.0_dp
+        x_lstsq = 0.0_dp
+        allocate(tmp(n+1, n, 2), tmp_vec(n, 2), source=0.0_dp)
 
         ! Generate a random complex least-squares problem of size (n+1, n).
-        call random_number(tmp) ; call random_number(tmp_vec)
-        A = cmplx(tmp(:, :, 1), tmp(:, :, 2), kind=dp)
+        call random_number(tmp)
+        call random_number(tmp_vec)
+        
+        A      = cmplx(tmp(:, :, 1), tmp(:, :, 2), kind=dp)
         x_true = cmplx(tmp_vec(:, 1), tmp_vec(:, 2), kind=dp)
-        b = matmul(A, x_true)
+        b      = matmul(A, x_true)
 
         ! Solve the lstsq problem.
         call solve_lstsq(A, b, x_lstsq, err=state)
@@ -134,6 +137,10 @@ module test_linalg_least_squares
         call check(error,state%ok(),'issue 823 returned '//state%print())
         if (allocated(error)) return
 
+        ! Check that least squares are verified
+        call check(error,all(abs(x_true-x_lstsq)<sqrt(epsilon(0.0_dp))),'issue 823 results')
+        if (allocated(error)) return
+
     end subroutine test_issue_823
 
 end module test_linalg_least_squares