test(parser): add test for private interfaces

Author: gnikit

fortls/parsers/internal/parser.py

@@ -18,7 +18,6 @@
 from fortls.constants import (
     DO_TYPE_ID,
     INTERFACE_TYPE_ID,
-    MODULE_TYPE_ID,
     SELECT_TYPE_ID,
     SUBMODULE_TYPE_ID,
     FRegex,
@@ -1657,10 +1656,10 @@ def parse(
                     msg = "Visibility statement without enclosing scope"
                     file_ast.add_error(msg, Severity.error, line_no, 0)
                 else:
-                    if (len(obj_info.obj_names) == 0) and (obj_info.type == 1):
+                    if len(obj_info.obj_names) == 0 and obj_info.type == 1:  # private
                         file_ast.current_scope.set_default_vis(-1)
                     else:
-                        if obj_info.type == MODULE_TYPE_ID:
+                        if obj_info.type == 1:  # private
                             for word in obj_info.obj_names:
                                 file_ast.add_private(word)
                         else:

test/test_parser.py

@@ -31,3 +31,11 @@ def test_submodule():
     except Exception as e:
         print(e)
         assert False
+
+
+def test_private_visibility_interfaces():
+    file_path = test_dir / "vis" / "private.f90"
+    file = FortranFile(str(file_path))
+    err_str, _ = file.load_from_disk()
+    file.parse()
+    assert err_str is None

test/test_source/.fortls

@@ -9,7 +9,8 @@
     "./diag/",
     "docs",
     "rename",
-    "parse"
+    "parse",
+    "vis"
   ]
 
 }

test/test_source/vis/private.f90

@@ -0,0 +1,17 @@
+module visibility
+    private :: name
+    private :: generic_interf
+    interface name
+        module procedure :: name_sp
+    end interface name
+    interface
+        subroutine generic_interf(noop)
+            integer, intent(in) :: noop
+        end subroutine generic_interf
+    end interface
+contains
+    subroutine name_sp(val)
+        real(4), intent(in) :: val
+        print *, 'name_sp', val
+    end subroutine name_sp
+end module visibility