Skip to content

Update to mbedtls-sys 2.28, update test keys, and make sure async tests are run #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 15, 2023
Merged

Update to mbedtls-sys 2.28, update test keys, and make sure async tests are run #225

merged 10 commits into from
Mar 15, 2023

Conversation

@zugzwang
Copy link
Collaborator

@zugzwang zugzwang commented Mar 13, 2023

No description provided.

@zugzwang zugzwang changed the base branch from master to mz/async-support March 13, 2023 15:34
@zugzwang
Add tokio/rt to required features for async tests
7abdc1b 
Also add the full test command to ct.sh (without it, tests execute)
@zugzwang zugzwang force-pushed the francisco/async-support-2.28 branch from 67029d2 to 7abdc1b Compare March 13, 2023 15:39
@zugzwang zugzwang mentioned this pull request Mar 13, 2023
Merged
@zugzwang

This comment was marked as outdated.

Sign in to view
bors bot added a commit that referenced this pull request Mar 13, 2023
@bors
Try #225:
de28d5b
@bors

This comment was marked as outdated.

Sign in to view
@Taowyoo

This comment was marked as duplicate.

Sign in to view
bors bot added a commit that referenced this pull request Mar 13, 2023
@bors
Try #225:
f83ac89
@Taowyoo

This comment was marked as duplicate.

Sign in to view
@Taowyoo Taowyoo force-pushed the francisco/async-support-2.28 branch from 0b4cc62 to 22394bb Compare March 13, 2023 22:48
@Taowyoo

This comment was marked as duplicate.

Sign in to view
bors bot added a commit that referenced this pull request Mar 13, 2023
@bors
Try #225:
843f00d
@Taowyoo Taowyoo force-pushed the francisco/async-support-2.28 branch from 22394bb to 5652d9c Compare March 13, 2023 23:13
@bors

This comment was marked as outdated.

Sign in to view
@Taowyoo

This comment was marked as duplicate.

Sign in to view
bors bot added a commit that referenced this pull request Mar 13, 2023
@bors
Try #225:
51c851b
@bors

This comment was marked as outdated.

Sign in to view
@Taowyoo Taowyoo force-pushed the francisco/async-support-2.28 branch from 077de8b to ba064c9 Compare March 14, 2023 00:29
@Taowyoo

This comment was marked as duplicate.

Sign in to view
bors bot added a commit that referenced this pull request Mar 14, 2023
@bors
Try #225:
6dcbba4
@bors

This comment was marked as outdated.

Sign in to view
@Taowyoo

This comment was marked as duplicate.

Sign in to view
bors bot added a commit that referenced this pull request Mar 14, 2023
@bors
Try #225:
bbbe0fb
@Taowyoo

This comment was marked as duplicate.

Sign in to view
@bors

This comment was marked as outdated.

Sign in to view
@Taowyoo

This comment was marked as duplicate.

Sign in to view
@Taowyoo

This comment was marked as duplicate.

Sign in to view
bors bot added a commit that referenced this pull request Mar 14, 2023
@bors
Try #225:
1e529ad
Taowyoo
Taowyoo reviewed Mar 14, 2023
View reviewed changes
Taowyoo
Taowyoo reviewed Mar 14, 2023
View reviewed changes
@Taowyoo
Copy link
Collaborator

Taowyoo commented Mar 14, 2023

bors try

bors bot added a commit that referenced this pull request Mar 14, 2023
@bors
Try #225:
6efd54a
@bors
Copy link
Contributor

bors bot commented Mar 14, 2023

try

Build succeeded:

  • continuous-integration/travis-ci/push

zugzwang
zugzwang commented Mar 14, 2023
View reviewed changes
zugzwang
zugzwang commented Mar 14, 2023
View reviewed changes
zugzwang
zugzwang commented Mar 14, 2023
View reviewed changes
zugzwang
zugzwang commented Mar 14, 2023
View reviewed changes
Copy link
Collaborator Author

@zugzwang zugzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commits look good to me, although

  • Please address comments
  • I cannot approve the PR since I am an author.

@Taowyoo

This comment was marked as outdated.

Sign in to view
bors bot added a commit that referenced this pull request Mar 14, 2023
@bors @zugzwang @Taowyoo
Merge #225
a392988 
225: Update to mbedtls-sys 2.28, update test keys, and make sure async tests are run r=Taowyoo a=zugzwang



Co-authored-by: francisco <francisco.vialprado@fortanix.com>
Co-authored-by: Yuxiang Cao <yuxiang.cao@fortanix.com>
@Taowyoo

This comment was marked as outdated.

Sign in to view
@bors

This comment was marked as outdated.

Sign in to view
mzohreva
mzohreva reviewed Mar 15, 2023
View reviewed changes
@mzohreva
Copy link
Contributor

mzohreva commented Mar 15, 2023

Looks good to me. I'll leave it up to you how you want to merge things.

@Taowyoo

This comment was marked as off-topic.

Sign in to view
bors bot added a commit that referenced this pull request Mar 15, 2023
@bors @zugzwang @Taowyoo
Merge #225
8a72c52 
225: Update to mbedtls-sys 2.28, update test keys, and make sure async tests are run r=Taowyoo a=zugzwang



Co-authored-by: francisco <francisco.vialprado@fortanix.com>
Co-authored-by: Yuxiang Cao <yuxiang.cao@fortanix.com>
@bors

This comment was marked as outdated.

Sign in to view
@Taowyoo

This comment was marked as outdated.

Sign in to view
@Taowyoo
Copy link
Collaborator

Taowyoo commented Mar 15, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 15, 2023

Build succeeded:

@bors bors bot merged commit ae32aa4 into mz/async-support Mar 15, 2023
@Taowyoo Taowyoo deleted the francisco/async-support-2.28 branch March 21, 2023 22:59
@Taowyoo Taowyoo restored the francisco/async-support-2.28 branch March 21, 2023 23:00
@Taowyoo Taowyoo deleted the francisco/async-support-2.28 branch July 12, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Taowyoo Taowyoo Taowyoo approved these changes

+1 more reviewer

@mzohreva mzohreva mzohreva left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zugzwang @Taowyoo @mzohreva