Skip to content

Commit 32ba8cc

Browse files
pepamartinec66Ton99
authored andcommitted
Pass whole type hierarchy to model (#111)
* Pass whole type hierarchy to model * Fix array construction (PHP 5.3 compatibility)
1 parent c6b9614 commit 32ba8cc

File tree

2 files changed

+24
-5
lines changed

2 files changed

+24
-5
lines changed

Factory/JsFormValidatorFactory.php

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
use Symfony\Component\Form\Extension\Core\DataTransformer\ChoiceToBooleanArrayTransformer;
1212
use Symfony\Component\Form\Form;
1313
use Symfony\Component\Form\FormInterface;
14+
use Symfony\Component\Form\ResolvedFormTypeInterface;
15+
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
1416
use Symfony\Component\Translation\TranslatorInterface;
1517
use Symfony\Component\Validator\Constraint;
1618
use Symfony\Component\Validator\Mapping\ClassMetadata;
@@ -65,7 +67,7 @@ class JsFormValidatorFactory
6567
/**
6668
* @param ValidatorInterface $validator
6769
* @param TranslatorInterface $translator
68-
* @param \Symfony\Component\Routing\Generator\UrlGeneratorInterface $router
70+
* @param UrlGeneratorInterface $router
6971
* @param array $config
7072
* @param string $domain
7173
*/
@@ -244,7 +246,7 @@ public function createJsModel(Form $form)
244246
$model = new JsFormElement;
245247
$model->id = $this->getElementId($form);
246248
$model->name = $form->getName();
247-
$model->type = $conf->getType()->getInnerType()->getName();
249+
$model->type = $this->getFormTypeHierarchy($conf->getType());
248250
$model->invalidMessage = $this->translateMessage(
249251
$conf->getOption('invalid_message'),
250252
$conf->getOption('invalid_message_parameters')
@@ -264,6 +266,19 @@ public function createJsModel(Form $form)
264266
return $model;
265267
}
266268

269+
private function getFormTypeHierarchy(ResolvedFormTypeInterface $formType)
270+
{
271+
$type = array(
272+
$formType->getName(),
273+
);
274+
275+
while ($formType = $formType->getParent()) {
276+
$type[] = $formType->getName();
277+
}
278+
279+
return $type;
280+
}
281+
267282
/**
268283
* Create the JsFormElement for all the children of specified element
269284
*

Resources/public/js/FpJsFormValidator.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,10 @@ var FpJsFormValidator = new function () {
381381
this.customizeMethods = new FpJsCustomizeMethods();
382382
this.constraintsCounter = 0;
383383

384+
function elementIsType(element, type) {
385+
return element.type.indexOf(type) >= 0;
386+
}
387+
384388
//noinspection JSUnusedGlobalSymbols
385389
this.addModel = function (model, onLoad) {
386390
var self = this;
@@ -517,7 +521,7 @@ var FpJsFormValidator = new function () {
517521

518522
this.checkParentCascadeOption = function (element) {
519523
var result = true;
520-
if (element.parent && !element.parent.cascade && 'collection' != element.parent.type) {
524+
if (element.parent && !element.parent.cascade && !elementIsType(element.parent, 'collection')) {
521525
result = false;
522526
} else if (element.parent) {
523527
result = this.checkParentCascadeOption(element.parent);
@@ -575,7 +579,7 @@ var FpJsFormValidator = new function () {
575579

576580
if (i && undefined === value) {
577581
value = this.getMappedValue(element);
578-
} else if ('collection' == element.type) {
582+
} else if (elementIsType(element, 'collection')) {
579583
value = {};
580584
for (var childName in element.children) {
581585
value[childName] = this.getMappedValue(element.children[childName]);
@@ -615,7 +619,7 @@ var FpJsFormValidator = new function () {
615619
}
616620

617621
var value;
618-
if ('checkbox' == element.type || 'radio' == element.type) {
622+
if (elementIsType(element, 'checkbox') || elementIsType(element, 'radio')) {
619623
value = element.domNode.checked;
620624
} else if ('select' === element.domNode.tagName.toLowerCase()) {
621625
value = [];

0 commit comments

Comments
 (0)