feat: add index to optimize update_effective_volumes trigger

Add idx_moves_update_effective_volumes index to prevent sequential scans
on every INSERT when MOVES_HISTORY feature is enabled (ON by default).

The update_effective_volumes trigger runs after each move insertion and
updates all moves with effective_date > new.effective_date. Without this
index, this operation causes significant performance degradation at scale.

Changes:
- New migration 45: Create idx_moves_update_effective_volumes
- Migration 45 renamed to 46: Updated to drop moves_range_dates

Author: flemzord

internal/storage/bucket/migrations/45-add-moves-update-effective-volumes-index/notes.yaml

@@ -0,0 +1,35 @@
+name: Add Index for Trigger Optimization (3/5)
+description: |
+  Create optimized index for the update_effective_volumes trigger that runs on every
+  INSERT when MOVES_HISTORY feature is enabled (ON by default).
+
+  This trigger updates all moves where effective_date > new.effective_date, which
+  requires an efficient index on (accounts_address, asset, effective_date) to avoid
+  full table scans on large datasets.
+
+changes:
+  moves_table:
+    - action: "CREATE"
+      new_index: "idx_moves_update_effective_volumes (accounts_address, asset, effective_date)"
+      reason: |
+        Optimizes the UPDATE query in update_effective_volumes trigger.
+        Without this index, every INSERT causes a slow sequential scan when
+        MOVES_HISTORY is ON, causing severe performance degradation.
+
+        The existing moves_range_dates index has the same columns but in a
+        different order (account_address, asset, effective_date) and was created
+        before the column rename. This new index ensures optimal performance.
+
+affected_queries:
+  - "update_effective_volumes trigger: UPDATE moves WHERE effective_date > ?"
+  - "Runs on EVERY INSERT when MOVES_HISTORY=ON (default configuration)"
+
+performance_impact:
+  - "CRITICAL improvement for write performance with MOVES_HISTORY enabled"
+  - "Reduces INSERT latency by eliminating sequential scans on moves table"
+  - "Essential for maintaining performance at scale with history tracking"
+
+migration_safety:
+  - "Index creation is non-blocking"
+  - "No data modification"
+  - "moves_range_dates will be dropped in next migration (46) as redundant"

internal/storage/bucket/migrations/45-add-moves-update-effective-volumes-index/up.sql

@@ -0,0 +1,12 @@
+set search_path = '{{.Schema}}';
+
+-- ========================================
+-- MOVES TABLE INDEX FOR TRIGGER OPTIMIZATION (3/5)
+-- ========================================
+
+-- Critical: Index to optimize update_effective_volumes trigger
+-- This trigger runs on EVERY INSERT when MOVES_HISTORY feature is ON
+-- The trigger updates all moves with effective_date > new.effective_date
+-- Replaces/optimizes: moves_range_dates which has suboptimal column order
+create index idx_moves_update_effective_volumes
+    on "{{.Schema}}".moves (accounts_address, asset, effective_date);

internal/storage/bucket/migrations/45-drop-old-indexes/notes.yaml renamed to internal/storage/bucket/migrations/46-drop-old-indexes/notes.yaml

@@ -1,15 +1,19 @@
-name: Drop Old Indexes (5/5)
+name: Drop Old Indexes (6/6)
 description: |
   Drop all old suboptimal indexes that have been replaced by new optimized indexes
-  created in migrations 41-44. This final step completes the index optimization process.
+  created in migrations 41-45. This final step completes the index optimization process.
 
 changes:
   moves_table:
     - action: "DROP"
       old_indexes:
         - "moves_post_commit_volumes"
         - "moves_effective_post_commit_volumes"
-      reason: "Replaced by idx_moves_pit_insertion and idx_moves_pit_effective in migrations 41-42"
+        - "moves_range_dates"
+      reason: |
+        - moves_post_commit_volumes and moves_effective_post_commit_volumes
+          replaced by idx_moves_pit_insertion and idx_moves_pit_effective in migrations 41-42
+        - moves_range_dates replaced by idx_moves_update_effective_volumes in migration 45
 
   accounts_metadata_table:
     - action: "DROP"

internal/storage/bucket/migrations/45-drop-old-indexes/up.sql renamed to internal/storage/bucket/migrations/46-drop-old-indexes/up.sql

@@ -4,9 +4,10 @@ set search_path = '{{.Schema}}';
 -- DROP OLD INDEXES
 -- ========================================
 
--- Drop old moves table indexes (replaced by migrations 41-42)
+-- Drop old moves table indexes (replaced by migrations 41-42-45)
 drop index if exists moves_post_commit_volumes;
 drop index if exists moves_effective_post_commit_volumes;
+drop index if exists moves_range_dates;
 
 -- Drop old accounts_metadata index (replaced by migration 43)
 drop index if exists accounts_metadata_revisions;