fix: from reviews

Author: gfyrag

internal/storage/bucket/migrations/18-transactions-fill-inserted-at/up.sql

@@ -34,7 +34,7 @@ do $$
 			with _rows as (
 				select *
 				from logs_transactions
-				where row_number >= i and row_number < i + _batch_size
+				where row_number > i and row_number <= i + _batch_size
 			)
 			update transactions
 			set inserted_at = _rows.date

internal/storage/bucket/migrations/27-fix-invalid-pcv/up.sql

@@ -1,67 +1,6 @@
 do $$
-	declare
-		_offset integer := 0;
-		_batch_size integer := 1000;
 	begin
-		set search_path = '{{ .Schema }}';
-
--- 		drop table if exists moves_view;
---
--- 		create table moves_view as
--- 		select transactions_seq, public.aggregate_objects(jsonb_build_object(accounts_address, volumes)) as volumes
--- 		from (
--- 			select transactions_seq, accounts_address, public.aggregate_objects(json_build_object(asset, json_build_object('input', (post_commit_volumes).inputs, 'output', (post_commit_volumes).outputs))::jsonb) as volumes
--- 			from (
--- 				SELECT DISTINCT ON (moves.transactions_seq, accounts_address, asset) moves.transactions_seq, accounts_address, asset,
--- 							first_value(post_commit_volumes) OVER (
--- 						PARTITION BY moves.transactions_seq, accounts_address, asset
--- 						ORDER BY seq DESC
--- 						) AS post_commit_volumes
--- 				FROM moves
--- 				where insertion_date < (
--- 					select tstamp from goose_db_version where version_id = 12
--- 				)
--- 			) moves
--- 			group by transactions_seq, accounts_address
--- 		) data
--- 		group by transactions_seq;
---
--- 		create index moves_view_idx on moves_view(transactions_seq);
--- 		-- speed up hash join when updating rows later
--- 		alter table moves_view add foreign key(transactions_seq) references transactions(seq);
---
--- 		if (select count(*) from moves_view) = 0 then
--- 			drop table moves_view;
--- 			return;
--- 		end if;
---
--- 		perform pg_notify('migrations-{{ .Schema }}', 'init: ' || (select count(*) from moves_view));
---
--- 		loop
--- 			with data as (
--- 				select transactions_seq, volumes
--- 				from moves_view
--- 				-- play better than offset/limit
--- 				where transactions_seq >= _offset and transactions_seq < _offset + _batch_size
--- 			)
--- 			update transactions
--- 			set post_commit_volumes = data.volumes
--- 			from data
--- 			where transactions.seq = data.transactions_seq;
---
--- 			if not found then
--- 				drop table moves_view;
--- 				exit;
--- 			end if;
---
--- 			_offset = _offset + _batch_size;
---
--- 			perform pg_notify('migrations-{{ .Schema }}', 'continue: ' || _batch_size);
---
--- 			commit;
--- 		end loop;
---
--- 		drop table if exists moves_view;
+		raise notice 'Migration superseded by next migration';
 	end
 $$;
 

internal/storage/bucket/migrations/32-fix-log-data-for-reverted-transactions/up.sql

@@ -23,7 +23,7 @@ do $$
 			reversed.revertedTransactionID = transactions.id and
 			reversed.ledger = transactions.ledger;
 
-		create index txs_view_idx on txs_view(log_id, id);
+		create index txs_view_idx on txs_view(row_number);
 
 		if (select count(*) from txs_view) = 0 then
 			return;
@@ -35,7 +35,7 @@ do $$
 			with data as (
 				select *
 				from txs_view
-				where row_number >= _offset and row_number < _offset + _batch_size
+				where row_number > _offset and row_number <= _offset + _batch_size
 			)
 			update logs
 			set data = data || jsonb_build_object('revertedTransaction', jsonb_build_object(

internal/storage/bucket/migrations/33-fix-invalid-date-format/up.sql

@@ -34,7 +34,7 @@ do $$
 			with data as (
 				select *
 				from txs_view
-				where row_number >= _offset and row_number < _offset + _batch_size
+				where row_number > _offset and row_number <= _offset + _batch_size
 			)
 			update logs
 			set data = data || jsonb_build_object('revertedTransaction', jsonb_build_object(