Skip to content

Commit f8f9e5a

Browse files
committed
update skewed gauss func for consistency
1 parent 09ac2ef commit f8f9e5a

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

specparam/modes/definitions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from specparam.modes.mode import Mode
66
from specparam.modes.params import ParamDefinition
77
from specparam.modes.funcs import (expo_function, expo_nk_function, double_expo_function,
8-
gaussian_function, skewnorm_function, cauchy_function)
8+
gaussian_function, skewed_gaussian_function, cauchy_function)
99
from specparam.modes.jacobians import jacobian_gauss
1010

1111
###################################################################################################
@@ -118,7 +118,7 @@
118118
name='skewed_gaussian',
119119
component='periodic',
120120
description='Skewed Gaussian peak fit function.',
121-
func=skewnorm_function,
121+
func=skewed_gaussian_function,
122122
jacobian=None,
123123
params=params_skewed_gaussian,
124124
ndim=2,

specparam/modes/funcs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ def gaussian_function(xs, *params):
3535
return ys
3636

3737

38-
def skewnorm_function(xs, *params):
39-
"""Skewed normal distribution fitting function.
38+
def skewed_gaussian_function(xs, *params):
39+
"""Skewed gaussian fitting function.
4040
4141
Parameters
4242
----------

specparam/tests/modes/test_funcs.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,23 @@ def test_gaussian_function():
2424
assert max(ys) == hgt
2525
assert np.allclose([ii/sum(ys) for ii in ys], norm.pdf(xs, ctr, wid))
2626

27-
def test_skewnorm_function():
27+
def test_skewed_gaussian_function():
2828

2929
# Check that with no skew, approximate gaussian
3030
ctr, hgt, wid, skew = 50, 5, 10, 1
3131
xs = np.arange(1, 100)
3232
ys_gaus = gaussian_function(xs, ctr, hgt, wid)
33-
ys_skew = skewnorm_function(xs, ctr, hgt, wid, skew)
33+
ys_skew = skewed_gaussian_function(xs, ctr, hgt, wid, skew)
3434
np.allclose(ys_gaus, ys_skew, atol=0.001)
3535

3636
# Check with some skew - right skew (more density after center)
3737
skew1 = 2
38-
ys_skew1 = skewnorm_function(xs, ctr, hgt, wid, skew1)
38+
ys_skew1 = skewed_gaussian_function(xs, ctr, hgt, wid, skew1)
3939
assert sum(ys_skew1[xs<ctr]) < sum(ys_skew1[xs>ctr])
4040

4141
# Check with some skew - left skew (more density before center)
4242
skew2 = -2
43-
ys_skew2 = skewnorm_function(xs, ctr, hgt, wid, skew2)
43+
ys_skew2 = skewed_gaussian_function(xs, ctr, hgt, wid, skew2)
4444
assert sum(ys_skew2[xs<ctr]) > sum(ys_skew2[xs>ctr])
4545

4646
def test_cauchy_function():

0 commit comments

Comments
 (0)