Skip to content

Commit 1a768e5

Browse files
committed
lints
1 parent 62dba14 commit 1a768e5

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

specparam/core/io.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,15 +224,15 @@ def save_event(event, file_name, file_path=None, append=False,
224224

225225
fg = event.get_group(None, None, 'group')
226226
if save_settings and not save_results and not save_data:
227-
fg.save(file_name, file_path, save_settings=True)
227+
fg.save(file_name, file_path, append=append, save_settings=True)
228228
else:
229229
ndigits = len(str(len(event)))
230230
for ind, gres in enumerate(event.event_group_results):
231231
fg.group_results = gres
232232
if save_data:
233233
fg.power_spectra = event.spectrograms[ind, :, :].T
234234
fg.save(file_name + '_{:0{ndigits}d}'.format(ind, ndigits=ndigits),
235-
file_path=file_path, save_results=save_results,
235+
file_path=file_path, append=append, save_results=save_results,
236236
save_settings=save_settings, save_data=save_data)
237237

238238

specparam/objs/event.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import numpy as np
88

99
from specparam.objs import SpectralModel, SpectralTimeModel
10+
from specparam.objs.group import _progress
1011
from specparam.plts.event import plot_event_model
1112
from specparam.data.conversions import event_group_to_dict, event_group_to_dataframe, dict_to_df
1213
from specparam.data.utils import get_group_params, get_results_by_row, flatten_results_dict
@@ -92,14 +93,14 @@ def _reset_event_results(self, length=0):
9293
def has_data(self):
9394
"""Redefine has_data marker to reflect the spectrograms attribute."""
9495

95-
return True if np.any(self.spectrograms) else False
96+
return bool(np.any(self.spectrograms))
9697

9798

9899
@property
99100
def has_model(self):
100101
"""Redefine has_model marker to reflect the event results."""
101102

102-
return True if self.event_group_results else False
103+
return bool(self.event_group_results)
103104

104105

105106
@property
@@ -112,14 +113,14 @@ def n_peaks_(self):
112113

113114
@property
114115
def n_events(self):
115-
# ToDo: double check if we want this - I think is never used internally?
116+
"""How many events are included in the model object."""
116117

117118
return len(self)
118119

119120

120121
@property
121122
def n_time_windows(self):
122-
# ToDo: double check if we want this - I think is never used internally?
123+
"""How many time windows are included in the model object."""
123124

124125
return self.spectrograms[0].shape[1] if self.has_data else 0
125126

@@ -226,7 +227,7 @@ def fit(self, freqs=None, spectrograms=None, freq_range=None, peak_org=None,
226227
"""
227228

228229
# ToDo: here because of circular import - updates / refactors should fix & move
229-
from specparam.objs.group import _progress
230+
#from specparam.objs.group import _progress
230231

231232
if spectrograms is not None:
232233
self.add_data(freqs, spectrograms, freq_range)
@@ -360,7 +361,8 @@ def get_group(self, event_inds, window_inds, output_type='event'):
360361
# Add results for specified power spectra - event group results
361362
temp = [self.event_group_results[ei][wi] for ei in einds for wi in winds]
362363
step = int(len(temp) / len(einds))
363-
output.event_group_results = [temp[ind:ind+step] for ind in range(0, len(temp), step)]
364+
output.event_group_results = \
365+
[temp[ind:ind+step] for ind in range(0, len(temp), step)]
364366

365367
# Add results for specified power spectra - event time results
366368
output.event_time_results = \

specparam/sim/params.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ def _check_values(start, stop, step):
150150
raise ValueError("Inputs 'start' and 'stop' should be positive values.")
151151

152152
if (stop - start) * step < 0:
153-
raise ValueError("The sign of input 'step' does not align with 'start' / 'stop' values.")
153+
raise ValueError("The sign of 'step' does not align with 'start' / 'stop' values.")
154154

155155
if start == stop:
156156
raise ValueError("Input 'start' and 'stop' must be different values.")

0 commit comments

Comments
 (0)