Apply suggestions from code review

scottmcm · oli-obk · scottmcm · commit 259c425bd4a8 · 2025-01-08T18:46:30.000-08:00
Co-authored-by: Oli Scherer &lt;github35764891676564198441@oli-obk.de&gt;
diff --git a/compiler/rustc_mir_transform/src/gvn.rs b/compiler/rustc_mir_transform/src/gvn.rs
@@ -1450,8 +1450,8 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {
             }
         }
 
-        // PtrToPtr-then-Transmute can just transmute the original, so long as the
-        // PtrToPtr didn't change metadata (and thus the size of the pointer)
+        // Transmute-then-PtrToPtr can just transmute the original, so long as the
+        // PtrToPtr won't change metadata (and thus the size of the pointer)
         if let PtrToPtr = kind
             && let Value::Cast {
                 kind: Transmute,

Original file line number	Diff line number	Diff line change
`@@ -1450,8 +1450,8 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {`
`1450`	`1450`	`}`
`1451`	`1451`	`}`
`1452`	`1452`
`1453`		`- // PtrToPtr-then-Transmute can just transmute the original, so long as the`
`1454`		`- // PtrToPtr didn't change metadata (and thus the size of the pointer)`
	`1453`	`+ // Transmute-then-PtrToPtr can just transmute the original, so long as the`
	`1454`	`+ // PtrToPtr won't change metadata (and thus the size of the pointer)`
`1455`	`1455`	`if let PtrToPtr = kind`
`1456`	`1456`	`&& let Value::Cast {`
`1457`	`1457`	`kind: Transmute,`