controllers: return err on auth dir create failure

hiddeco · hiddeco · commit 905602bdfea2 · 2021-11-23T09:51:44.000+01:00
Signed-off-by: Hidde Beydals &lt;hello@hidde.co&gt;
diff --git a/controllers/helmchart_controller.go b/controllers/helmchart_controller.go
@@ -307,6 +307,7 @@ func (r *HelmChartReconciler) fromHelmRepository(ctx context.Context, repo sourc
 		authDir := filepath.Join(workDir, "creds")
 		if err := os.Mkdir(authDir, 0700); err != nil {
 			err = fmt.Errorf("failed to create temporary directory for repository credentials: %w", err)
+			return sourcev1.HelmChartNotReady(c, sourcev1.StorageOperationFailedReason, err.Error()), err
 		}
 		opts, err := getter.ClientOptionsFromSecret(authDir, *secret)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,7 @@ func (r *HelmChartReconciler) fromHelmRepository(ctx context.Context, repo sourc`
`307`	`307`	`authDir := filepath.Join(workDir, "creds")`
`308`	`308`	`if err := os.Mkdir(authDir, 0700); err != nil {`
`309`	`309`	`err = fmt.Errorf("failed to create temporary directory for repository credentials: %w", err)`
	`310`	`+ return sourcev1.HelmChartNotReady(c, sourcev1.StorageOperationFailedReason, err.Error()), err`
`310`	`311`	`}`
`311`	`312`	`opts, err := getter.ClientOptionsFromSecret(authDir, *secret)`
`312`	`313`	`if err != nil {`