build: add GH workflow test.yaml

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>

Author: Paulo Gomes

.github/workflows/build.yaml

@@ -17,31 +17,9 @@ permissions:
   id-token: write # needed for keyless signing
 
 jobs:
-
-  darwin-all-libs-test:
-    runs-on: macos-11
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-      - name: Test build script for darwin-amd64 - libgit2-all
-        run: |
-          make dev-test
-          rm -rf ${GITHUB_WORKSPACE}/build rm -rf ${GITHUB_WORKSPACE}/libgit2
-        env:
-          MACOSX_DEPLOYMENT_TARGET: 10.15
-
-  darwin-libgit2-only-test:
-    runs-on: macos-11
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-      - name: Test build script for darwin-amd64 - libgit2-only
-        run: |
-          LIBGIT2_ONLY=true make dev-test
-        env:
-          MACOSX_DEPLOYMENT_TARGET: 10.15
-
-  docker-build-all-libs:
+  # changing this job name for some reason caused GitHub checks to
+  # hang at `Expected — Waiting for status to be reported`. 
+  build:
     runs-on: ubuntu-latest
     env:
       PLATFORMS: linux/amd64,linux/arm/v7,linux/arm64

.github/workflows/release.yaml

@@ -12,13 +12,11 @@ on:
         default: 'rc'
         required: true
 
-
 permissions:
   contents: write # needed to write releases
   id-token: write # needed for keyless signing
 
 jobs:
-
   linux-x86_64-all-libs:
     runs-on: ubuntu-latest
     steps:
@@ -29,7 +27,7 @@ jobs:
           TARGET_DIR=${GITHUB_WORKSPACE}/build/libgit2-linux-all-libs \
           BUILD_ROOT_DIR=${GITHUB_WORKSPACE}/libgit2/build/amd \
           ./hack/static.sh all
-          
+
           mkdir -p ./libgit2-linux-all-libs/
           mv ${GITHUB_WORKSPACE}/build/libgit2-linux-all-libs/include ./libgit2-linux-all-libs/
           mv ${GITHUB_WORKSPACE}/build/libgit2-linux-all-libs/share ./libgit2-linux-all-libs/
@@ -41,7 +39,7 @@ jobs:
       - uses: actions/upload-artifact@v3
         with:
           name: release-artifact
-          path: '*.tar.gz'
+          path: "*.tar.gz"
           if-no-files-found: error
 
   linux-x86_64-libgit2-only:
@@ -64,7 +62,7 @@ jobs:
       - uses: actions/upload-artifact@v3
         with:
           name: release-artifact
-          path: '*.tar.gz'
+          path: "*.tar.gz"
           if-no-files-found: error
 
   darwin-all-libs:
@@ -75,8 +73,8 @@ jobs:
     # both outcomes onto a single binary for each static library.
     #
     # `macos-11` has been picked as support for arm64 was only added on Xcode 12.
-    # Although some minor versions of Catalina 10.15 can support it, at the time 
-    # of testing, GitHub's macos-10.15 did not seem to. 
+    # Although some minor versions of Catalina 10.15 can support it, at the time
+    # of testing, GitHub's macos-10.15 did not seem to.
     # Cross-compiling to arm64 on that runner consistently failed.
     runs-on: macos-11
     steps:
@@ -90,22 +88,21 @@ jobs:
           TARGET_DIR=${GITHUB_WORKSPACE}/build/darwin-all-libs \
           BUILD_ROOT_DIR=${GITHUB_WORKSPACE}/libgit2/build/amd \
           ./hack/static.sh all
-          
+
           TARGET_DIR=${GITHUB_WORKSPACE}/build/libgit2-darwin-arm64 \
           BUILD_ROOT_DIR=${GITHUB_WORKSPACE}/libgit2/build/arm \
           TARGET_ARCH=arm64 \
           CMAKE_APPLE_SILICON_PROCESSOR=arm64 \
           ./hack/static.sh all
 
 
-          LIBGIT2_SED="s;-L/Applications/Xcode_.* ;;g"
+          LIBGIT2_SED="s;-L/Applications/Xcode.* ;;g"
           LIBGIT2PC="${GITHUB_WORKSPACE}/build/darwin-all-libs/lib/pkgconfig/libgit2.pc"          
 
-          # pkgconfig files may contain absolute paths to its dependencies that is specific
-          # to the runner - machine used to compile the library. 
-          # We need to remove the absolute path of iconv, so when the library is consumed
-          # pkgconfig will automatically try to find it through the default search paths
-          # on the target machine.
+          # pkgconfig includes absolute paths that are specific to the runner machine. 
+          # We need to remove the absolute path for iconv, so when the libgit2 library
+          # is consumed pkgconfig will automatically try to find it through the default
+          # search paths on the target machine.
           if command -v gsed &> /dev/null; then 
               gsed -i "${LIBGIT2_SED}" "${LIBGIT2PC}"
           else
@@ -147,7 +144,7 @@ jobs:
       - uses: actions/upload-artifact@v3
         with:
           name: release-artifact
-          path: '*.tar.gz'
+          path: "*.tar.gz"
           if-no-files-found: error
 
   # similar to darwin-all-libs, but only compiles libgit2.
@@ -168,6 +165,19 @@ jobs:
           CMAKE_APPLE_SILICON_PROCESSOR=arm64 \
           ./hack/static.sh build_libgit2_only
 
+          LIBGIT2_SED="s;-L/Applications/Xcode.* ;;g"
+          LIBGIT2PC="${GITHUB_WORKSPACE}/build/libgit2-darwin-amd64/lib/pkgconfig/libgit2.pc"          
+
+          # pkgconfig includes absolute paths that are specific to the runner machine. 
+          # We need to remove the absolute path for iconv, so when the libgit2 library
+          # is consumed pkgconfig will automatically try to find it through the default
+          # search paths on the target machine.
+          if command -v gsed &> /dev/null; then 
+              gsed -i "${LIBGIT2_SED}" "${LIBGIT2PC}"
+          else
+              sed -i "" "${LIBGIT2_SED}" "${LIBGIT2PC}"
+          fi
+
           mkdir -p ./darwin-libgit2-only/lib
           mv ${GITHUB_WORKSPACE}/build/libgit2-darwin-amd64/include ./darwin-libgit2-only/
 
@@ -182,13 +192,19 @@ jobs:
       - uses: actions/upload-artifact@v3
         with:
           name: release-artifact
-          path: '*.tar.gz'
+          path: "*.tar.gz"
           if-no-files-found: error
 
   goreleaser:
     runs-on: ubuntu-latest
-    needs: [linux-x86_64-all-libs, linux-x86_64-libgit2-only, darwin-all-libs, darwin-libgit2-only]
-    if:  ${{ always() && contains(join(needs.*.result, ','), 'success') }}
+    needs:
+      [
+        linux-x86_64-all-libs,
+        linux-x86_64-libgit2-only,
+        darwin-all-libs,
+        darwin-libgit2-only,
+      ]
+    if: ${{ always() && contains(join(needs.*.result, ','), 'success') }}
     steps:
       - uses: actions/checkout@v3
         with:

.github/workflows/test.yaml

@@ -0,0 +1,45 @@
+---
+name: "Test"
+on:
+  push:
+    branches:
+      - main
+    paths-ignore:
+      - README.md
+  pull_request:
+    paths-ignore:
+      - README.md
+
+permissions: {}
+
+jobs:
+  darwin-dev-test:
+    strategy:
+      matrix:
+        libgit_only: [true, false]
+    runs-on: macos-11
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Test build script for darwin-amd64
+        run: |
+          rm -rf ${GITHUB_WORKSPACE}/build
+          make dev-test
+        env:
+          LIBGIT2_ONLY: ${{ matrix.libgit_only }}
+          MACOSX_DEPLOYMENT_TARGET: 10.15
+
+  linux-dev-test:
+    strategy:
+      matrix:
+        libgit_only: [true, false]
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Test build script for linux-amd64
+        run: |
+          rm -rf ${GITHUB_WORKSPACE}/build
+          make dev-test
+        env:
+          LIBGIT2_ONLY: ${{ matrix.libgit_only }}