You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<!-- start_original_pr_link -->
Reverts: flutter#177333
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: reidbaker
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Possibly broke the tree see
flutter#177465
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: reidbaker
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Updated the pull request template to include a changelog description
section and improved clarity on impact description.
This came up after multiple release engineering rotations where I needed
to ask full time maintinainters to rewrite their changelogs entries.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
Copy file name to clipboardExpand all lines: .github/PR_TEMPLATE/PULL_REQUEST_CP_TEMPLATE.md
+7-15Lines changed: 7 additions & 15 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -4,25 +4,17 @@ Please fill in the form below, and a flutter domain expert will evaluate this ch
4
4
### Issue Link:
5
5
What is the link to the issue this cherry-pick is addressing?
6
6
7
-
https://github.com/flutter/flutter/issues/< Replace with issue link here >
8
-
9
-
### Impact Description:
10
-
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
11
-
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
12
-
or the shipping of production apps (the app crashes on launch).
13
-
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
14
-
15
-
< Replace with impact description here >
7
+
< Replace with issue link here >
16
8
17
9
### Changelog Description:
18
-
Explain this cherry pick:
19
-
* In one line that is accessible to most Flutter developers.
20
-
* That describes the state prior to the fix.
21
-
* That includes which platforms are impacted.
22
-
See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.
10
+
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples
23
11
24
12
< Replace with changelog description here >
25
-
[flutter/<ISSUE_NUMBER>] When <SCENARIO> [on <PLAFORMS(S)>], <DESCRIPTION>
13
+
14
+
### Impact Description:
15
+
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
0 commit comments