Skip to content

Commit 41a3ec2

Browse files
[webview_flutter_android] Fix race condition in flaky test (#5037)
The test was retrieving the current url directly after calling `loadUrl`. This seems to have a good chance to fail since loading a url isn't instantaneous. This changes the test to wait for the url to change.
1 parent cb6c5ec commit 41a3ec2

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

packages/webview_flutter/webview_flutter_android/example/integration_test/legacy/webview_flutter_test.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,9 @@ Future<void> main() async {
248248
'test_header': 'flutter_test_header'
249249
};
250250
await controller.loadUrl(headersUrl, headers: headers);
251-
final String? currentUrl = await controller.currentUrl();
252-
expect(currentUrl, headersUrl);
253251

254-
await pageStarts.stream.firstWhere((String url) => url == currentUrl);
255-
await pageLoads.stream.firstWhere((String url) => url == currentUrl);
252+
await pageStarts.stream.firstWhere((String url) => url == headersUrl);
253+
await pageLoads.stream.firstWhere((String url) => url == headersUrl);
256254

257255
final String content = await controller
258256
.runJavascriptReturningResult('document.documentElement.innerText');

0 commit comments

Comments
 (0)