Skip to content

Commit 3ff8455

Browse files
[flutter_svg] Fixes typo of allowDrawingOutsideViewBox in doc comments. (#10256)
All the doc comments referred to the `allowDrawingOutsideOfViewBox` parameter. However, there is no `allowDrawingOutsideOfViewBox` parameter. The parameter is called `allowDrawingOutsideViewBox` (without a "Of"). This PR fixes this issue. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent e186c0a commit 3ff8455

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

third_party/packages/flutter_svg/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.2.2
2+
3+
* Fixes typo of `allowDrawingOutsideViewBox` in doc comments.
4+
15
## 2.2.1
26

37
* Fixes message buffer access in SvgAssetLoader.

third_party/packages/flutter_svg/lib/svg.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class SvgPicture extends StatelessWidget {
6565
/// If `matchTextDirection` is set to true, the picture will be flipped
6666
/// horizontally in [TextDirection.rtl] contexts.
6767
///
68-
/// The `allowDrawingOutsideOfViewBox` parameter should be used with caution -
68+
/// The `allowDrawingOutsideViewBox` parameter should be used with caution -
6969
/// if set to true, it will not clip the canvas used internally to the view box,
7070
/// meaning the picture may draw beyond the intended area and lead to undefined
7171
/// behavior or additional memory overhead.
@@ -116,7 +116,7 @@ class SvgPicture extends StatelessWidget {
116116
/// If `matchTextDirection` is set to true, the picture will be flipped
117117
/// horizontally in [TextDirection.rtl] contexts.
118118
///
119-
/// The `allowDrawingOutsideOfViewBox` parameter should be used with caution -
119+
/// The `allowDrawingOutsideViewBox` parameter should be used with caution -
120120
/// if set to true, it will not clip the canvas used internally to the view box,
121121
/// meaning the picture may draw beyond the intended area and lead to undefined
122122
/// behavior or additional memory overhead.
@@ -222,7 +222,7 @@ class SvgPicture extends StatelessWidget {
222222
/// If `matchTextDirection` is set to true, the picture will be flipped
223223
/// horizontally in [TextDirection.rtl] contexts.
224224
///
225-
/// The `allowDrawingOutsideOfViewBox` parameter should be used with caution -
225+
/// The `allowDrawingOutsideViewBox` parameter should be used with caution -
226226
/// if set to true, it will not clip the canvas used internally to the view box,
227227
/// meaning the picture may draw beyond the intended area and lead to undefined
228228
/// behavior or additional memory overhead.
@@ -287,7 +287,7 @@ class SvgPicture extends StatelessWidget {
287287
/// If `matchTextDirection` is set to true, the picture will be flipped
288288
/// horizontally in [TextDirection.rtl] contexts.
289289
///
290-
/// The `allowDrawingOutsideOfViewBox` parameter should be used with caution -
290+
/// The `allowDrawingOutsideViewBox` parameter should be used with caution -
291291
/// if set to true, it will not clip the canvas used internally to the view box,
292292
/// meaning the picture may draw beyond the intended area and lead to undefined
293293
/// behavior or additional memory overhead.
@@ -346,7 +346,7 @@ class SvgPicture extends StatelessWidget {
346346
/// If `matchTextDirection` is set to true, the picture will be flipped
347347
/// horizontally in [TextDirection.rtl] contexts.
348348
///
349-
/// The `allowDrawingOutsideOfViewBox` parameter should be used with caution -
349+
/// The `allowDrawingOutsideViewBox` parameter should be used with caution -
350350
/// if set to true, it will not clip the canvas used internally to the view box,
351351
/// meaning the picture may draw beyond the intended area and lead to undefined
352352
/// behavior or additional memory overhead.
@@ -402,7 +402,7 @@ class SvgPicture extends StatelessWidget {
402402
/// If `matchTextDirection` is set to true, the picture will be flipped
403403
/// horizontally in [TextDirection.rtl] contexts.
404404
///
405-
/// The `allowDrawingOutsideOfViewBox` parameter should be used with caution -
405+
/// The `allowDrawingOutsideViewBox` parameter should be used with caution -
406406
/// if set to true, it will not clip the canvas used internally to the view box,
407407
/// meaning the picture may draw beyond the intended area and lead to undefined
408408
/// behavior or additional memory overhead.

third_party/packages/flutter_svg/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: flutter_svg
22
description: An SVG rendering and widget library for Flutter, which allows painting and displaying Scalable Vector Graphics 1.1 files.
33
repository: https://github.com/flutter/packages/tree/main/third_party/packages/flutter_svg
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_svg%22
5-
version: 2.2.1
5+
version: 2.2.2
66

77
environment:
88
sdk: ^3.7.0

0 commit comments

Comments
 (0)