Refactor/local ads management structure enhancement and UI overhaul #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility - Change the title text from "enableInArticleAdsForRoleLabel" to "visibleToRoleLabel" - This update improves clarity in the article ad settings form
- Change horizontal margin from medium to small in headlines_page.dart - Change column spacing and horizontal margin from medium to small in sources_page.dart and topics_page.dart - Remove source type column in sources_page.dart when on mobile view - Adjust spacing in various data table configurations
- Added Arabic translations for new strings related to AdMob filtering and loading states - Translated terms for different ad types (native, banner, interstitial, video) - Included translations for search functionality and column headers
- Remove AdType from LoadLocalAdsRequested, ArchiveLocalAdRequested, and RestoreLocalAdRequested events - Add filter option to LoadLocalAdsRequested event - Implement DeletionEventReceived event for handling deletion events from PendingDeletionsService - Update props list for affected events - Remove UndoDeleteLocalAdRequested event
…barMessage - Remove lastDeletedLocalAd property from LocalAdsManagementState - Add snackbarMessage property for displaying transient messages - Update copyWith method to accommodate the new snackbarMessage property - Adjust props list to include snackbarMessage instead of lastDeletedLocalAd
- Implement undoable deletions using PendingDeletionsService - Add real-time filtering functionality - Enhance UI/UX with snackbar messages for actions - Optimize code structure and improve readability
- Add FilterLocalAdsBloc to manage the state of local ads filter UI - Implement event handlers for search query, status, and ad type changes - Add logic to apply and reset filters - Include a debounce transformer for search input
- Add FilterLocalAdsEvent base class - Implement individual events for search query change, status change, ad type change, applying filters, and resetting filters - Ensure proper Equatable implementation for each event
- Define FilterLocalAdsStatus enum to represent operation states - Implement FilterLocalAdsState class with properties for status, exception, search query, selected status, and selected ad type - Include copyWith method for state immutability - Add Equatable props for state comparison
- Implement BannerAdsPage for displaying and managing banner ads - Add functionality to load, filter, and paginate banner ads - Include options to copy ad ID, edit, and archive ads - Handle loading, empty, and error states
- Implement InterstitialAdsPage for displaying and managing interstitial ads - Add pagination, filtering, and sorting functionality - Include actions for copying ad ID, editing, and archiving ads - Handle loading, empty, and error states - Update UI components for better usability and responsiveness
- Replace monolithic LocalAdsManagementPage with individual pages for each ad type - Add FilterLocalAdsBloc for handling ad filters - Implement snackbar undo functionality for deleted ads - Update UI to use separate pages for Native, Banner, Interstitial, and Video ads
- Add NativeAdsPage widget for displaying and managing native ads - Implement pagination and filtering functionality - Include actions for copying ad ID, editing, and archiving ads - Handle loading, empty, and error states - Use BlocBuilder for state management - Add localization support
- Implement VideoAdsPage for displaying and managing video ads - Add functionality to load, filter, and paginate video ads - Include options to copy ad ID, edit, and archive ads - Handle loading, error, and empty states
- Implement LocalAdsFilterDialog widget for applying filters to local ads lists - Add BlocBuilder for LocalAdsFilterDialogBloc to manage filter states - Include search functionality and filter chips for content status and ad type - Implement reset and apply filters actions
- Add new BLoC to manage state and logic for LocalAdsFilterDialog - Implement event handlers for filter initialization, search query change, status change, ad type change, and reset - Use debounce transformer for search query changes - Update state based on current filter selections
- Define sealed class LocalAdsFilterDialogEvent - Add LocalAdsFilterDialogInitialized event for filter dialog initialization - Implement LocalAdsFilterDialogSearchQueryChanged for updating search query - Create LocalAdsFilterDialogStatusChanged for changing content status - Add LocalAdsFilterDialogAdTypeChanged event for selecting ad type - Include LocalAdsFilterDialogReset to reset filter selections
- Define LocalAdsFilterDialogStatus enum for dialog operation states - Implement LocalAdsFilterDialogState class with properties for status, exception, search query, selected status, and selected ad type - Include copyWith method for creating updated state instances - Add Equatable implementation for state comparison
- Import FilterLocalAdsBloc from local_ads_management/bloc - Add BlocProvider for FilterLocalAdsBloc in the app's provider list
- Replace archived local ads page route with a more generic local ads filter dialog route - Update import statements to include new bloc and dialog classes - Add new route for local ads filter dialog with page builder - Update routes.dart to reflect changes in route names and paths
… or restore - Add LoadLocalAdsRequested event after successfully archiving or restoring local ads - This ensures the UI is updated immediately to reflect the changed status of the ads - Helps users see the results of their actions more quickly and improves overall user experience
- Remove direct implementation of action buttons in banner ads page - Replace with LocalAdActionButtons widget import and usage - Simplify code and improve maintainability by using a dedicated widget
- Replace inline ad action buttons with LocalAdActionButtons widget - Remove unnecessary imports - Add comments for clarity - Minor code formatting and cleanup
- Add local_ad_action_buttons widget for ad item actions - Implement filter logic specific to native ads - Display no results message and reset filters button when no ads found - Remove unused imports and update routes
- Replace ad action buttons with LocalAdActionButtons widget - Remove unused imports - Simplify code structure - Improve readability and maintainability
- Implement LocalAdActionButtons widget for displaying action buttons related to local ad items. - The widget supports different local ad types (Native, Banner, Interstitial, Video) and their statuses. - Features include editing ads and performing status transitions (publish, archive, restore, delete). - Utilizes GoRouter for navigation to edit screens. - Follows the design pattern of ContentActionButtons for content management items.
- Removed `filterLocalAdsBloc` parameter from `LocalAdsFilterDialogBloc` constructor - Deleted `_filterLocalAdsBloc` class member variable - Updated constructor to use simple syntax
- Remove explicit constructor parameters for LocalAdsFilterDialogBloc - Keep using default constructor and chaining init method call
- Add import for LocalAdsManagementBloc - Implement LocalAdsManagementBloc in App widget - Provide necessary dependencies for LocalAdsManagementBloc
- Remove unnecessary selectedAdType parameter from FilterLocalAdsState - Add currentAdType parameter to buildLocalAdsFilterMap method - Update adType parameter in LoadLocalAdsRequested event - Adjust _areFiltersActive method to remove selectedAdType check
- Add "Copy ID" option to the overflow menu for active ads - Implement functionality to copy ad ID to clipboard - Display snackbar confirmation after copying ID
…dialog - Remove ad type filter functionality from LocalAdsFilterDialog - Delete ad type filter chips and related logic - Update dialog documentation to reflect removal of ad type filter - Adjust layout by removing spacing and section related to ad type filter
- Remove LocalAdsFilterDialogAdTypeChanged event handler - Remove selectedAdType property from LocalAdsFilterDialogState - Remove ad type related code from the bloc
…rstitial ads - Add CreateLocalInterstitialAdSavedAsDraft event for saving ads as drafts - Add CreateLocalInterstitialAdPublished event for publishing ads - Remove unnecessary CreateLocalInterstitialAdSubmitted event
…ialAdState - Add ContentStatus enum to track ad status (draft or active) - Update CreateLocalInterstitialAdState constructor and copyWith method - Include contentStatus in the list of properties for Equatable
…cal interstitial ads - Remove _onSubmitted handler - Add _onSavedAsDraft handler for saving ad as a draft - Add _onPublished handler for publishing ad - Update event names in CreateLocalInterstitialAdBloc class
…g video ad - Introduce CreateLocalVideoAdSavedAsDraft event for saving video ad as draft - Introduce CreateLocalVideoAdPublished event for publishing video ad - Remove unnecessary CreateLocalVideoAdSubmitted event
…tate - Add ContentStatus enum to track draft or active state of the ad - Include contentStatus in CreateLocalVideoAdState properties - Update copyWith method to support contentStatus - Set default contentStatus to ContentStatus.draft in constructor
…cal video ads - Replace CreateLocalVideoAdSubmitted event with CreateLocalVideoAdSavedAsDraft and CreateLocalVideoAdPublished events - Implement _onSavedAsDraft method to handle saving local video ads as drafts - Implement _onPublished method to handle publishing local video ads - Update event handlers to set appropriate statuses and handle exceptions
…l banner ads - Introduce CreateLocalBannerAdSavedAsDraft event for saving ads as drafts - Introduce CreateLocalBannerAdPublished event for publishing ads - Remove unnecessary CreateLocalBannerAdSubmitted event
…tate - Add ContentStatus enum to track draft or active state of the ad - Include contentStatus in CreateLocalBannerAdState properties - Update copyWith method to support contentStatus - Set default contentStatus to ContentStatus.draft in constructor
…ionalities - Add CreateLocalBannerAdSavedAsDraft and CreateLocalBannerAdPublished events - Implement _onSavedAsDraft and _onPublished event handlers - Update CreateLocalBannerAdStatus to include draft and published states - Modify CreateLocalBannerAdBloc to handle new events
…g native ad - Introduce CreateLocalNativeAdSavedAsDraft event for saving native ad as a draft - Add CreateLocalNativeAdPublished event for publishing native ad - Remove unnecessary CreateLocalNativeAdSubmitted event
…state - Add ContentStatus enum to track draft or active state of the ad - Update CreateLocalNativeAdState with contentStatus field and default value - Modify copyWith method to include contentStatus parameter - Update props list to include contentStatus for equality checks
…ionalities - Replace CreateLocalNativeAdSubmitted event handler with two new handlers - Add CreateLocalNativeAdSavedAsDraft event handler - Add CreateLocalNativeAdPublished event handler - Implement logic to save local native ad as a draft - Implement logic to publish local native ad - Update state management for both saving as draft and publishing actions
- Implement a dialog to choose between publishing or saving as draft - Update save button functionality to use the new dialog - Add new events to CreateLocalBannerAdBloc for publishing and saving as draft
…ft or publish - Implement a dialog to let users choose between saving as a draft or publishing the ad - Update save button functionality to handle both draft and publish actions - Add new events to CreateLocalInterstitialAdBloc for handling draft and publish actions
- Implement dialog for choosing between publishing or saving as draft - Update save button functionality to handle both options - Add new events to CreateLocalNativeAdBloc for publishing and saving as draft
- Implement a dialog to choose between publishing or saving as draft - Update save button functionality to handle both options - Add new events to CreateLocalVideoAdBloc for publishing and saving as draft
- Add Arabic translations for saveAdTitle and saveAdMessage in app_ar.arb - Add English translations for saveAdTitle and saveAdMessage in app_en.arb
- Change ArchiveLocalAdRequested to RestoreLocalAdRequested when clicking - Ensure correct action is performed when user clicks on the restore button
- Import shared resources for AboutIcon usage - Add AboutIcon to AppBar title row - Set tooltip and description for AboutIcon using localization strings
- Set the icon color to primary in both leadingUnextendedNavRail and leadingExtendedNavRail - Remove unnecessary text color override in leadingExtendedNavRail
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant refactor and enhancement to the local ads management structure and user interface. The changes aim to provide a more intuitive and efficient experience for managing various ad types, streamline the ad creation and deletion processes, and improve overall UI responsiveness and clarity. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-executed refactoring of the local ads management feature. The consolidation of state management into a single LocalAdsManagementBloc, the removal of the separate Archive BLoC and page, and the introduction of a dedicated FilterLocalAdsBloc with a corresponding filter dialog are excellent improvements that enhance the structure and maintainability of the feature. The UI has also been nicely overhauled to use a TabBarView with separate pages for each ad type, which is a cleaner approach.
My feedback focuses on a few key areas to further improve the code quality:
- Refactoring duplicated logic in the
CreateLocal...AdBlocfiles to improve maintainability. - Enhancing the robustness of the deletion snackbar logic by decoupling the BLoC from UI-specific string formatting.
- Ensuring consistency in localization files.
fulleni
deleted the
refactor/local-ads-management-structure-enhancement-and-ui-overhaul
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This pull request introduces a significant refactor and enhancement to the local ads management structure and user interface. The changes aim to provide a more intuitive and efficient experience for managing various ad types, streamline the ad creation and deletion processes, and improve overall UI responsiveness and clarity.
Type of Change