From 835cf8ce56083a528ef4d75fe63d5e908d86db8e Mon Sep 17 00:00:00 2001 From: fulleni Date: Mon, 14 Jul 2025 15:36:27 +0100 Subject: [PATCH 1/3] refactor(dashboard): Use constants for IDs - Replaced hardcoded IDs with constants. - Improved code readability and maintainability. - Reduced risk of ID mismatch errors. - Updated `dashboard_bloc.dart` file. - Used `kDashboardSummaryId` and `kRemoteConfigId`. --- lib/dashboard/bloc/dashboard_bloc.dart | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/dashboard/bloc/dashboard_bloc.dart b/lib/dashboard/bloc/dashboard_bloc.dart index 1857da4f..bb7f5ead 100644 --- a/lib/dashboard/bloc/dashboard_bloc.dart +++ b/lib/dashboard/bloc/dashboard_bloc.dart @@ -2,6 +2,7 @@ import 'package:bloc/bloc.dart'; import 'package:equatable/equatable.dart'; import 'package:ht_data_repository/ht_data_repository.dart'; import 'package:ht_shared/ht_shared.dart'; +import 'package:ht_shared/src/constants/fixture_ids.dart'; part 'dashboard_event.dart'; part 'dashboard_state.dart'; @@ -36,8 +37,8 @@ class DashboardBloc extends Bloc { appConfigResponse, recentHeadlinesResponse, ] = await Future.wait([ - _dashboardSummaryRepository.read(id: 'dashboard_summary'), - _appConfigRepository.read(id: 'app_config'), + _dashboardSummaryRepository.read(id: kDashboardSummaryId), + _appConfigRepository.read(id: kRemoteConfigId), _headlinesRepository.readAll( pagination: const PaginationOptions(limit: 5), sort: const [SortOption('createdAt', SortOrder.desc)], From a9f4cf7aa20d638aa7ed92489957a3ffb8e5658d Mon Sep 17 00:00:00 2001 From: fulleni Date: Mon, 14 Jul 2025 15:36:45 +0100 Subject: [PATCH 2/3] refactor(app_config): Use constant for remote config ID - Replaced hardcoded ID with constant. - Improved code readability and maintainability. - Reduced risk of future inconsistencies. --- lib/app_configuration/bloc/app_configuration_bloc.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/app_configuration/bloc/app_configuration_bloc.dart b/lib/app_configuration/bloc/app_configuration_bloc.dart index f410315e..9f713eae 100644 --- a/lib/app_configuration/bloc/app_configuration_bloc.dart +++ b/lib/app_configuration/bloc/app_configuration_bloc.dart @@ -2,6 +2,7 @@ import 'package:bloc/bloc.dart'; import 'package:equatable/equatable.dart'; import 'package:ht_data_repository/ht_data_repository.dart'; import 'package:ht_shared/ht_shared.dart'; // Use RemoteConfig from ht_shared +import 'package:ht_shared/src/constants/fixture_ids.dart'; part 'app_configuration_event.dart'; part 'app_configuration_state.dart'; @@ -28,7 +29,7 @@ class AppConfigurationBloc ) async { emit(state.copyWith(status: AppConfigurationStatus.loading)); try { - final remoteConfig = await _remoteConfigRepository.read(id: 'app_config'); + final remoteConfig = await _remoteConfigRepository.read(id: kRemoteConfigId); emit( state.copyWith( status: AppConfigurationStatus.success, From 8a438a000dbad82d2cba495d418cbfefdc7bff2c Mon Sep 17 00:00:00 2001 From: fulleni Date: Mon, 14 Jul 2025 15:59:53 +0100 Subject: [PATCH 3/3] refactor: remove unused imports - Removed `fixture_ids.dart` import. - Improved code cleanliness. --- lib/app_configuration/bloc/app_configuration_bloc.dart | 3 +-- lib/dashboard/bloc/dashboard_bloc.dart | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/app_configuration/bloc/app_configuration_bloc.dart b/lib/app_configuration/bloc/app_configuration_bloc.dart index 9f713eae..08b26a47 100644 --- a/lib/app_configuration/bloc/app_configuration_bloc.dart +++ b/lib/app_configuration/bloc/app_configuration_bloc.dart @@ -1,8 +1,7 @@ import 'package:bloc/bloc.dart'; import 'package:equatable/equatable.dart'; import 'package:ht_data_repository/ht_data_repository.dart'; -import 'package:ht_shared/ht_shared.dart'; // Use RemoteConfig from ht_shared -import 'package:ht_shared/src/constants/fixture_ids.dart'; +import 'package:ht_shared/ht_shared.dart'; part 'app_configuration_event.dart'; part 'app_configuration_state.dart'; diff --git a/lib/dashboard/bloc/dashboard_bloc.dart b/lib/dashboard/bloc/dashboard_bloc.dart index bb7f5ead..82444193 100644 --- a/lib/dashboard/bloc/dashboard_bloc.dart +++ b/lib/dashboard/bloc/dashboard_bloc.dart @@ -1,8 +1,7 @@ import 'package:bloc/bloc.dart'; import 'package:equatable/equatable.dart'; import 'package:ht_data_repository/ht_data_repository.dart'; -import 'package:ht_shared/ht_shared.dart'; -import 'package:ht_shared/src/constants/fixture_ids.dart'; +import 'package:ht_shared/ht_shared.dart'; part 'dashboard_event.dart'; part 'dashboard_state.dart';