lint: misc

Author: fulleni

lib/app/view/app.dart

@@ -37,26 +37,26 @@ class App extends StatelessWidget {
     required KVStorageService storageService,
     required AppEnvironment environment,
     super.key,
-  })  : _authenticationRepository = authenticationRepository,
-        _headlinesRepository = headlinesRepository,
-        _topicsRepository = topicsRepository,
-        _sourcesRepository = sourcesRepository,
-        _userAppSettingsRepository = userAppSettingsRepository,
-        _userContentPreferencesRepository = userContentPreferencesRepository,
-        _remoteConfigRepository = remoteConfigRepository,
-        _kvStorageService = storageService,
-        _dashboardSummaryRepository = dashboardSummaryRepository,
-        _countriesRepository = countriesRepository,
-        _languagesRepository = languagesRepository,
-        _environment = environment;
+  }) : _authenticationRepository = authenticationRepository,
+       _headlinesRepository = headlinesRepository,
+       _topicsRepository = topicsRepository,
+       _sourcesRepository = sourcesRepository,
+       _userAppSettingsRepository = userAppSettingsRepository,
+       _userContentPreferencesRepository = userContentPreferencesRepository,
+       _remoteConfigRepository = remoteConfigRepository,
+       _kvStorageService = storageService,
+       _dashboardSummaryRepository = dashboardSummaryRepository,
+       _countriesRepository = countriesRepository,
+       _languagesRepository = languagesRepository,
+       _environment = environment;
 
   final AuthRepository _authenticationRepository;
   final DataRepository<Headline> _headlinesRepository;
   final DataRepository<Topic> _topicsRepository;
   final DataRepository<Source> _sourcesRepository;
   final DataRepository<UserAppSettings> _userAppSettingsRepository;
   final DataRepository<UserContentPreferences>
-      _userContentPreferencesRepository;
+  _userContentPreferencesRepository;
   final DataRepository<RemoteConfig> _remoteConfigRepository;
   final DataRepository<DashboardSummary> _dashboardSummaryRepository;
   final DataRepository<Country> _countriesRepository;

lib/authentication/bloc/authentication_state.dart

@@ -72,8 +72,9 @@ final class AuthenticationState extends Equatable {
       user: user ?? this.user,
       email: email ?? this.email,
       exception: exception ?? this.exception,
-      cooldownEndTime:
-          clearCooldownEndTime ? null : cooldownEndTime ?? this.cooldownEndTime,
+      cooldownEndTime: clearCooldownEndTime
+          ? null
+          : cooldownEndTime ?? this.cooldownEndTime,
     );
   }
 }

lib/authentication/view/request_code_page.dart

@@ -232,10 +232,10 @@ class _EmailLinkFormState extends State<_EmailLinkForm> {
   void _submitForm() {
     if (_formKey.currentState!.validate()) {
       context.read<AuthenticationBloc>().add(
-            AuthenticationRequestSignInCodeRequested(
-              email: _emailController.text.trim(),
-            ),
-          );
+        AuthenticationRequestSignInCodeRequested(
+          email: _emailController.text.trim(),
+        ),
+      );
     }
   }
 
@@ -276,13 +276,15 @@ class _EmailLinkFormState extends State<_EmailLinkForm> {
                 }
                 return null;
               },
-              onFieldSubmitted:
-                  widget.isLoading || _cooldownSeconds > 0 ? null : (_) => _submitForm(),
+              onFieldSubmitted: widget.isLoading || _cooldownSeconds > 0
+                  ? null
+                  : (_) => _submitForm(),
             ),
             const SizedBox(height: AppSpacing.lg),
             ElevatedButton(
-              onPressed:
-                  widget.isLoading || _cooldownSeconds > 0 ? null : _submitForm,
+              onPressed: widget.isLoading || _cooldownSeconds > 0
+                  ? null
+                  : _submitForm,
               style: ElevatedButton.styleFrom(
                 padding: const EdgeInsets.symmetric(vertical: AppSpacing.md),
                 textStyle: textTheme.labelLarge,
@@ -297,12 +299,12 @@ class _EmailLinkFormState extends State<_EmailLinkForm> {
                       ),
                     )
                   : _cooldownSeconds > 0
-                      ? Text(
-                          l10n.requestCodeResendButtonCooldown(
-                            _cooldownSeconds,
-                          ),
-                        )
-                      : Text(l10n.requestCodeSendCodeButton),
+                  ? Text(
+                      l10n.requestCodeResendButtonCooldown(
+                        _cooldownSeconds,
+                      ),
+                    )
+                  : Text(l10n.requestCodeSendCodeButton),
             ),
           ],
         ),

lib/bootstrap.dart

@@ -264,10 +264,12 @@ Future<Widget> bootstrap(
   final dashboardSummaryRepository = DataRepository<DashboardSummary>(
     dataClient: dashboardSummaryClient,
   );
-  final countriesRepository =
-      DataRepository<Country>(dataClient: countriesClient);
-  final languagesRepository =
-      DataRepository<Language>(dataClient: languagesClient);
+  final countriesRepository = DataRepository<Country>(
+    dataClient: countriesClient,
+  );
+  final languagesRepository = DataRepository<Language>(
+    dataClient: languagesClient,
+  );
 
   return App(
     authenticationRepository: authenticationRepository,

lib/content_management/bloc/create_headline/create_headline_bloc.dart

@@ -1,5 +1,4 @@
 import 'package:bloc/bloc.dart';
-import 'package:bloc_concurrency/bloc_concurrency.dart';
 import 'package:core/core.dart';
 import 'package:data_repository/data_repository.dart';
 import 'package:equatable/equatable.dart';
@@ -13,8 +12,6 @@ final class _FetchNextCountryPage extends CreateHeadlineEvent {
   const _FetchNextCountryPage();
 }
 
-const _searchDebounceDuration = Duration(milliseconds: 300);
-
 /// A BLoC to manage the state of creating a new headline.
 class CreateHeadlineBloc
     extends Bloc<CreateHeadlineEvent, CreateHeadlineState> {
@@ -24,11 +21,11 @@ class CreateHeadlineBloc
     required DataRepository<Source> sourcesRepository,
     required DataRepository<Topic> topicsRepository,
     required DataRepository<Country> countriesRepository,
-  })  : _headlinesRepository = headlinesRepository,
-        _sourcesRepository = sourcesRepository,
-        _topicsRepository = topicsRepository,
-        _countriesRepository = countriesRepository,
-        super(const CreateHeadlineState()) {
+  }) : _headlinesRepository = headlinesRepository,
+       _sourcesRepository = sourcesRepository,
+       _topicsRepository = topicsRepository,
+       _countriesRepository = countriesRepository,
+       super(const CreateHeadlineState()) {
     on<CreateHeadlineDataLoaded>(_onDataLoaded);
     on<CreateHeadlineTitleChanged>(_onTitleChanged);
     on<CreateHeadlineExcerptChanged>(_onExcerptChanged);
@@ -177,6 +174,7 @@ class CreateHeadlineBloc
     try {
       emit(state.copyWith(countriesIsLoadingMore: true));
 
+      // ignore: inference_failure_on_instance_creation
       await Future.delayed(const Duration(milliseconds: 400));
 
       final nextCountries = await _countriesRepository.readAll(

lib/content_management/bloc/create_source/create_source_bloc.dart

@@ -1,5 +1,4 @@
 import 'package:bloc/bloc.dart';
-import 'package:bloc_concurrency/bloc_concurrency.dart';
 import 'package:core/core.dart';
 import 'package:data_repository/data_repository.dart';
 import 'package:equatable/equatable.dart';
@@ -17,19 +16,17 @@ final class _FetchNextLanguagePage extends CreateSourceEvent {
   const _FetchNextLanguagePage();
 }
 
-const _searchDebounceDuration = Duration(milliseconds: 300);
-
 /// A BLoC to manage the state of creating a new source.
 class CreateSourceBloc extends Bloc<CreateSourceEvent, CreateSourceState> {
   /// {@macro create_source_bloc}
   CreateSourceBloc({
     required DataRepository<Source> sourcesRepository,
     required DataRepository<Country> countriesRepository,
     required DataRepository<Language> languagesRepository,
-  })  : _sourcesRepository = sourcesRepository,
-        _countriesRepository = countriesRepository,
-        _languagesRepository = languagesRepository,
-        super(const CreateSourceState()) {
+  }) : _sourcesRepository = sourcesRepository,
+       _countriesRepository = countriesRepository,
+       _languagesRepository = languagesRepository,
+       super(const CreateSourceState()) {
     on<CreateSourceDataLoaded>(_onDataLoaded);
     on<CreateSourceNameChanged>(_onNameChanged);
     on<CreateSourceDescriptionChanged>(_onDescriptionChanged);
@@ -168,6 +165,7 @@ class CreateSourceBloc extends Bloc<CreateSourceEvent, CreateSourceState> {
     try {
       emit(state.copyWith(countriesIsLoadingMore: true));
 
+      // ignore: inference_failure_on_instance_creation
       await Future.delayed(const Duration(milliseconds: 400));
 
       final nextCountries = await _countriesRepository.readAll(
@@ -202,6 +200,7 @@ class CreateSourceBloc extends Bloc<CreateSourceEvent, CreateSourceState> {
     try {
       emit(state.copyWith(languagesIsLoadingMore: true));
 
+      // ignore: inference_failure_on_instance_creation
       await Future.delayed(const Duration(milliseconds: 400));
 
       final nextLanguages = await _languagesRepository.readAll(

lib/content_management/bloc/edit_headline/edit_headline_bloc.dart

@@ -1,5 +1,4 @@
 import 'package:bloc/bloc.dart';
-import 'package:bloc_concurrency/bloc_concurrency.dart';
 import 'package:core/core.dart';
 import 'package:data_repository/data_repository.dart';
 import 'package:equatable/equatable.dart';
@@ -12,8 +11,6 @@ final class _FetchNextCountryPage extends EditHeadlineEvent {
   const _FetchNextCountryPage();
 }
 
-const _searchDebounceDuration = Duration(milliseconds: 300);
-
 /// A BLoC to manage the state of editing a single headline.
 class EditHeadlineBloc extends Bloc<EditHeadlineEvent, EditHeadlineState> {
   /// {@macro edit_headline_bloc}
@@ -23,12 +20,12 @@ class EditHeadlineBloc extends Bloc<EditHeadlineEvent, EditHeadlineState> {
     required DataRepository<Topic> topicsRepository,
     required DataRepository<Country> countriesRepository,
     required String headlineId,
-  })  : _headlinesRepository = headlinesRepository,
-        _sourcesRepository = sourcesRepository,
-        _topicsRepository = topicsRepository,
-        _countriesRepository = countriesRepository,
-        _headlineId = headlineId,
-        super(const EditHeadlineState()) {
+  }) : _headlinesRepository = headlinesRepository,
+       _sourcesRepository = sourcesRepository,
+       _topicsRepository = topicsRepository,
+       _countriesRepository = countriesRepository,
+       _headlineId = headlineId,
+       super(const EditHeadlineState()) {
     on<EditHeadlineLoaded>(_onLoaded);
     on<EditHeadlineTitleChanged>(_onTitleChanged);
     on<EditHeadlineExcerptChanged>(_onExcerptChanged);
@@ -215,6 +212,7 @@ class EditHeadlineBloc extends Bloc<EditHeadlineEvent, EditHeadlineState> {
     try {
       emit(state.copyWith(countriesIsLoadingMore: true));
 
+      // ignore: inference_failure_on_instance_creation
       await Future.delayed(const Duration(milliseconds: 400));
 
       final nextCountries = await _countriesRepository.readAll(

lib/content_management/bloc/edit_source/edit_source_bloc.dart

@@ -1,5 +1,4 @@
 import 'package:bloc/bloc.dart';
-import 'package:bloc_concurrency/bloc_concurrency.dart';
 import 'package:core/core.dart';
 import 'package:data_repository/data_repository.dart';
 import 'package:equatable/equatable.dart';
@@ -16,8 +15,6 @@ final class _FetchNextLanguagePage extends EditSourceEvent {
   const _FetchNextLanguagePage();
 }
 
-const _searchDebounceDuration = Duration(milliseconds: 300);
-
 /// A BLoC to manage the state of editing a single source.
 class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
   /// {@macro edit_source_bloc}
@@ -26,11 +23,11 @@ class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
     required DataRepository<Country> countriesRepository,
     required DataRepository<Language> languagesRepository,
     required String sourceId,
-  })  : _sourcesRepository = sourcesRepository,
-        _countriesRepository = countriesRepository,
-        _languagesRepository = languagesRepository,
-        _sourceId = sourceId,
-        super(const EditSourceState()) {
+  }) : _sourcesRepository = sourcesRepository,
+       _countriesRepository = countriesRepository,
+       _languagesRepository = languagesRepository,
+       _sourceId = sourceId,
+       super(const EditSourceState()) {
     on<EditSourceLoaded>(_onLoaded);
     on<EditSourceNameChanged>(_onNameChanged);
     on<EditSourceDescriptionChanged>(_onDescriptionChanged);
@@ -74,7 +71,7 @@ class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
         // Find the equivalent language object from the full list.
         // This ensures the DropdownButton can identify it by reference.
         selectedLanguage = languagesPaginated.items.firstWhere(
-          (listLanguage) => listLanguage.id == source.language?.id,
+          (listLanguage) => listLanguage.id == source.language.id,
         );
       } catch (_) {
         selectedLanguage = source.language;
@@ -212,6 +209,7 @@ class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
     try {
       emit(state.copyWith(countriesIsLoadingMore: true));
 
+      // ignore: inference_failure_on_instance_creation
       await Future.delayed(const Duration(milliseconds: 400));
 
       final nextCountries = await _countriesRepository.readAll(
@@ -246,6 +244,7 @@ class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
     try {
       emit(state.copyWith(languagesIsLoadingMore: true));
 
+      // ignore: inference_failure_on_instance_creation
       await Future.delayed(const Duration(milliseconds: 400));
 
       final nextLanguages = await _languagesRepository.readAll(

lib/content_management/view/create_headline_page.dart

@@ -250,9 +250,9 @@ class _CreateHeadlineViewState extends State<_CreateHeadlineView> {
                       ],
                       onChanged: state.countriesIsLoadingMore
                           ? null
-                          : (value) => context
-                              .read<CreateHeadlineBloc>()
-                              .add(CreateHeadlineCountryChanged(value)),
+                          : (value) => context.read<CreateHeadlineBloc>().add(
+                              CreateHeadlineCountryChanged(value),
+                            ),
                     ),
                     const SizedBox(height: AppSpacing.lg),
                     DropdownButtonFormField<ContentStatus>(

lib/content_management/view/create_source_page.dart

@@ -181,9 +181,9 @@ class _CreateSourceViewState extends State<_CreateSourceView> {
                       ],
                       onChanged: state.languagesIsLoadingMore
                           ? null
-                          : (value) => context
-                              .read<CreateSourceBloc>()
-                              .add(CreateSourceLanguageChanged(value)),
+                          : (value) => context.read<CreateSourceBloc>().add(
+                              CreateSourceLanguageChanged(value),
+                            ),
                     ),
                     const SizedBox(height: AppSpacing.lg),
                     DropdownButtonFormField<SourceType?>(
@@ -242,9 +242,9 @@ class _CreateSourceViewState extends State<_CreateSourceView> {
                       ],
                       onChanged: state.countriesIsLoadingMore
                           ? null
-                          : (value) => context
-                              .read<CreateSourceBloc>()
-                              .add(CreateSourceHeadquartersChanged(value)),
+                          : (value) => context.read<CreateSourceBloc>().add(
+                              CreateSourceHeadquartersChanged(value),
+                            ),
                     ),
                     const SizedBox(height: AppSpacing.lg),
                     DropdownButtonFormField<ContentStatus>(