Skip to content

Commit bd25151

Browse files
committed
style: format & cleanup misc
1 parent 08da325 commit bd25151

32 files changed

+113
-107
lines changed

lib/account/view/saved_headlines_page.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ class SavedHeadlinesPage extends StatelessWidget {
9595
final headline = savedHeadlines[index];
9696
final imageStyle =
9797
appState.settings?.feedPreferences.headlineImageStyle ??
98-
HeadlineImageStyle
99-
.smallThumbnail; // Default if settings not loaded
98+
HeadlineImageStyle.smallThumbnail;
10099

101100
final trailingButton = IconButton(
102101
icon: Icon(Icons.delete_outline, color: colorScheme.error),

lib/ads/ad_service.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class AdService {
5656
Future<void> disposeAd(dynamic adModel) async {
5757
// Determine the AdPlatformType from the adModel if it's an InlineAd or InterstitialAd.
5858
AdPlatformType? providerType;
59-
Object? adObject; // To hold the actual ad object
59+
Object? adObject;
6060

6161
if (adModel is InlineAd) {
6262
providerType = adModel.provider;
@@ -69,7 +69,7 @@ class AdService {
6969
if (providerType != null && adObject != null) {
7070
final adProvider = _adProviders[providerType];
7171
if (adProvider != null) {
72-
await adProvider.disposeAd(adObject); // Pass the actual ad object
72+
await adProvider.disposeAd(adObject);
7373
} else {
7474
_logger.warning(
7575
'AdService: No AdProvider found for type $providerType to dispose ad.',
@@ -223,7 +223,7 @@ class AdService {
223223
_logger.info('AdService: getInArticleAd called.');
224224
return _loadInlineAd(
225225
adConfig: adConfig,
226-
adType: AdType.banner, // In-article ads are now always banners
226+
adType: AdType.banner,
227227
adThemeStyle: adThemeStyle,
228228
feedAd: false,
229229
bannerAdShape: adConfig.articleAdConfiguration.bannerAdShape,

lib/ads/demo_ad_provider.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class DemoAdProvider implements AdProvider {
4444
return NativeAd(
4545
id: _uuid.v4(),
4646
provider: AdPlatformType.demo,
47-
adObject: Object(), // Placeholder object
47+
adObject: Object(),
4848
templateType: headlineImageStyle == HeadlineImageStyle.largeThumbnail
4949
? NativeAdTemplateType.medium
5050
: NativeAdTemplateType.small,
@@ -65,7 +65,7 @@ class DemoAdProvider implements AdProvider {
6565
return BannerAd(
6666
id: _uuid.v4(),
6767
provider: AdPlatformType.demo,
68-
adObject: Object(), // Placeholder object
68+
adObject: Object(),
6969
);
7070
}
7171

@@ -82,7 +82,7 @@ class DemoAdProvider implements AdProvider {
8282
return InterstitialAd(
8383
id: _uuid.v4(),
8484
provider: AdPlatformType.demo,
85-
adObject: Object(), // Placeholder object
85+
adObject: Object(),
8686
);
8787
}
8888

lib/ads/inline_ad_cache_service.dart

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,8 @@ class InlineAdCacheService {
109109
final ad = _cache[id];
110110
if (ad != null) {
111111
_logger.info('Removing and disposing inline ad with ID "$id".');
112-
_adService.disposeAd(ad); // Delegate disposal to AdService
112+
// Delegate disposal to AdService
113+
_adService.disposeAd(ad);
113114
_cache.remove(id);
114115
} else {
115116
_logger.info('Inline ad with ID "$id" not found in cache for disposal.');
@@ -126,9 +127,11 @@ class InlineAdCacheService {
126127
'Clearing all cached inline ads and disposing their resources.',
127128
);
128129
for (final ad in _cache.values.whereType<InlineAd>()) {
129-
_adService.disposeAd(ad); // Delegate disposal to AdService
130+
// Delegate disposal to AdService
131+
_adService.disposeAd(ad);
130132
}
131-
_cache.clear(); // Ensure cache is empty after disposal attempts.
133+
// Ensure cache is empty after disposal attempts.
134+
_cache.clear();
132135
_logger.info('All cached inline ads cleared.');
133136
}
134137

lib/ads/interstitial_ad_manager.dart

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,8 @@ class InterstitialAdManager {
171171
if (requiredTransitions > 0 && _transitionCount >= requiredTransitions) {
172172
_logger.info('Transition count meets threshold. Attempting to show ad.');
173173
await _showAd();
174-
_transitionCount =
175-
0; // Reset counter after showing (or attempting to show)
174+
// Reset counter after showing (or attempting to show)
175+
_transitionCount = 0;
176176
} else {
177177
_logger.info(
178178
'Transition count ($_transitionCount) has not met threshold ($requiredTransitions).',
@@ -197,7 +197,8 @@ class InterstitialAdManager {
197197
}
198198

199199
final adToShow = _preloadedAd!;
200-
_preloadedAd = null; // Clear the pre-loaded ad before showing
200+
// Clear the pre-loaded ad before showing
201+
_preloadedAd = null;
201202

202203
try {
203204
switch (adToShow.provider) {
@@ -230,7 +231,9 @@ class InterstitialAdManager {
230231
} finally {
231232
// After the ad is shown or fails to show, dispose of it and
232233
// start pre-loading the next one for the next opportunity.
233-
_disposePreloadedAd(); // Ensure the ad object is disposed
234+
235+
// Ensure the ad object is disposed
236+
_disposePreloadedAd();
234237
unawaited(_maybePreloadAd(_appBloc.state));
235238
}
236239
}
@@ -268,7 +271,8 @@ class InterstitialAdManager {
268271
// Await the result of showDialog, which completes when the dialog is popped.
269272
await showDialog<void>(
270273
context: context,
271-
barrierDismissible: false, // Prevent dismissing by tapping outside
274+
// Prevent dismissing by tapping outside
275+
barrierDismissible: false,
272276
builder: (_) => LocalInterstitialAdDialog(
273277
localInterstitialAd: ad.adObject as LocalInterstitialAd,
274278
),
@@ -279,7 +283,8 @@ class InterstitialAdManager {
279283
// Await the result of showDialog, which completes when the dialog is popped.
280284
await showDialog<void>(
281285
context: context,
282-
barrierDismissible: false, // Prevent dismissing by tapping outside
286+
// Prevent dismissing by tapping outside
287+
barrierDismissible: false,
283288
builder: (_) => const DemoInterstitialAdDialog(),
284289
);
285290
}

lib/ads/local_ad_provider.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class LocalAdProvider implements AdProvider {
4343
required AdPlatformIdentifiers adPlatformIdentifiers,
4444
required String? adId,
4545
required AdThemeStyle adThemeStyle,
46-
HeadlineImageStyle? headlineImageStyle, // Added for interface consistency
46+
HeadlineImageStyle? headlineImageStyle,
4747
}) async {
4848
_logger.info('LocalAdProvider: loadNativeAd called for adId: $adId');
4949
if (adId == null || adId.isEmpty) {
@@ -97,7 +97,7 @@ class LocalAdProvider implements AdProvider {
9797
required AdPlatformIdentifiers adPlatformIdentifiers,
9898
required String? adId,
9999
required AdThemeStyle adThemeStyle,
100-
HeadlineImageStyle? headlineImageStyle, // Added for interface consistency
100+
HeadlineImageStyle? headlineImageStyle,
101101
}) async {
102102
_logger.info('LocalAdProvider: loadBannerAd called for adId: $adId');
103103
if (adId == null || adId.isEmpty) {

lib/ads/widgets/admob_inline_ad_widget.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class _AdmobInlineAdWidgetState extends State<AdmobInlineAdWidget> {
5959
// and set the new one. This is a more robust check than just comparing IDs,
6060
// as a new InlineAd instance might be created for the same logical ad slot.
6161
if (widget.inlineAd != oldWidget.inlineAd) {
62-
_disposeCurrentAd(); // Dispose the old ad object
62+
_disposeCurrentAd();
6363
_setAd();
6464
}
6565
}

lib/ads/widgets/demo_banner_ad_widget.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class DemoBannerAdWidget extends StatelessWidget {
3939
} else {
4040
adHeight = headlineImageStyle == HeadlineImageStyle.largeThumbnail
4141
? 250 // Height for mediumRectangle banner
42-
: 50; // Height for standard banner
42+
: 50;
4343
}
4444

4545
return Card(

lib/ads/widgets/demo_native_ad_widget.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class DemoNativeAdWidget extends StatelessWidget {
2424
// Determine the height based on the headlineImageStyle, mimicking real ad widgets.
2525
final adHeight = headlineImageStyle == HeadlineImageStyle.largeThumbnail
2626
? 250 // Height for medium native ad template
27-
: 120; // Height for small native ad template
27+
: 120;
2828

2929
return Card(
3030
margin: const EdgeInsets.symmetric(

lib/ads/widgets/feed_ad_loader_widget.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
9898
// completed. This prevents a race condition if a new load is triggered
9999
// while an old one is still in progress.
100100
if (_loadAdCompleter != null && !_loadAdCompleter!.isCompleted) {
101-
_loadAdCompleter!.complete(); // Complete normally to prevent crashes
101+
// Complete normally to prevent crashes
102+
_loadAdCompleter!.complete();
102103
}
103104
_loadAdCompleter = null;
104105

@@ -125,7 +126,8 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
125126
// This prevents `setState()` calls on a disposed widget.
126127
// Ensure the completer is not already completed before attempting to complete it.
127128
if (_loadAdCompleter != null && !_loadAdCompleter!.isCompleted) {
128-
_loadAdCompleter!.complete(); // Complete normally to prevent crashes
129+
// Complete normally to prevent crashes
130+
_loadAdCompleter!.complete();
129131
}
130132
_loadAdCompleter = null;
131133
super.dispose();
@@ -211,10 +213,10 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
211213

212214
// Call AdService.getFeedAd with the full AdConfig and adType from the placeholder.
213215
final loadedAd = await _adService.getFeedAd(
214-
adConfig: widget.adConfig, // Pass the full AdConfig
216+
adConfig: widget.adConfig,
215217
adType: widget.adPlaceholder.adType,
216218
adThemeStyle: widget.adThemeStyle,
217-
headlineImageStyle: headlineImageStyle, // Pass the headlineImageStyle
219+
headlineImageStyle: headlineImageStyle,
218220
);
219221

220222
if (loadedAd != null) {

0 commit comments

Comments
 (0)