Fix CreatedResultAssertions tests.

Author: faddiv

src/FluentAssertions.AspNetCore.Mvc/CreatedResultAssertions.cs

@@ -50,11 +50,14 @@ public TValue ValueAs<TValue>()
             var value = CreatedResultSubject.Value;
 
             if (value == null)
-                Execute.Assertion.FailWith(FailureMessages.CommonNullWasSuppliedFailMessage, "CreatedResult.Value", typeof(TValue).Name);
+                Execute.Assertion
+                    .WithDefaultIdentifier("CreatedResult.Value")
+                    .FailWith(FailureMessages.CommonNullWasSuppliedFailMessage, typeof(TValue));
 
             Execute.Assertion
                 .ForCondition(value is TValue)
-                .FailWith(FailureMessages.CommonTypeFailMessage, "CreatedResult.Value", typeof(TValue).Name, value.GetType().Name);
+                .WithDefaultIdentifier("CreatedResult.Value")
+                .FailWith(FailureMessages.CommonTypeFailMessage, typeof(TValue), value.GetType());
 
             return (TValue)value;
         }
@@ -66,15 +69,17 @@ public TValue ValueAs<TValue>()
         /// The Uri.
         /// </param>
         /// <returns>The typed value.</returns>
-        public CreatedResultAssertions WithUri(Uri uri)
+        public CreatedResultAssertions WithUri(Uri uri, string reason = "", params object[] reasonArgs)
         {
             var expectedUri = !uri.IsAbsoluteUri 
                 ? uri.GetComponents(UriComponents.SerializationInfoString, UriFormat.UriEscaped) 
                 : uri.AbsoluteUri;
 
             Execute.Assertion
+                .BecauseOf(reason, reasonArgs)
                 .ForCondition(expectedUri == Location)
-                .FailWith(FailureMessages.CommonFailMessage, "CreatedResult.Uri", expectedUri, Location);
+                .WithDefaultIdentifier("CreatedResult.Uri")
+                .FailWith(FailureMessages.CommonFailMessage, expectedUri, Location);
 
             return this;
         }
@@ -86,11 +91,13 @@ public CreatedResultAssertions WithUri(Uri uri)
         /// The Uri as string.
         /// </param>
         /// <returns>The typed value.</returns>
-        public CreatedResultAssertions WithUri(string uri)
+        public CreatedResultAssertions WithUri(string uri, string reason = "", params object[] reasonArgs)
         {
             Execute.Assertion
+                .BecauseOf(reason, reasonArgs)
                 .ForCondition(uri == Location)
-                .FailWith(FailureMessages.CommonFailMessage, "CreatedResult.Uri", uri, Location);
+                .WithDefaultIdentifier("CreatedResult.Uri")
+                .FailWith(FailureMessages.CommonFailMessage, uri, Location);
 
             return this;
         }

tests/FluentAssertions.AspNetCore.Mvc.Tests/CreatedResultAssertions_Tests.cs

@@ -7,6 +7,8 @@ namespace FluentAssertions.AspNetCore.Mvc.Tests
 {
     public class CreatedResultAssertions_Tests
     {
+        public const string Reason = FailureMessageHelper.Reason;
+        public readonly static object[] ReasonArgs = FailureMessageHelper.ReasonArgs;
         private const string TestValue = "testValue";
 
         private const string TestUriAsString = "http://localhost:5000";
@@ -19,78 +21,85 @@ public class CreatedResultAssertions_Tests
         public void Value_GivenExpectedValue_ShouldPass()
         {
             var result = new TestController().Created(TestUri, TestValue);
-            result.Should().BeCreatedResult().Value.Should().Be(TestValue);
-        }
 
-        [Fact]
-        public void Value_GivenUnexpectedValue_ShouldFail()
-        {
-            var result = new TestController().Created(TestUri, TestValue);
-            Action a = () => result.Should().BeCreatedResult().Value.Should().Be("xyx");
-            a.Should().Throw<Exception>();
+            result.Should().BeCreatedResult().Value.Should().BeSameAs(TestValue);
         }
 
         [Fact]
         public void ValueAs_GivenExpectedValue_ShouldPass()
         {
             var result = new TestController().Created(TestUri, TestValue);
+
             result.Should().BeCreatedResult().ValueAs<string>().Should().Be(TestValue);
         }
 
         [Fact]
         public void ValueAs_GivenUnexpectedValue_ShouldFail()
         {
             var result = new TestController().Created(TestUri, TestValue);
-            Action a = () => result.Should().BeCreatedResult().ValueAs<string>().Should().Be("xyx");
+
+            Action a = () => result.Should().BeCreatedResult().ValueAs<string>().Should().Be("xyx", Reason, ReasonArgs);
+
             a.Should().Throw<Exception>();
         }
 
         [Fact]
         public void ValueAs_GivenWrongType_ShouldFail()
         {
             var result = new TestController().Created(TestUri, TestValue);
-            Action a = () => result.Should().BeCreatedResult().ValueAs<int>().Should().Be(2);
-            a.Should().Throw<Exception>();
+            var failureMessage = FailureMessageHelper.ExpectedContextTypeXButFoundY("CreatedResult.Value", typeof(int).FullName, typeof(string).FullName);
+
+            Action a = () => result.Should().BeCreatedResult().ValueAs<int>().Should().Be(2, Reason, ReasonArgs);
+
+            a.Should().Throw<Exception>().WithMessage(failureMessage);
         }
 
         [Fact]
         public void ValueAs_Null_ShouldFail()
         {
             ActionResult result = new CreatedResult(TestUri, null);
-            var failureMessage = FailureMessageHelper.Format(FailureMessages.CommonNullWasSuppliedFailMessage, "CreatedResult.Value", typeof(object).Name);
+            var failureMessage = FailureMessageHelper.ExpectedContextTypeXButFoundNull("CreatedResult.Value", typeof(object).FullName);
+
             Action a = () => result.Should().BeCreatedResult().ValueAs<object>();
+
             a.Should().Throw<Exception>().WithMessage(failureMessage);
         }
 
         [Fact]
         public void WithUri_GivenExpectedUri_ShouldPass()
         {
             var result = new TestController().Created(TestUri, TestValue);
-            Action a = () => result.Should().BeCreatedResult().WithUri(TestUri);
+            
+            result.Should().BeCreatedResult().WithUri(TestUri);
         }
 
         [Fact]
         public void WithUri_GivenWrongUri_ShouldFail()
         {
             var result = new TestController().Created(TestWrongUri, TestValue);
-            Action a = () => result.Should().BeCreatedResult().WithUri(TestUri);
-            var failureMessage = FailureMessageHelper.Format(FailureMessages.CommonFailMessage, "CreatedResult.Uri", TestUri.ToString(), TestWrongUri.ToString());
+            var failureMessage = FailureMessageHelper.ExpectedContextToBeXButY("CreatedResult.Uri", TestUri, TestWrongUri);
+
+            Action a = () => result.Should().BeCreatedResult().WithUri(TestUri, Reason, ReasonArgs);
+
             a.Should().Throw<Exception>().WithMessage(failureMessage);
         }
 
         [Fact]
         public void WithUri_GivenExpectedUriAsString_ShouldPass()
         {
             var result = new TestController().Created(TestUriAsString, TestValue);
-            Action a = () => result.Should().BeCreatedResult().WithUri(TestUriAsString);
+            
+            result.Should().BeCreatedResult().WithUri(TestUriAsString);
         }
 
         [Fact]
         public void WithUri_GivenWrongUriAsString_ShouldFail()
         {
             var result = new TestController().Created(TestWrongUriAsString, TestValue);
-            Action a = () => result.Should().BeCreatedResult().WithUri(TestUriAsString);
-            var failureMessage = FailureMessageHelper.Format(FailureMessages.CommonFailMessage, "CreatedResult.Uri", TestUriAsString, TestWrongUriAsString);
+            var failureMessage = FailureMessageHelper.ExpectedContextToBeXButY("CreatedResult.Uri", TestUriAsString, TestWrongUriAsString);
+
+            Action a = () => result.Should().BeCreatedResult().WithUri(TestUriAsString, Reason, ReasonArgs);
+
             a.Should().Throw<Exception>().WithMessage(failureMessage);
         }
     }

tests/FluentAssertions.AspNetCore.Mvc.Tests/Helpers/FailureMessageHelper.cs

@@ -16,6 +16,11 @@ public static string Format(string message, params string[] args)
             return String.Format(message, formattedArg);
         }
 
+        public static string ExpectedContextToBeXButY(string context, Uri expected, Uri actual)
+        {
+            return ExpectedContextToBeXButY(context, expected?.ToString(), actual?.ToString());
+        }
+
         public static string ExpectedContextToBeXButY(string context, string expected, string actual)
         {
             return ExpectedContextToBeXButY(context, (object)$"\"{expected}\"", (object)$"\"{actual}\"");