Refactor CreatedAtActionResultAssertions to use ObjectResultAssertionsBase.

Author: faddiv

src/FluentAssertions.AspNetCore.Mvc/AcceptedAtActionResultAssertions.cs

@@ -29,7 +29,7 @@ public AcceptedAtActionResultAssertions(AcceptedAtActionResult subject) : base(s
         /// </param>
         public AcceptedAtActionResultAssertions WithActionName(string expectedActionName, string reason = "", params object[] reasonArgs)
         {
-            string actualActionName = ObjectResultSubject?.ActionName;
+            string actualActionName = ObjectResultSubject.ActionName;
 
             Execute.Assertion
                    .ForCondition(string.Equals(actualActionName, expectedActionName, StringComparison.OrdinalIgnoreCase))
@@ -53,7 +53,7 @@ public AcceptedAtActionResultAssertions WithActionName(string expectedActionName
         /// </param>
         public AcceptedAtActionResultAssertions WithControllerName(string expectedControllerName, string reason = "", params object[] reasonArgs)
         {
-            string actualControllerName = ObjectResultSubject?.ControllerName;
+            string actualControllerName = ObjectResultSubject.ControllerName;
 
             Execute.Assertion
                 .ForCondition(string.Equals(actualControllerName, expectedControllerName, StringComparison.OrdinalIgnoreCase))

src/FluentAssertions.AspNetCore.Mvc/CreatedAtActionResultAssertions.cs

@@ -1,16 +1,15 @@
-using System;
-using System.Diagnostics;
-using FluentAssertions.Execution;
-using FluentAssertions.Primitives;
+using FluentAssertions.Execution;
 using Microsoft.AspNetCore.Mvc;
+using System;
+using System.Diagnostics;
 
 namespace FluentAssertions.AspNetCore.Mvc
 {
     /// <summary>
     /// Contains a number of methods to assert that a <see cref="CreatedAtActionResult"/> is in the expected state.
     /// </summary>
     [DebuggerNonUserCode]
-    public class CreatedAtActionResultAssertions : ObjectAssertions
+    public class CreatedAtActionResultAssertions : ObjectResultAssertionsBase<CreatedAtActionResult, CreatedAtActionResultAssertions>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="CreatedAtActionResultAssertions" /> class.
@@ -30,7 +29,7 @@ public CreatedAtActionResultAssertions(CreatedAtActionResult subject) : base(sub
         /// </param>
         public CreatedAtActionResultAssertions WithActionName(string expectedActionName, string reason = "", params object[] reasonArgs)
         {
-            string actualActionName = (Subject as CreatedAtActionResult)?.ActionName;
+            string actualActionName = ObjectResultSubject.ActionName;
 
             Execute.Assertion
                    .ForCondition(string.Equals(actualActionName, expectedActionName, StringComparison.OrdinalIgnoreCase))
@@ -54,7 +53,7 @@ public CreatedAtActionResultAssertions WithActionName(string expectedActionName,
         /// </param>
         public CreatedAtActionResultAssertions WithControllerName(string expectedControllerName, string reason = "", params object[] reasonArgs)
         {
-            string actualControllerName = (Subject as CreatedAtActionResult)?.ControllerName;
+            string actualControllerName = ObjectResultSubject.ControllerName;
 
             Execute.Assertion
                 .ForCondition(string.Equals(actualControllerName, expectedControllerName, StringComparison.OrdinalIgnoreCase))
@@ -79,35 +78,12 @@ public CreatedAtActionResultAssertions WithControllerName(string expectedControl
         /// </param>
         public CreatedAtActionResultAssertions WithRouteValue(string key, object expectedValue, string reason = "", params object[] reasonArgs)
         {
-            var subjectTyped = Subject as CreatedAtActionResult;
+            var actualRouteValues = ObjectResultSubject.RouteValues;
 
-            AssertionHelpers.AssertStringObjectDictionary(subjectTyped.RouteValues, "CreatedAtActionResult.RouteValues",
+            AssertionHelpers.AssertStringObjectDictionary(actualRouteValues, "CreatedAtActionResult.RouteValues",
                 key, expectedValue, reason, reasonArgs);
 
             return this;
         }
-
-        /// <summary>
-        ///     Asserts the value is of the expected type.
-        /// </summary>
-        /// <typeparam name="TValue">The expected type.</typeparam>
-        /// <returns>The typed value.</returns>
-        public TValue ValueAs<TValue>()
-        {
-            var subjectTyped = Subject as CreatedAtActionResult;
-            var value = subjectTyped.Value;
-
-            if (value == null)
-                Execute.Assertion
-                    .WithDefaultIdentifier("CreatedAtActionResult.Value")
-                    .FailWith(FailureMessages.CommonNullWasSuppliedFailMessage, typeof(TValue));
-
-            Execute.Assertion
-                .ForCondition(value is TValue)
-                .WithDefaultIdentifier("CreatedAtActionResult.Value")
-                .FailWith(FailureMessages.CommonTypeFailMessage, typeof(TValue), value.GetType());
-
-            return (TValue)value;
-        }
     }
 }

tests/FluentAssertions.AspNetCore.Mvc.Tests/CreatedAtActionResultAssertions_Tests.cs

@@ -1,11 +1,11 @@
-using System;
-using FluentAssertions.Mvc.Tests.Helpers;
+using FluentAssertions.Mvc.Tests.Helpers;
 using Microsoft.AspNetCore.Mvc;
+using System;
 using Xunit;
 
 namespace FluentAssertions.AspNetCore.Mvc.Tests
 {
-    
+
     public class CreatedAtActionResultAssertions_Tests
     {
         public const string Reason = FailureMessageHelper.Reason;