Fix Several assertion not including reason text.

Author: faddiv

src/FluentAssertions.AspNetCore.Mvc/FailureMessages.Designer.cs

@@ -133,7 +133,7 @@
     <value>Expected {context} to be of type {0}, but no value was supplied.</value>
   </data>
   <data name="CommonTypeFailMessage" xml:space="preserve">
-    <value>Expected {context} to be of type {0} but was {1}.</value>
+    <value>Expected {context} to be of type {0} but was {1}{reason}.</value>
   </data>
   <data name="ConvertibelModelFailMessage" xml:space="preserve">
     <value>Expected {context} to be ActionResult&lt;TValue&gt; with type {0}{reason} but was {1}.</value>

src/FluentAssertions.AspNetCore.Mvc/FailureMessages.resx

@@ -62,8 +62,8 @@ public void BeActionResult_GivenUnexpectedType_ShouldFail()
         {
             var mock = new Mock<IConvertToActionResult>();
             var result = mock.Object;
-            var failureMessage = FailureMessageHelper.ExpectedContextTypeXButFoundY(
-                "result", "Microsoft.AspNetCore.Mvc.ActionResult`1[System.Object]", result.GetType().FullName);
+            var failureMessage = FailureMessageHelper.ExpectedContextTypeXButFoundYWithReason(
+                "result", typeof(ActionResult<object>), result.GetType());
 
             Action action = () => result.Should().BeActionResult<object>(Reason, ReasonArgs);
 

tests/FluentAssertions.AspNetCore.Mvc.Tests/ConvertToActionResultAssertions_Tests.cs

@@ -88,12 +88,12 @@ internal static string ExpectedToContainItem(string context, object list, string
 
         internal static string ExpectedContextTypeXButFoundY(string context, Type expected, Type actual)
         {
-            return ExpectedContextTypeXButFoundY(context, expected.FullName, actual.FullName);
+            return $"Expected {context} to be of type {Formatter.ToString(expected)} but was {Formatter.ToString(actual)}.";
         }
 
-        internal static string ExpectedContextTypeXButFoundY(string context, string expected, string actual)
+        internal static string ExpectedContextTypeXButFoundYWithReason(string context, Type expected, Type actual)
         {
-            return $"Expected {context} to be of type {expected} but was {actual}.";
+            return $"Expected {context} to be of type {Formatter.ToString(expected)} but was {Formatter.ToString(actual)} because it is 10.";
         }
 
         internal static string ExpectedContextTypeXButFoundNull(string context, Type expectedType)

tests/FluentAssertions.AspNetCore.Mvc.Tests/Helpers/FailureMessageHelper.cs

@@ -155,5 +155,38 @@ public void WithContentType_GivenUnexpected_ShouldFail()
             a.Should().Throw<Exception>()
                 .WithMessage(failureMessage);
         }
+
+
+        [Fact]
+        public void WithDeclaredType_GivenExpected_ShouldPass()
+        {
+            var expectedType = typeof(string);
+            var result = new ObjectResult(TestValue)
+            {
+                DeclaredType = expectedType
+            };
+
+            result.Should().BeObjectResult().WithDeclaredType(expectedType);
+        }
+
+        [Fact]
+        public void WithDeclaredType_GivenUnexpected_ShouldFail()
+        {
+            var expectedType = typeof(int);
+            var declaredType = typeof(string);
+            var result = new ObjectResult(TestValue)
+            {
+                DeclaredType = declaredType
+            };
+            string failureMessage = FailureMessageHelper.ExpectedContextTypeXButFoundYWithReason(
+                "ObjectResult.DeclaredType",
+                expectedType,
+                declaredType);
+
+            Action a = () => result.Should().BeObjectResult().WithDeclaredType(expectedType, Reason, ReasonArgs);
+
+            a.Should().Throw<Exception>()
+                .WithMessage(failureMessage);
+        }
     }
 }