Fix CreatedAtRouteResultAssertions tests.

Author: faddiv

tests/FluentAssertions.AspNetCore.Mvc.Tests/CreatedAtRouteResultAssertions_Tests.cs

@@ -5,9 +5,11 @@
 
 namespace FluentAssertions.AspNetCore.Mvc.Tests
 {
-    
+
     public class CreatedAtRouteResultAssertions_Tests
     {
+        public const string Reason = FailureMessageHelper.Reason;
+        public readonly static object[] ReasonArgs = FailureMessageHelper.ReasonArgs;
         private const string TestValue = "testValue";
 
         [Fact]
@@ -22,76 +24,83 @@ public void WithRouteName_GivenExpectedRouteName_ShouldPass()
         public void WithRouteName_GivenUnexpectedRouteName_ShouldFail()
         {
             var result = new CreatedAtRouteResult("someOtherRoute", null, null);
-            Action a = () => result.Should().BeCreatedAtRouteResult().WithRouteName("expectedRoute");
-            var failureMessage = FailureMessageHelper.Format(FailureMessages.CommonFailMessage, "CreatedAtRouteResult.RouteName", "expectedRoute", "someOtherRoute");
+            var failureMessage = FailureMessageHelper.ExpectedContextToBeXButY("CreatedAtRouteResult.RouteName", "expectedRoute", "someOtherRoute");
+
+            Action a = () => result.Should().BeCreatedAtRouteResult().WithRouteName("expectedRoute", Reason, ReasonArgs);
+
             a.Should().Throw<Exception>().WithMessage(failureMessage);
         }
 
         [Fact]
         public void WithRouteValue_GivenKeyDoesntExist_ShouldFail()
         {
-            var expectedKey = "expectedKey";            
-
-            var routeValues = new {myKey = "MyValue"};
+            var expectedKey = "expectedKey";
+            var routeValues = new { myKey = TestValue };
             var result = new CreatedAtRouteResult(string.Empty, routeValues, null);
+            var failureMessage = FailureMessageHelper.ExpectedContextContainValueAtKeyButKeyNotFound(
+                "CreatedAtRouteResult.RouteValues", TestValue, expectedKey);
+
+            Action a = () => result.Should().BeCreatedAtRouteResult().WithRouteValue(expectedKey, TestValue, Reason, ReasonArgs);
 
-            Action a = () => result.Should().BeCreatedAtRouteResult().WithRouteValue(expectedKey, "");
-            a.Should().Throw<Exception>().WithMessage("sss");
+            a.Should().Throw<Exception>().WithMessage(failureMessage);
         }
 
         [Fact]
         public void WithRouteValue_GivenExpectedKeyValuePair_ShouldPass()
         {
             var expectedKey = "expectedKey";
             var expectedValue = "expectedValue";
-            var routeValues = new {expectedKey = expectedValue};
-
+            var routeValues = new { expectedKey = expectedValue };
             var result = new CreatedAtRouteResult(string.Empty, routeValues, null);
+
             result.Should().BeCreatedAtRouteResult().WithRouteValue(expectedKey, expectedValue);
         }
 
         [Fact]
-        public void HaveValue_GivenUnexpectedKeyValuePair_ShouldFail()
+        public void WithRouteValue_GivenUnexpectedKeyValuePair_ShouldFail()
         {
             var expectedKey = "expectedKey";
             var expectedValue = "expectedValue";
             var routeValues = new { expectedKey = "someOtherValue" };
-
             var result = new CreatedAtRouteResult(string.Empty, routeValues, null);
-            Action a = () => result.Should().BeCreatedAtRouteResult().WithRouteValue(expectedKey, expectedValue);
-            a.Should().Throw<Exception>().WithMessage("sss");
+            var failureMessage = FailureMessageHelper.ExpectedAtKeyValueXButFoundY(
+                "CreatedAtRouteResult.RouteValues", expectedKey, expectedValue, "someOtherValue");
+
+            Action a = () => result.Should().BeCreatedAtRouteResult().WithRouteValue(expectedKey, expectedValue, Reason, ReasonArgs);
+
+            a.Should().Throw<Exception>().WithMessage(failureMessage);
         }
 
         [Fact]
         public void ValueAs_GivenExpectedValue_ShouldPass()
         {
             var result = new TestController().CreatedAtRoute(string.Empty, null, TestValue);
-            result.Should().BeCreatedAtRouteResult().ValueAs<string>().Should().Be(TestValue);
+
+            result.Should().BeCreatedAtRouteResult().ValueAs<string>().Should().BeSameAs(TestValue);
         }
 
         [Fact]
-        public void ValueAs_GivenUnexpectedValue_ShouldFail()
+        public void ValueAs_Null_ShouldFail()
         {
-            var result = new TestController().CreatedAtRoute(string.Empty, null, TestValue);
-            Action a = () => result.Should().BeCreatedAtRouteResult().ValueAs<string>().Should().Be("xyx");
-            a.Should().Throw<Exception>();
+            ActionResult result = new CreatedAtRouteResult(string.Empty, null, null);
+            string failureMessage = FailureMessageHelper.ExpectedContextTypeXButFoundNull("CreatedAtRouteResult.Value", typeof(object).FullName);
+
+            Action a = () => result.Should().BeCreatedAtRouteResult().ValueAs<object>();
+
+            a.Should().Throw<Exception>().WithMessage(failureMessage);
         }
 
         [Fact]
         public void ValueAs_GivenWrongType_ShouldFail()
         {
-            var result = new TestController().CreatedAtRoute(string.Empty, null, TestValue);
+            ActionResult result = new CreatedAtRouteResult(string.Empty, null, "");
+            string failureMessage = FailureMessageHelper.ExpectedContextTypeXButFoundY(
+                "CreatedAtRouteResult.Value", typeof(int).FullName, typeof(string).FullName);
+
             Action a = () => result.Should().BeCreatedAtRouteResult().ValueAs<int>().Should().Be(2);
-            a.Should().Throw<Exception>();
-        }
 
-        [Fact]
-        public void ValueAs_Null_ShouldFail()
-        {
-            ActionResult result = new CreatedAtRouteResult(string.Empty, null, null);
-            var failureMessage = FailureMessageHelper.Format(FailureMessages.CommonNullWasSuppliedFailMessage, "CreatedAtRouteResult.Value", typeof(object).Name);
-            Action a = () => result.Should().BeCreatedAtRouteResult().ValueAs<object>();
-            a.Should().Throw<Exception>().WithMessage(failureMessage);
+            a.Should().Throw<Exception>()
+                .WithMessage(failureMessage);
         }
     }
 }

tests/FluentAssertions.AspNetCore.Mvc.Tests/JsonResultAssertions_Tests.cs

@@ -90,6 +90,7 @@ public void ValueAs_GivenWrongType_ShouldFail()
                 "JsonResult.Value", typeof(int).FullName, typeof(string).FullName);
 
             Action a = () => result.Should().BeJsonResult().ValueAs<int>().Should().Be(2);
+
             a.Should().Throw<Exception>()
                 .WithMessage(failureMessage);
         }