feat: Fix dictionary custom methods false diagnostics (#379)

* feat: Fix dictionary custom methods false diagnostics

Author: Meir017

src/FluentAssertions.Analyzers.Tests/Tips/DictionaryTests.cs

@@ -13,6 +13,31 @@ public class DictionaryTests
         [Implemented]
         public void DictionaryShouldContainKey_TestAnalyzer(string assertion) => VerifyCSharpDiagnostic(assertion, DiagnosticMetadata.DictionaryShouldContainKey_ContainsKeyShouldBeTrue);
 
+        [DataTestMethod]
+        [DataRow(
+@"using System.Collections.Generic;
+using FluentAssertions;
+
+namespace TestNamespace
+{
+    public class MultiKeyDict<TKey1, TKey2, TValue> : Dictionary<TKey1, Dictionary<TKey2, TValue>>
+    {
+        public bool ContainsKey(TKey1 key1, TKey2 key2) => false;
+        public bool ContainsValue(TKey1 key1, TKey2 key2) => false;
+    }
+
+    public class TestClass
+    {
+        public void TestMethod(MultiKeyDict<int, int, string> actual)
+        {
+            actual.ContainsKey(0, 1).Should().BeTrue();
+            actual.ContainsValue(0, 1).Should().BeTrue();
+        }
+    }
+}")]
+        [Implemented]
+        public void DictionaryMethods_CustomMethods_TestNoAnalyzer(string code) => DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(code);
+
         [DataTestMethod]
         [AssertionCodeFix(
             oldAssertion: "actual.ContainsKey(expectedKey).Should().BeTrue({0});",

src/FluentAssertions.Analyzers/Tips/FluentAssertionsAnalyzer.cs

@@ -49,6 +49,7 @@ private static void AnalyzeInvocation(OperationAnalysisContext context, FluentAs
             return;
         }
 
+        context.Options.AnalyzerConfigOptionsProvider.GetOptions(invocation.Syntax.SyntaxTree).TryGetValue("use_diagnostic_per_assertion", out var useDiagnosticPerAssertion);
         if (HasConditionalAccessAncestor(invocation))
         {
             var expressionStatement = invocation.GetFirstAncestor<IExpressionStatementOperation>();
@@ -211,10 +212,12 @@ private static void AnalyzeInvocation(OperationAnalysisContext context, FluentAs
                             case nameof(string.StartsWith) when invocationBeforeShould.IsContainedInType(SpecialType.System_String):
                                 context.ReportDiagnostic(CreateDiagnostic(assertion, DiagnosticMetadata.StringShouldStartWith_StartsWithShouldBeTrue));
                                 return;
-                            case nameof(IDictionary<string, object>.ContainsKey) when invocationBeforeShould.ImplementsOrIsInterface(metadata.IDictionaryOfT2) || invocationBeforeShould.ImplementsOrIsInterface(metadata.IReadonlyDictionaryOfT2):
+                            case nameof(Dictionary<string, object>.ContainsKey) when (invocationBeforeShould.ImplementsOrIsInterface(metadata.IDictionaryOfT2) || invocationBeforeShould.ImplementsOrIsInterface(metadata.IReadonlyDictionaryOfT2))
+                                    && invocationBeforeShould.AreMethodParameterSameTypeAsContainingTypeArguments((parameter: 0, typeArgument: 0)):
                                 context.ReportDiagnostic(CreateDiagnostic(assertion, DiagnosticMetadata.DictionaryShouldContainKey_ContainsKeyShouldBeTrue));
                                 return;
-                            case nameof(Dictionary<string, object>.ContainsValue) when invocationBeforeShould.IsContainedInType(metadata.DictionaryOfT2):
+                            case nameof(Dictionary<string, object>.ContainsValue) when invocationBeforeShould.IsContainedInType(metadata.DictionaryOfT2)
+                                    && invocationBeforeShould.AreMethodParameterSameTypeAsContainingTypeArguments((parameter: 0, typeArgument: 1)):
                                 context.ReportDiagnostic(CreateDiagnostic(assertion, DiagnosticMetadata.DictionaryShouldContainValue_ContainsValueShouldBeTrue));
                                 return;
                         }

src/FluentAssertions.Analyzers/Utilities/OperartionExtensions.cs

@@ -88,6 +88,23 @@ public static bool IsTypeof(this IArgumentOperation argument, SpecialType type)
     public static bool IsTypeof(this IArgumentOperation argument, INamedTypeSymbol type)
         => argument.Value.UnwrapConversion().Type.EqualsSymbol(type);
 
+    public static bool AreMethodParameterSameTypeAsContainingTypeArguments(this IInvocationOperation invocation, params (int parameter, int typeArgument)[] parameters)
+    {
+        if (invocation.TargetMethod.Parameters.Length != parameters.Length)
+            return false;
+
+        if (invocation.TargetMethod.ContainingType.TypeArguments.Length < parameters.Max(x => x.typeArgument))
+            return false;
+
+        foreach (var (parameter, typeArgument) in parameters)
+        {
+            if (!invocation.TargetMethod.Parameters[parameter].Type.EqualsSymbol(invocation.TargetMethod.ContainingType.TypeArguments[typeArgument]))
+                return false;
+        }
+
+        return true;
+    }
+
     public static bool IsSameArgumentReference(this IArgumentOperation argument1, IArgumentOperation argument2)
     {
         return argument1.TryGetFirstDescendent<IParameterReferenceOperation>(out var argument1Reference)