Fix RS1024 warnings (#169)

Author: gpetrou

src/FluentAssertions.Analyzers/Tips/MsTest/MsTestBase.cs

@@ -48,7 +48,7 @@ protected ExpressionSyntax GetNewExpressionForAreNotEqualOrAreEqualStrings(Expre
                 ignoreCase = possibleIgnoreCaseArg.Token.IsKind(SyntaxKind.TrueKeyword);
             }
 
-            if (newArguments.Count >= 2 && semanticModel.GetCultureInfoType().Equals(semanticModel.GetTypeInfo(rename.Arguments[3].Expression).Type))
+            if (newArguments.Count >= 2 && semanticModel.GetCultureInfoType().Equals(semanticModel.GetTypeInfo(rename.Arguments[3].Expression).Type, SymbolEqualityComparer.Default))
             {
                 newArguments = newArguments.Remove(newArguments[1]);
             }

src/FluentAssertions.Analyzers/Tips/ShouldEquals.cs

@@ -53,7 +53,7 @@ protected override async Task<bool> CanRewriteAssertion(ExpressionSyntax express
             var info = model.GetTypeInfo(member.Expression);
 
             var taskCompletionSourceInfo = model.Compilation.GetTypeByMetadataName(typeof(TaskCompletionSource<>).FullName);
-            if (info.Type.Equals(taskCompletionSourceInfo)) return false;
+            if (info.Type.Equals(taskCompletionSourceInfo, SymbolEqualityComparer.Default)) return false;
 
             var streamInfo = model.Compilation.GetTypeByMetadataName(typeof(Stream).FullName);
             if (info.Type.AllInterfaces.Contains(streamInfo)) return false;
@@ -73,7 +73,7 @@ protected override async Task<ExpressionSyntax> GetNewExpressionAsync(Expression
 
             var stringInfo = model.Compilation.GetTypeByMetadataName(typeof(string).FullName);
 
-            if (info.Type.Equals(stringInfo))
+            if (info.Type.Equals(stringInfo, SymbolEqualityComparer.Default))
             {
                 return GetNewExpression(expression, NodeReplacement.Rename("Equals", "Be"));
             }

src/FluentAssertions.Analyzers/Utilities/MemberValidator.cs

@@ -112,7 +112,7 @@ public static ArgumentPredicate IsType(Func<SemanticModel, INamedTypeSymbol> typ
         {
             return (argument, semanticModel) =>
             {
-                return semanticModel.GetTypeInfo(argument.Expression).Type.Equals(typeSelector(semanticModel));
+                return semanticModel.GetTypeInfo(argument.Expression).Type.Equals(typeSelector(semanticModel), SymbolEqualityComparer.Default);
             };
         }
     }

src/FluentAssertions.Analyzers/Utilities/TypesExtensions.cs

@@ -15,8 +15,8 @@ public static bool IsTypeOrConstructedFromTypeOrImplementsType(this INamedTypeSy
         public static bool IsTypeOrConstructedFromTypeOrImplementsType(this INamedTypeSymbol type, INamedTypeSymbol other)
         {
             var abstractType = type.OriginalDefinition;
-            return abstractType.Equals(other)
-                || abstractType.AllInterfaces.Any(@interface => @interface.OriginalDefinition.Equals(other));
+            return abstractType.Equals(other, SymbolEqualityComparer.Default)
+                || abstractType.AllInterfaces.Any(@interface => @interface.OriginalDefinition.Equals(other, SymbolEqualityComparer.Default));
         }
     }
 }