Skip to content

Commit b1b25ba

Browse files
authored
fix NumericShouldBeInRange CodeFix (#258)
1 parent 974e01a commit b1b25ba

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/FluentAssertions.Analyzers.Tests/Tips/NumericTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ public class NumericTests
6262
[AssertionCodeFix(
6363
oldAssertion: "actual.Should().BeLessOrEqualTo(upper).And.BeGreaterOrEqualTo(lower{0});",
6464
newAssertion: "actual.Should().BeInRange(lower, upper{0});")]
65-
[NotImplemented]
66-
public void NumericShouldBeInRange_TestCodeFix(string oldAssertion, string newAssertion) => VerifyCSharpFix<NumericShouldBeApproximatelyCodeFix, NumericShouldBeInRangeAnalyzer>(oldAssertion, newAssertion);
65+
[Implemented]
66+
public void NumericShouldBeInRange_TestCodeFix(string oldAssertion, string newAssertion) => VerifyCSharpFix<NumericShouldBeInRangeCodeFix, NumericShouldBeInRangeAnalyzer>(oldAssertion, newAssertion);
6767

6868
[DataTestMethod]
6969
[AssertionDiagnostic("Math.Abs(expected - actual).Should().BeLessOrEqualTo(delta{0});")]

src/FluentAssertions.Analyzers/Tips/Numerics/NumericShouldBeInRange.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression
6666
if (properties.VisitorName == nameof(NumericShouldBeInRangeAnalyzer.BeGreaterOrEqualToAndBeLessOrEqualToSyntaxVisitor))
6767
{
6868
var removeLess = NodeReplacement.RemoveAndExtractArguments("BeLessOrEqualTo");
69-
var newExpression = GetNewExpression(expression, removeLess);
70-
69+
var newExpression = GetNewExpression(expression, NodeReplacement.RemoveMethodBefore("BeLessOrEqualTo"), removeLess);
70+
7171
var renameGreater = NodeReplacement.RenameAndExtractArguments("BeGreaterOrEqualTo", "BeInRange");
7272
newExpression = GetNewExpression(newExpression, renameGreater);
7373

@@ -78,7 +78,7 @@ protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression
7878
else if (properties.VisitorName == nameof(NumericShouldBeInRangeAnalyzer.BeLessOrEqualToAndBeGreaterOrEqualToSyntaxVisitor))
7979
{
8080
var removeGreater = NodeReplacement.RemoveAndExtractArguments("BeGreaterOrEqualTo");
81-
var newExpression = GetNewExpression(expression, removeGreater);
81+
var newExpression = GetNewExpression(expression, NodeReplacement.RemoveMethodBefore("BeGreaterOrEqualTo"), removeGreater);
8282

8383
var renameLess = NodeReplacement.RenameAndExtractArguments("BeLessOrEqualTo", "BeInRange");
8484
newExpression = GetNewExpression(newExpression, renameLess);

0 commit comments

Comments
 (0)