docs: support multiple failed old assertions in verifier (#344)

* docs: support multiple failed old assertions in verifier

Author: Meir017

src/FluentAssertions.Analyzers.FluentAssertionAnalyzerDocs.Nunit4/Nunit4AnalyzerTests.cs

@@ -1,3 +1,4 @@
+using FluentAssertions;
 using NUnit.Framework;
 using NUnit.Framework.Legacy;
 

src/FluentAssertions.Analyzers.FluentAssertionAnalyzerDocs.Nunit4/Program.cs

@@ -8,7 +8,7 @@ namespace FluentAssertions.Analyzers.FluentAssertionAnalyzerDocs;
 
 public class Program
 {
-    public static Task Main(string[] args) => new Nunit4DocsGenerator().Execute();
+    public static Task Main(string[] args) => ProgramUtils.RunMain<Nunit4DocsGenerator, Nunit4DocsVerifier>(args);
 
     private class Nunit4DocsGenerator : DocsGenerator
     {
@@ -24,4 +24,9 @@ protected override void ResetTestFramework()
             NUnit.Framework.Internal.TestExecutionContext.CurrentContext.CurrentResult.AssertionResults.Clear();
         }
     }
+    private class Nunit4DocsVerifier : DocsVerifier
+    {
+        protected override string TestAttribute => "Test"; // NUnit.Framework.TestAttribute
+        protected override string TestFile => Path.Join(Environment.CurrentDirectory, "Nunit4AnalyzerTests.cs");
+    }
 }

src/FluentAssertions.Analyzers.FluentAssertionAnalyzerDocsGenerator/DocsVerifier.cs

@@ -22,18 +22,18 @@ public async Task Execute()
 
         var issues = new StringBuilder();
 
-        void ValidateAssertions(IEnumerable<ExpressionStatementSyntax> oldAssertions, ExpressionStatementSyntax newAssertion, MethodDeclarationSyntax method, string className)
+        void ValidateAssertions(IEnumerable<ExpressionStatementSyntax> oldAssertions, ExpressionStatementSyntax newAssertion, MethodDeclarationSyntax method)
         {
             foreach (var oldAssertion in oldAssertions)
             {
                 if (!oldAssertion.WithoutTrivia().IsEquivalentTo(newAssertion.WithoutTrivia()))
                 {
-                    issues.AppendLine($"[{className}] {method.Identifier} - actual: {oldAssertion.ToFullString()} expected: {newAssertion.ToFullString()}");
+                    issues.AppendLine($"[{TestFile.Split('\\')[^1]}] {method.Identifier} - actual: {oldAssertion.ToFullString()} expected: {newAssertion.ToFullString()}");
                 }
             }
         }
 
-        Console.WriteLine($"File: {Path.GetFileName(tree.FilePath)}");
+        Console.WriteLine($"File: {Path.GetFileName(TestFile)}");
 
         var root = await tree.GetRootAsync();
         var methods = root.DescendantNodes().OfType<MethodDeclarationSyntax>();
@@ -45,22 +45,26 @@ void ValidateAssertions(IEnumerable<ExpressionStatementSyntax> oldAssertions, Ex
 
             var (oldAssertions, newAssertion) = GetAssertionsFromMethod(method);
 
-            ValidateAssertions(oldAssertions, newAssertion, method, tree.FilePath.Split('\\')[^1]);
+            ValidateAssertions(oldAssertions, newAssertion, method);
 
             if (methodsMap.TryGetValue($"{method.Identifier.Text}_Failure", out var methodFailure))
             {
                 var (oldAssertionsFailure, newAssertionFailure) = GetAssertionsFromMethod(methodFailure);
 
-                ValidateAssertions(oldAssertionsFailure, newAssertionFailure, methodFailure, tree.FilePath.Split('\\')[^1]);
+                ValidateAssertions(oldAssertionsFailure, newAssertionFailure, methodFailure);
             }
 
-            if (methodsMap.TryGetValue($"{method.Identifier.Text}_Failure_OldAssertion", out var testWithFailureOldAssertion)
-            && methodsMap.TryGetValue($"{method.Identifier.Text}_Failure_NewAssertion", out var testWithFailureNewAssertion))
+            if (methodsMap.TryGetValue($"{method.Identifier.Text}_Failure_NewAssertion", out var testWithFailureNewAssertion))
             {
-                var (oldAssertionsFailure, _) = GetAssertionsFromMethod(testWithFailureOldAssertion);
+                var testWithFailureOldAssertions = methodsMap.Where(x => x.Key.StartsWith($"{method.Identifier.Text}_Failure_OldAssertion")).Select(x => x.Value);
+
                 var (_, newAssertionFailure) = GetAssertionsFromMethod(testWithFailureNewAssertion);
+                foreach (var testWithFailureOldAssertion in testWithFailureOldAssertions)
+                {
+                    var (oldAssertionsFailure, _) = GetAssertionsFromMethod(testWithFailureOldAssertion);
 
-                ValidateAssertions(oldAssertionsFailure, newAssertionFailure, testWithFailureOldAssertion, tree.FilePath.Split('\\')[^1]);
+                    ValidateAssertions(oldAssertionsFailure, newAssertionFailure, testWithFailureOldAssertion);
+                }
             }
         }