fixed dictionary analyzers analyzing everything (#69)

* fixed dictionary analyzers analyzing everything

* cleanup

Author: Meir017

src/FluentAssertions.Analyzers.Tests/Tips/SanityTests.cs

@@ -160,5 +160,34 @@ public void StringShouldNotBeEmptyAndShouldNotBeNull_ShouldNotTrigger()
 
             DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(source);
         }
+
+        [TestMethod]
+        [Implemented(Reason = "https://github.com/fluentassertions/fluentassertions.analyzers/issues/65")]
+        public void CustomClass_ShouldNotTrigger_DictionaryAnalyzers()
+        {
+            const string source = @"
+using System.Linq;
+using FluentAssertions;
+using FluentAssertions.Extensions;
+
+namespace TestNamespace
+{
+    class MyDict<TKey, TValue>
+    {
+        public bool ContainsKey(TKey key) => false;
+    }
+    
+    public class Program
+    {
+        public static void Main()
+        {
+            var dict = new MyDict<int, string>();
+            dict.ContainsKey(0).Should().BeTrue();
+        }
+    }
+}";
+
+            DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(source);
+        }
     }
 }

src/FluentAssertions.Analyzers/Tips/Dictionaries/DictionaryAnalyzer.cs

@@ -0,0 +1,11 @@
+using System.Linq;
+using Microsoft.CodeAnalysis;
+
+namespace FluentAssertions.Analyzers
+{
+    public abstract class DictionaryAnalyzer : FluentAssertionsAnalyzer
+    {
+        protected override bool ShouldAnalyzeVariableType(ITypeSymbol type)
+            => type.AllInterfaces.Any(@interface => @interface.Name == "IDictionary");
+    }
+}

src/FluentAssertions.Analyzers/Tips/Dictionaries/DictionaryShouldContainKey.cs

@@ -9,7 +9,7 @@
 namespace FluentAssertions.Analyzers
 {
     [DiagnosticAnalyzer(LanguageNames.CSharp)]
-    public class DictionaryShouldContainKeyAnalyzer : FluentAssertionsAnalyzer
+    public class DictionaryShouldContainKeyAnalyzer : DictionaryAnalyzer
     {
         public const string DiagnosticId = Constants.Tips.Dictionaries.DictionaryShouldContainKey;
         public const string Category = Constants.Tips.Category;

src/FluentAssertions.Analyzers/Tips/Dictionaries/DictionaryShouldContainKeyAndValue.cs

@@ -10,7 +10,7 @@
 namespace FluentAssertions.Analyzers
 {
     [DiagnosticAnalyzer(LanguageNames.CSharp)]
-    public class DictionaryShouldContainKeyAndValueAnalyzer : FluentAssertionsAnalyzer
+    public class DictionaryShouldContainKeyAndValueAnalyzer : DictionaryAnalyzer
     {
         public const string DiagnosticId = Constants.Tips.Dictionaries.DictionaryShouldContainKeyAndValue;
         public const string Category = Constants.Tips.Category;

src/FluentAssertions.Analyzers/Tips/Dictionaries/DictionaryShouldContainPair.cs

@@ -10,7 +10,7 @@
 namespace FluentAssertions.Analyzers
 {
     [DiagnosticAnalyzer(LanguageNames.CSharp)]
-    public class DictionaryShouldContainPairAnalyzer : FluentAssertionsAnalyzer
+    public class DictionaryShouldContainPairAnalyzer : DictionaryAnalyzer
     {
         public const string DiagnosticId = Constants.Tips.Dictionaries.DictionaryShouldContainPair;
         public const string Category = Constants.Tips.Category;

src/FluentAssertions.Analyzers/Tips/Dictionaries/DictionaryShouldContainValue.cs

@@ -9,7 +9,7 @@
 namespace FluentAssertions.Analyzers
 {
     [DiagnosticAnalyzer(LanguageNames.CSharp)]
-    public class DictionaryShouldContainValueAnalyzer : FluentAssertionsAnalyzer
+    public class DictionaryShouldContainValueAnalyzer : DictionaryAnalyzer
     {
         public const string DiagnosticId = Constants.Tips.Dictionaries.DictionaryShouldContainValue;
         public const string Category = Constants.Tips.Category;

src/FluentAssertions.Analyzers/Tips/Dictionaries/DictionaryShouldNotContainKey.cs

@@ -9,7 +9,7 @@
 namespace FluentAssertions.Analyzers
 {
     [DiagnosticAnalyzer(LanguageNames.CSharp)]
-    public class DictionaryShouldNotContainKeyAnalyzer : FluentAssertionsAnalyzer
+    public class DictionaryShouldNotContainKeyAnalyzer : DictionaryAnalyzer
     {
         public const string DiagnosticId = Constants.Tips.Dictionaries.DictionaryShouldNotContainKey;
         public const string Category = Constants.Tips.Category;

src/FluentAssertions.Analyzers/Tips/Dictionaries/DictionaryShouldNotContainValue.cs

@@ -9,7 +9,7 @@
 namespace FluentAssertions.Analyzers
 {
     [DiagnosticAnalyzer(LanguageNames.CSharp)]
-    public class DictionaryShouldNotContainValueAnalyzer : FluentAssertionsAnalyzer
+    public class DictionaryShouldNotContainValueAnalyzer : DictionaryAnalyzer
     {
         public const string DiagnosticId = Constants.Tips.Dictionaries.DictionaryShouldNotContainValue;
         public const string Category = Constants.Tips.Category;

src/FluentAssertions.Analyzers/Utilities/FluentAssertionsAnalyzer.cs

@@ -60,8 +60,8 @@ protected virtual Diagnostic AnalyzeExpression(ExpressionSyntax expression, Sema
 
             if (variableNameExtractor.VariableIdentifierName == null) return null;
             var typeInfo = semanticModel.GetTypeInfo(variableNameExtractor.VariableIdentifierName);
-            if (typeInfo.ConvertedType == null) return null;
-            if (!ShouldAnalyzeVariableType(typeInfo.ConvertedType)) return null;
+            if (typeInfo.Type == null) return null;
+            if (!ShouldAnalyzeVariableType(typeInfo.Type)) return null;
 
             foreach (var visitor in Visitors)
             {