fixed CollectionShouldOnlyHaveUniqueItemsByComparer gives invalid code (#67)

* fixed bug

* added another test for issue

* nit

Author: Meir017

src/FluentAssertions.Analyzers.Tests/Tips/CollectionTests.cs

@@ -387,8 +387,6 @@ public class CollectionTests
         [AssertionDiagnostic("actual.Should().NotBeEmpty().And.NotBeNull({0});")]
         [AssertionDiagnostic("actual.AsEnumerable().Should().NotBeNull().And.NotBeEmpty({0}).And.ToString();")]
         [AssertionDiagnostic("actual.AsEnumerable().Should().NotBeEmpty().And.NotBeNull({0}).And.ToString();")]
-        [AssertionDiagnostic("actual.AsEnumerable().Should().NotBeNull().And.HaveCount(2).And.NotBeEmpty({0}).And.ToString();")]
-        [AssertionDiagnostic("actual.AsEnumerable().Should().NotBeEmpty().And.HaveCount(2).And.NotBeNull({0}).And.ToString();")]
         [Implemented]
         public void CollectionShouldNotBeNullOrEmpty_TestAnalyzer(string assertion) => VerifyCSharpDiagnosticCodeBlock<CollectionShouldNotBeNullOrEmptyAnalyzer>(assertion);
 
@@ -405,12 +403,6 @@ public class CollectionTests
         [AssertionCodeFix(
             oldAssertion: "actual.Should().NotBeEmpty({0}).And.NotBeNull();",
             newAssertion: "actual.Should().NotBeNullOrEmpty({0});")]
-        [AssertionCodeFix(
-            oldAssertion: "actual.AsEnumerable().Should().NotBeNull().And.HaveCount(2).And.NotBeEmpty({0}).And.ToString();",
-            newAssertion: "actual.AsEnumerable().Should().NotBeNullOrEmpty({0}).And.HaveCount(2).And.ToString();")]
-        [AssertionCodeFix(
-            oldAssertion: "actual.AsEnumerable().Should().NotBeEmpty().And.HaveCount(2).And.NotBeNull({0}).And.ToString();",
-            newAssertion: "actual.AsEnumerable().Should().NotBeNullOrEmpty({0}).And.HaveCount(2).And.ToString();")]
         [Implemented]
         public void CollectionShouldNotBeNullOrEmpty_TestCodeFix(string oldAssertion, string newAssertion) => VerifyCSharpFixCodeBlock<CollectionShouldNotBeNullOrEmptyCodeFix, CollectionShouldNotBeNullOrEmptyAnalyzer>(oldAssertion, newAssertion);
 

src/FluentAssertions.Analyzers.Tests/Tips/SanityTests.cs

@@ -122,5 +122,43 @@ public static void Main()
 
             DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(source);
         }    
+
+        [TestMethod]
+        [Implemented(Reason = "https://github.com/fluentassertions/fluentassertions.analyzers/issues/63")]
+        public void Collection_SelectWhereShouldOnlyHaveUniqueItems_ShouldNotTrigger()
+        {
+            const string source = @"
+using System.Linq;
+using FluentAssertions;
+using FluentAssertions.Extensions;
+
+namespace TestNamespace
+{
+    public class Program
+    {
+        public static void Main()
+        {
+            var list = new[] { 1, 2, 3 };
+    
+            list.Select(e => e.ToString())
+                .Where(e => e != string.Empty)
+                .Should()
+                .OnlyHaveUniqueItems();
+        }
+    }
+}";
+            
+            DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(source);
+        }
+
+        [TestMethod]
+        [Implemented(Reason = "https://github.com/fluentassertions/fluentassertions.analyzers/issues/63")]
+        public void StringShouldNotBeEmptyAndShouldNotBeNull_ShouldNotTrigger()
+        {
+            const string assertion = "actual.Should().NotBeEmpty().And.Should().NotBeNull();";
+            var source = GenerateCode.StringAssertion(assertion);
+
+            DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(source);
+        }
     }
-}
+}

src/FluentAssertions.Analyzers/Utilities/FluentAssertionsCSharpSyntaxVisitor.cs

@@ -13,9 +13,9 @@ public class FluentAssertionsCSharpSyntaxVisitor : CSharpSyntaxVisitor
 
         public ImmutableStack<MemberValidator> AllMembers { get; }
         public ImmutableStack<MemberValidator> Members { get; private set; }
-        
+
         public virtual bool IsValid(ExpressionSyntax expression) => Members.IsEmpty;
-        
+
         public virtual ImmutableDictionary<string, string> ToDiagnosticProperties() => ImmutableDictionary<string, string>.Empty
             .Add(Constants.DiagnosticProperties.VisitorName, GetType().Name)
             .ToImmutableDictionary();
@@ -48,6 +48,10 @@ public override void VisitMemberAccessExpression(MemberAccessExpressionSyntax no
                 {
                     Members = Members.Pop();
                 }
+                else
+                {
+                    Members = AllMembers;
+                }
             }
             else if (node.Parent is MemberAccessExpressionSyntax memberAccess && memberAccess.IsKind(SyntaxKind.SimpleMemberAccessExpression)
                 && name == Members.Peek().Name)