-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Revert "packaging: add -L flag to curl for redirect support " #11145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "packaging: add -L flag to curl for redirect support " #11145
Conversation
…ges.flu…" This reverts commit d17e943.
|
Caution Review failedThe pull request is closed. WalkthroughA single curl invocation in the Ubuntu/Dash-based apt path within Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| $SUDO sh <<SCRIPT | ||
| export DEBIAN_FRONTEND=noninteractive | ||
| mkdir -p /usr/share/keyrings/ | ||
| curl -L $RELEASE_KEY | gpg --dearmor > /usr/share/keyrings/fluentbit-keyring.gpg | ||
| curl $RELEASE_KEY | gpg --dearmor > /usr/share/keyrings/fluentbit-keyring.gpg | ||
| cat > /etc/apt/sources.list.d/fluent-bit.list <<EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore redirect handling when fetching Debian key
The Ubuntu/Debian branch now calls curl $RELEASE_KEY | gpg --dearmor without -L. When the key endpoint responds with a 301/302 (common when the CDN rotates or when HTTP→HTTPS redirection is enforced), curl will not follow the redirect and instead output the redirect body. gpg --dearmor will fail, leaving an invalid keyring file and causing apt-get update to error. The earlier change you reverted was added to fix exactly this redirect scenario; dropping -L reintroduces the installation failure for any environment where the key URL redirects.
Useful? React with 👍 / 👎.
Reverts #11137
Summary by CodeRabbit