Skip to content

Conversation

@celalettin1286
Copy link
Contributor

@celalettin1286 celalettin1286 commented Nov 10, 2025

Reverts #11137

Summary by CodeRabbit

  • Chores
    • Modified installation script key retrieval behavior to no longer follow automatic redirects during setup.

@coderabbitai
Copy link

coderabbitai bot commented Nov 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A single curl invocation in the Ubuntu/Dash-based apt path within install.sh was modified to remove the -L flag, disabling automatic HTTP redirect following for the release key retrieval. No other installation logic or repository configuration changes were made.

Changes

Cohort / File(s) Summary
Curl flag removal
install.sh
Removed -L flag from curl command that fetches the release key; curl now uses curl $RELEASE_KEY instead of curl -L $RELEASE_KEY

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • The change is a single flag removal from one command, but verifying the rationale is important:
    • Confirm whether the release key URL actually redirects
    • Clarify the intention behind removing redirect-following behavior
    • Verify this change does not cause key retrieval failures in practice

Possibly related PRs

Suggested reviewers

  • niedbalski
  • patrick-stephens

Poem

🐰 A dash of curl, a flag removed so neat,
Redirects no longer lead our key to greet,
Swift and direct, the path stays true,
Installation scripts, refreshed anew! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-11137-fix/install-script-curl-redirect

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d17e943 and 79f4b55.

📒 Files selected for processing (1)
  • install.sh (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 136 to 140
$SUDO sh <<SCRIPT
export DEBIAN_FRONTEND=noninteractive
mkdir -p /usr/share/keyrings/
curl -L $RELEASE_KEY | gpg --dearmor > /usr/share/keyrings/fluentbit-keyring.gpg
curl $RELEASE_KEY | gpg --dearmor > /usr/share/keyrings/fluentbit-keyring.gpg
cat > /etc/apt/sources.list.d/fluent-bit.list <<EOF

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore redirect handling when fetching Debian key

The Ubuntu/Debian branch now calls curl $RELEASE_KEY | gpg --dearmor without -L. When the key endpoint responds with a 301/302 (common when the CDN rotates or when HTTP→HTTPS redirection is enforced), curl will not follow the redirect and instead output the redirect body. gpg --dearmor will fail, leaving an invalid keyring file and causing apt-get update to error. The earlier change you reverted was added to fix exactly this redirect scenario; dropping -L reintroduces the installation failure for any environment where the key URL redirects.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants