Pass output stream errors through with error (also includes test)

Author: rhodgkins

lib/processor.js

@@ -490,7 +490,9 @@ module.exports = function(proto) {
 
             outputStream.target.on('error', function(err) {
               self.logger.debug('Output stream error, killing ffmpgeg process');
-              emitEnd(new Error('Output stream error: ' + err.message), stdoutRing.get(), stderrRing.get());
+              var reportingErr = new Error('Output stream error: ' + err.message);
+              reportingErr.outputStreamError = err;
+              emitEnd(reportingErr, stdoutRing.get(), stderrRing.get());
               ffmpegProc.kill();
             });
           }

test/processor.test.js

@@ -953,6 +953,44 @@ describe('Processor', function() {
         new FfmpegCommand().writeToStream({end: true});
       }).should.throw(/PassThrough stream is not supported on node v0.8/);
     });
+    
+    it('should pass output stream errors through to error handler', function(done) {
+		
+		const writeError = new Error('Write Error')
+      const outstream = new (require('stream').Writable)({
+        write(chunk, encoding, callback) {
+          callback(writeError)
+		  }
+      })
+      
+      const command = this.getCommand({ source: this.testfile, logger: testhelper.logger })
+
+      let startCalled = false
+      const self = this
+      
+      command
+          .usingPreset('divx')
+          .on('start', function() {
+          	startCalled = true
+            command.ffmpegProc.on('exit', function() {
+					done()
+            })
+          })
+          .on('error', function(err, stdout, stderr) {
+            self.saveOutput(stdout, stderr)
+            startCalled.should.be.true()
+            assert.ok(err)
+            err.message.indexOf('Output stream error: ').should.equal(0)
+			   assert.strictEqual(err.outputStreamError, writeError)
+          })
+          .on('end', function(stdout, stderr) {
+            console.log('end was called, expected a error')
+            testhelper.logOutput(stdout, stderr)
+            assert.ok(false)
+            done()
+          })
+          .writeToStream(outstream)
+    })
   });
 
   describe('Outputs', function() {