-
Notifications
You must be signed in to change notification settings - Fork 10
[DF-Shape] Use a set range domain for the column names of data frames #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OliverGerstl
merged 15 commits into
main
from
1997-df-shape-use-a-set-range-domain-for-the-column-names-of-data-frames
Nov 27, 2025
Merged
[DF-Shape] Use a set range domain for the column names of data frames #2032
OliverGerstl
merged 15 commits into
main
from
1997-df-shape-use-a-set-range-domain-for-the-column-names-of-data-frames
Nov 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
OliverGerstl
commented
Nov 18, 2025
- Add a set range domain to track a minimum set and maximum set of values of a specific type (e.g. strings)
- Integrate the set range domain as column names domain for the data frame shape domain
- Adapt the tests to the new column names domain
EagleoutIce
reviewed
Nov 20, 2025
Member
EagleoutIce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a general quick readover for now, I had no time to actually read and follow all of the lattice op impls
…-column-names-of-data-frames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.