Improve unseeded randomness rule to include potential unreachability check #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Member
Author
|
Hmm I don't know if this is even a potential valid solution at all, but atm it doesn't account for something like if (2 < 1) { set.seed(17) }
if (1 < 0) { runif(1) }because both are non-exhaustive branch coverages, but not of the same branches, so .. bleh |
Member
Author
|
yea i dunno i can't figure out how to do this correctly @EagleoutIce :( |
EagleoutIce
reviewed
Nov 11, 2025
…-seed-function-potentially-unreachable
EagleoutIce
approved these changes
Nov 24, 2025
…-detected-if-seed-function-potentially-unreachable' into 2015-bug-unseeded-randomness-not-detected-if-seed-function-potentially-unreachable
EagleoutIce
deleted the
2015-bug-unseeded-randomness-not-detected-if-seed-function-potentially-unreachable
branch
Member
|
This pull request is included in v2.6.3 (see Release v2.6.3 (Doc, Refined Analyzer, Caching, and Perf)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.