fix a signal creation bug

robert-gurol-ebcont · robert-gurol-ebcont · commit 68d447ec9d28 · 2024-07-29T17:30:33.000+02:00
fix a bug where for the second process
you start, signal processing would happen differently
(e.g. scope would always be null)
diff --git a/modules/flowable-engine/src/main/java/org/flowable/engine/impl/dynamic/AbstractDynamicStateManager.java b/modules/flowable-engine/src/main/java/org/flowable/engine/impl/dynamic/AbstractDynamicStateManager.java
@@ -1533,7 +1533,6 @@ protected void processCreatedEventSubProcess(EventSubProcess eventSubProcess, Ex
                         Signal signal = null;
                         if (bpmnModel.containsSignalId(signalEventDefinition.getSignalRef())) {
                             signal = bpmnModel.getSignal(signalEventDefinition.getSignalRef());
-                            signalEventDefinition.setSignalRef(signal.getName());
                         }
 
                         ExecutionEntity signalExecution = processEngineConfiguration.getExecutionEntityManager().createChildExecution(eventSubProcessExecution.getParent());
diff --git a/modules/flowable-engine/src/main/java/org/flowable/engine/impl/util/ProcessInstanceHelper.java b/modules/flowable-engine/src/main/java/org/flowable/engine/impl/util/ProcessInstanceHelper.java
@@ -455,7 +455,6 @@ protected void handleSignalEventSubscription(EventDefinition eventDefinition, St
         Signal signal = null;
         if (bpmnModel.containsSignalId(signalEventDefinition.getSignalRef())) {
             signal = bpmnModel.getSignal(signalEventDefinition.getSignalRef());
-            signalEventDefinition.setSignalRef(signal.getName());
         }
 
         ExecutionEntity signalExecution = processEngineConfiguration.getExecutionEntityManager().createChildExecution(parentExecution);

Original file line number	Diff line number	Diff line change
`@@ -1533,7 +1533,6 @@ protected void processCreatedEventSubProcess(EventSubProcess eventSubProcess, Ex`
`1533`	`1533`	`Signal signal = null;`
`1534`	`1534`	`if (bpmnModel.containsSignalId(signalEventDefinition.getSignalRef())) {`
`1535`	`1535`	`signal = bpmnModel.getSignal(signalEventDefinition.getSignalRef());`
`1536`		`- signalEventDefinition.setSignalRef(signal.getName());`
`1537`	`1536`	`}`
`1538`	`1537`
`1539`	`1538`	`ExecutionEntity signalExecution = processEngineConfiguration.getExecutionEntityManager().createChildExecution(eventSubProcessExecution.getParent());`
Original file line number	Diff line number	Diff line change
`@@ -455,7 +455,6 @@ protected void handleSignalEventSubscription(EventDefinition eventDefinition, St`
`455`	`455`	`Signal signal = null;`
`456`	`456`	`if (bpmnModel.containsSignalId(signalEventDefinition.getSignalRef())) {`
`457`	`457`	`signal = bpmnModel.getSignal(signalEventDefinition.getSignalRef());`
`458`		`- signalEventDefinition.setSignalRef(signal.getName());`
`459`	`458`	`}`
`460`	`459`
`461`	`460`	`ExecutionEntity signalExecution = processEngineConfiguration.getExecutionEntityManager().createChildExecution(parentExecution);`