Merge pull request #15 from flow-build/feature/DAT-478

refactor: handle external and internal actions

Author: wallace-sf

__tests__/store.ts

@@ -1,7 +1,7 @@
 import { configureStore } from '@reduxjs/toolkit';
 
-import { workflowManagerReducer } from '../src';
+import { workflowManagerInternalReducer } from '../src';
 
 export const store = configureStore({
-  reducer: { workflowManagerReducer },
+  reducer: { workflowManagerInternalReducer },
 });

package.json

@@ -9,6 +9,12 @@
     "name": "Wallace Ferreira",
     "url": "https://github.com/wallace-sf"
   },
+  "contributors": [
+    {
+      "name": "Leonardo Abe",
+      "url": "https://github.com/leonardoabe"
+    }
+  ],
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",
   "keywords": [
@@ -122,4 +128,4 @@
       "yarn fmt"
     ]
   }
-}
+}

src/WorkflowManagerConfig.ts

@@ -4,7 +4,10 @@ import { matches, exec } from 'mqtt-pattern';
 import invariant from 'tiny-warning';
 
 import { createWorkflowAction } from './ducks/utils';
-import { addProcess, removeProcess } from './ducks/workflowManager.slice';
+import {
+  addProcess,
+  removeProcess,
+} from './ducks/workflowManagerInternal.slice';
 import { WorkflowManagerConfigProps, IClientUnsubscribeOptions } from './types';
 import {
   ERROR_MESSAGES,

src/ducks/index.ts

@@ -1 +1,2 @@
-export { default as workflowManagerReducer } from './workflowManager.slice';
+export { default as workflowManagerInternalReducer } from './workflowManagerInternal.slice';
+export const prefix = '@@workflowManagerExternal';

src/ducks/utils.ts

@@ -1,12 +1,12 @@
 import { createAction } from '@reduxjs/toolkit';
 
-import { prefix } from './workflowManager.slice';
+import { prefix } from '.';
 
 export const createWorkflowAction = (
   workflowAction: string,
   payload: Record<string, unknown>,
 ) => {
-  const actionName = `${prefix}/external/${workflowAction}`;
+  const actionName = `${prefix}/${workflowAction}`;
 
   return createAction<typeof payload>(actionName)(payload);
 };

src/ducks/workflowManager.slice.ts renamed to src/ducks/workflowManagerInternal.slice.ts

@@ -3,16 +3,16 @@ import { createSlice, PayloadAction } from '@reduxjs/toolkit';
 import { WorkflowManagerState } from './types';
 
 const Types = {
-  addProcess: 'internal/ADD_PROCESS',
-  removeProcess: 'internal/REMOVE_PROCESS',
+  addProcess: 'ADD_PROCESS',
+  removeProcess: 'REMOVE_PROCESS',
 };
 
 const initialState: WorkflowManagerState = {
   activeProcesses: [],
 };
 
-export const workflowManagerSlice = createSlice({
-  name: '@@workflowManager',
+export const workflowManagerInternalSlice = createSlice({
+  name: '@@workflowManagerInternal',
   initialState,
   reducers: {
     [Types.addProcess]: (state, action: PayloadAction<string>) => {
@@ -26,8 +26,9 @@ export const workflowManagerSlice = createSlice({
   },
 });
 
-export const prefix = workflowManagerSlice.name;
-export const addProcess = workflowManagerSlice.actions[Types.addProcess];
-export const removeProcess = workflowManagerSlice.actions[Types.removeProcess];
+export const addProcess =
+  workflowManagerInternalSlice.actions[Types.addProcess];
+export const removeProcess =
+  workflowManagerInternalSlice.actions[Types.removeProcess];
 
-export default workflowManagerSlice.reducer;
+export default workflowManagerInternalSlice.reducer;