Adding permanent flag to deleteSubject Request

Author: tPl0ch

src/Requests.php

@@ -185,13 +185,16 @@ public static function validateSchemaId($schemaId): string
 
     /**
      * @param string $subjectName
+     * @param bool $permanent
      * @return RequestInterface
      */
-    public static function deleteSubjectRequest(string $subjectName): RequestInterface
+    public static function deleteSubjectRequest(string $subjectName, bool $permanent): RequestInterface
     {
+        $query = $permanent ? "true" : "false";
+
         return new Request(
             'DELETE',
-            Utils::uriFor("/subjects/$subjectName"),
+            Utils::uriFor("/subjects/$subjectName?permanent=$query"),
             Constants::ACCEPT_HEADER
         );
     }

test/RequestsTest.php

@@ -364,10 +364,10 @@ public function it_should_validate_valid_schema_ids(): void
      */
     public function it_should_produce_a_valid_subject_deletion_request(): void
     {
-        $request = Requests::deleteSubjectRequest('test');
+        $request = Requests::deleteSubjectRequest('test', false);
 
         self::assertEquals('DELETE', $request->getMethod());
-        self::assertEquals('subjects/test', $request->getUri());
+        self::assertEquals('subjects/test?permanent=false', $request->getUri());
         self::assertEquals([Constants::ACCEPT => [Constants::ACCEPT_HEADER[Constants::ACCEPT]]], $request->getHeaders());
     }