[RELEASE][HOTFIX] Correct Stream processing with newer Guzzle versions (#14)

* [FX] Also add throwing values in rejection callbacks

* [FX] Also add throwing values in rejection callbacks for CachedRegistry

* [FX] Use correct stream string access in `ExceptionMap`

Author: tPl0ch

src/Exception/ExceptionMap.php

@@ -63,18 +63,29 @@ private function guardAgainstMissingResponse(RequestException $exception): Respo
 
     private function guardAgainstMissingErrorCode(ResponseInterface $response): array
     {
-        $decodedBody = \GuzzleHttp\json_decode($response->getBody()->getContents(), true);
-
-        if (!array_key_exists(self::ERROR_CODE_FIELD_NAME, $decodedBody)) {
+        try {
+            $decodedBody = \GuzzleHttp\json_decode((string) $response->getBody(), true);
+
+            if (!\array_key_exists(self::ERROR_CODE_FIELD_NAME, $decodedBody)) {
+                throw new \RuntimeException(
+                    sprintf(
+                        'Invalid message body received - cannot find "error_code" field in response body "%s"',
+                        (string) $response->getBody()
+                    )
+                );
+            }
+
+            return $decodedBody;
+        } catch (\Exception $e) {
             throw new \RuntimeException(
-                sprintf(
+                \sprintf(
                     'Invalid message body received - cannot find "error_code" field in response body "%s"',
-                    $response->getBody()->getContents()
-                )
+                    (string) $response->getBody()
+                ),
+                $e->getCode(),
+                $e
             );
         }
-
-        return $decodedBody;
     }
 
     private function mapErrorCodeToException($errorCode, $errorMessage)

src/Registry/BlockingRegistry.php

@@ -109,14 +109,14 @@ public function latestVersion(string $subject, callable $requestCallback = null)
      */
     private function addExceptionThrowCallableToPromise(PromiseInterface $promise): PromiseInterface
     {
-        return $promise->then(
-            function ($value) {
-                if ($value instanceof \Exception) {
-                    throw $value;
-                }
-
-                return $value;
+        $throwingValueFunction = function ($value) {
+            if ($value instanceof \Exception) {
+                throw $value;
             }
-        );
+
+            return $value;
+        };
+
+        return $promise->then($throwingValueFunction, $throwingValueFunction);
     }
 }

src/Registry/CachedRegistry.php

@@ -169,16 +169,16 @@ public function latestVersion(string $subject, callable $requestCallback = null)
         return $this->registry->latestVersion($subject, $requestCallback);
     }
 
-
-    /**
-     * {@inheritdoc}
-     */
     private function applyValueHandlers($value, callable $promiseHandler, callable $valueHandler)
     {
         if ($value instanceof PromiseInterface) {
             return $promiseHandler($value);
         }
 
+        if ($value instanceof \Exception) {
+            throw $value;
+        }
+
         return $valueHandler($value);
     }