Adding permanent flag to deleteSubjectVersionRequest Request

Author: tPl0ch

src/Requests.php

@@ -202,13 +202,16 @@ public static function deleteSubjectRequest(string $subjectName, bool $permanent
     /**
      * @param string $subjectName
      * @param string $versionId
+     * @param bool $permanent
      * @return RequestInterface
      */
-    public static function deleteSubjectVersionRequest(string $subjectName, string $versionId): RequestInterface
+    public static function deleteSubjectVersionRequest(string $subjectName, string $versionId, bool $permanent = false): RequestInterface
     {
+        $query = $permanent ? "true" : "false";
+
         return new Request(
             'DELETE',
-            Utils::uriFor("/subjects/$subjectName/versions/$versionId"),
+            Utils::uriFor("/subjects/$subjectName/versions/$versionId?permanent=$query"),
             Constants::ACCEPT_HEADER
         );
     }

test/RequestsTest.php

@@ -376,16 +376,28 @@ public function it_should_produce_a_valid_subject_deletion_request(): void
      */
     public function it_should_produce_a_valid_subject_version_deletion_request(): void
     {
+        $request = Requests::deleteSubjectVersionRequest('test', Constants::VERSION_LATEST, false);
+
+        self::assertEquals('DELETE', $request->getMethod());
+        self::assertEquals('/subjects/test/versions/latest?permanent=false', $request->getUri());
+        self::assertEquals([Constants::ACCEPT => [Constants::ACCEPT_HEADER[Constants::ACCEPT]]], $request->getHeaders());
+
         $request = Requests::deleteSubjectVersionRequest('test', Constants::VERSION_LATEST);
 
         self::assertEquals('DELETE', $request->getMethod());
-        self::assertEquals('subjects/test/versions/latest', $request->getUri());
+        self::assertEquals('subjects/test/versions/latest?permanent=false', $request->getUri());
+        self::assertEquals([Constants::ACCEPT => [Constants::ACCEPT_HEADER[Constants::ACCEPT]]], $request->getHeaders());
+
+        $request = Requests::deleteSubjectVersionRequest('test', '5', false);
+
+        self::assertEquals('DELETE', $request->getMethod());
+        self::assertEquals('/subjects/test/versions/5?permanent=false', $request->getUri());
         self::assertEquals([Constants::ACCEPT => [Constants::ACCEPT_HEADER[Constants::ACCEPT]]], $request->getHeaders());
 
-        $request = Requests::deleteSubjectVersionRequest('test', '5');
+        $request = Requests::deleteSubjectVersionRequest('test', '5', true);
 
         self::assertEquals('DELETE', $request->getMethod());
-        self::assertEquals('subjects/test/versions/5', $request->getUri());
+        self::assertEquals('subjects/test/versions/5?permanent=true', $request->getUri());
         self::assertEquals([Constants::ACCEPT => [Constants::ACCEPT_HEADER[Constants::ACCEPT]]], $request->getHeaders());
     }
 }