Add default value to permanent flag in deleteSubjectRequest

Author: tPl0ch

src/Requests.php

@@ -188,7 +188,7 @@ public static function validateSchemaId($schemaId): string
      * @param bool $permanent
      * @return RequestInterface
      */
-    public static function deleteSubjectRequest(string $subjectName, bool $permanent): RequestInterface
+    public static function deleteSubjectRequest(string $subjectName, bool $permanent = false): RequestInterface
     {
         $query = $permanent ? "true" : "false";
 

test/RequestsTest.php

@@ -333,11 +333,23 @@ public function it_should_validate_valid_schema_ids(): void
      */
     public function it_should_produce_a_valid_subject_deletion_request(): void
     {
+        $request = Requests::deleteSubjectRequest('test');
+
+        self::assertEquals('DELETE', $request->getMethod());
+        self::assertEquals('/subjects/test?permanent=false', $request->getUri());
+        self::assertEquals([Constants::ACCEPT => [Constants::ACCEPT_HEADER[Constants::ACCEPT]]], $request->getHeaders());
+
         $request = Requests::deleteSubjectRequest('test', false);
 
         self::assertEquals('DELETE', $request->getMethod());
         self::assertEquals('/subjects/test?permanent=false', $request->getUri());
         self::assertEquals([Constants::ACCEPT => [Constants::ACCEPT_HEADER[Constants::ACCEPT]]], $request->getHeaders());
+
+        $request = Requests::deleteSubjectRequest('test', true);
+
+        self::assertEquals('DELETE', $request->getMethod());
+        self::assertEquals('/subjects/test?permanent=true', $request->getUri());
+        self::assertEquals([Constants::ACCEPT => [Constants::ACCEPT_HEADER[Constants::ACCEPT]]], $request->getHeaders());
     }
 
     /**