Skip to content

Commit 8c718e5

Browse files
petrochenkovpetrochenkov
committed
ast: Standardize visiting order for attributes and node IDs
1 parent 58fc27f commit 8c718e5

File tree

3 files changed

+61
-61
lines changed

3 files changed

+61
-61
lines changed

‎tests/ui/cfg_attr_cargo_clippy.stderr‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
error: `feature = "cargo-clippy"` was replaced by `clippy`
2-
--> tests/ui/cfg_attr_cargo_clippy.rs:5:12
2+
--> tests/ui/cfg_attr_cargo_clippy.rs:3:13
33
|
4-
LL | #[cfg_attr(feature = "cargo-clippy", derive(Debug))]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy`
4+
LL | #![cfg_attr(feature = "cargo-clippy", doc = "a")]
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy`
66
|
77
= note: `-D clippy::deprecated-clippy-cfg-attr` implied by `-D warnings`
88
= help: to override `-D warnings` add `#[allow(clippy::deprecated_clippy_cfg_attr)]`
99

10+
error: `feature = "cargo-clippy"` was replaced by `clippy`
11+
--> tests/ui/cfg_attr_cargo_clippy.rs:5:12
12+
|
13+
LL | #[cfg_attr(feature = "cargo-clippy", derive(Debug))]
14+
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy`
15+
1016
error: `feature = "cargo-clippy"` was replaced by `clippy`
1117
--> tests/ui/cfg_attr_cargo_clippy.rs:6:16
1218
|
@@ -37,11 +43,5 @@ error: `feature = "cargo-clippy"` was replaced by `clippy`
3743
LL | #[cfg(all(feature = "cargo-clippy"))]
3844
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy`
3945

40-
error: `feature = "cargo-clippy"` was replaced by `clippy`
41-
--> tests/ui/cfg_attr_cargo_clippy.rs:3:13
42-
|
43-
LL | #![cfg_attr(feature = "cargo-clippy", doc = "a")]
44-
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy`
45-
4646
error: aborting due to 7 previous errors
4747

‎tests/ui/tabs_in_doc_comments.stderr‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,53 +1,53 @@
11
error: using tabs in doc comments is not recommended
2-
--> tests/ui/tabs_in_doc_comments.rs:10:9
2+
--> tests/ui/tabs_in_doc_comments.rs:6:5
33
|
4-
LL | /// - First String:
5-
| ^^^^ help: consider using four spaces per tab
4+
LL | /// - first one
5+
| ^^^^ help: consider using four spaces per tab
66
|
77
= note: `-D clippy::tabs-in-doc-comments` implied by `-D warnings`
88
= help: to override `-D warnings` add `#[allow(clippy::tabs_in_doc_comments)]`
99

1010
error: using tabs in doc comments is not recommended
11-
--> tests/ui/tabs_in_doc_comments.rs:11:9
11+
--> tests/ui/tabs_in_doc_comments.rs:6:13
1212
|
13-
LL | /// - needs to be inside here
14-
| ^^^^^^^^ help: consider using four spaces per tab
13+
LL | /// - first one
14+
| ^^^^^^^^ help: consider using four spaces per tab
1515

1616
error: using tabs in doc comments is not recommended
17-
--> tests/ui/tabs_in_doc_comments.rs:14:9
17+
--> tests/ui/tabs_in_doc_comments.rs:7:5
1818
|
19-
LL | /// - Second String:
20-
| ^^^^ help: consider using four spaces per tab
19+
LL | /// - second one
20+
| ^^^^ help: consider using four spaces per tab
2121

2222
error: using tabs in doc comments is not recommended
23-
--> tests/ui/tabs_in_doc_comments.rs:15:9
23+
--> tests/ui/tabs_in_doc_comments.rs:7:14
2424
|
25-
LL | /// - needs to be inside here
26-
| ^^^^^^^^ help: consider using four spaces per tab
25+
LL | /// - second one
26+
| ^^^^ help: consider using four spaces per tab
2727

2828
error: using tabs in doc comments is not recommended
29-
--> tests/ui/tabs_in_doc_comments.rs:6:5
29+
--> tests/ui/tabs_in_doc_comments.rs:10:9
3030
|
31-
LL | /// - first one
32-
| ^^^^ help: consider using four spaces per tab
31+
LL | /// - First String:
32+
| ^^^^ help: consider using four spaces per tab
3333

3434
error: using tabs in doc comments is not recommended
35-
--> tests/ui/tabs_in_doc_comments.rs:6:13
35+
--> tests/ui/tabs_in_doc_comments.rs:11:9
3636
|
37-
LL | /// - first one
38-
| ^^^^^^^^ help: consider using four spaces per tab
37+
LL | /// - needs to be inside here
38+
| ^^^^^^^^ help: consider using four spaces per tab
3939

4040
error: using tabs in doc comments is not recommended
41-
--> tests/ui/tabs_in_doc_comments.rs:7:5
41+
--> tests/ui/tabs_in_doc_comments.rs:14:9
4242
|
43-
LL | /// - second one
44-
| ^^^^ help: consider using four spaces per tab
43+
LL | /// - Second String:
44+
| ^^^^ help: consider using four spaces per tab
4545

4646
error: using tabs in doc comments is not recommended
47-
--> tests/ui/tabs_in_doc_comments.rs:7:14
47+
--> tests/ui/tabs_in_doc_comments.rs:15:9
4848
|
49-
LL | /// - second one
50-
| ^^^^ help: consider using four spaces per tab
49+
LL | /// - needs to be inside here
50+
| ^^^^^^^^ help: consider using four spaces per tab
5151

5252
error: aborting due to 8 previous errors
5353

‎tests/ui/unnecessary_clippy_cfg.stderr‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,61 +1,61 @@
11
error: no need to put clippy lints behind a `clippy` cfg
2-
--> tests/ui/unnecessary_clippy_cfg.rs:13:1
2+
--> tests/ui/unnecessary_clippy_cfg.rs:4:1
33
|
4-
LL | #[cfg_attr(clippy, deny(clippy::non_minimal_cfg))]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `#[deny(clippy::non_minimal_cfg)]`
4+
LL | #![cfg_attr(clippy, deny(clippy::non_minimal_cfg))]
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `#![deny(clippy::non_minimal_cfg)]`
66
|
77
= note: `-D clippy::unnecessary-clippy-cfg` implied by `-D warnings`
88
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_clippy_cfg)]`
99

1010
error: no need to put clippy lints behind a `clippy` cfg
11-
--> tests/ui/unnecessary_clippy_cfg.rs:15:36
11+
--> tests/ui/unnecessary_clippy_cfg.rs:6:37
1212
|
13-
LL | #[cfg_attr(clippy, deny(dead_code, clippy::non_minimal_cfg))]
14-
| ^^^^^^^^^^^^^^^^^^^^^^^
13+
LL | #![cfg_attr(clippy, deny(dead_code, clippy::non_minimal_cfg))]
14+
| ^^^^^^^^^^^^^^^^^^^^^^^
1515
|
16-
= note: write instead: `#[deny(clippy::non_minimal_cfg)]`
16+
= note: write instead: `#![deny(clippy::non_minimal_cfg)]`
1717

1818
error: no need to put clippy lints behind a `clippy` cfg
19-
--> tests/ui/unnecessary_clippy_cfg.rs:17:36
19+
--> tests/ui/unnecessary_clippy_cfg.rs:8:37
2020
|
21-
LL | #[cfg_attr(clippy, deny(dead_code, clippy::non_minimal_cfg))]
22-
| ^^^^^^^^^^^^^^^^^^^^^^^
21+
LL | #![cfg_attr(clippy, deny(dead_code, clippy::non_minimal_cfg))]
22+
| ^^^^^^^^^^^^^^^^^^^^^^^
2323
|
24-
= note: write instead: `#[deny(clippy::non_minimal_cfg)]`
24+
= note: write instead: `#![deny(clippy::non_minimal_cfg)]`
2525

2626
error: no need to put clippy lints behind a `clippy` cfg
27-
--> tests/ui/unnecessary_clippy_cfg.rs:19:1
27+
--> tests/ui/unnecessary_clippy_cfg.rs:10:1
2828
|
29-
LL | #[cfg_attr(clippy, deny(clippy::non_minimal_cfg))]
30-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `#[deny(clippy::non_minimal_cfg)]`
29+
LL | #![cfg_attr(clippy, deny(clippy::non_minimal_cfg))]
30+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `#![deny(clippy::non_minimal_cfg)]`
3131

3232
error: no need to put clippy lints behind a `clippy` cfg
33-
--> tests/ui/unnecessary_clippy_cfg.rs:4:1
33+
--> tests/ui/unnecessary_clippy_cfg.rs:13:1
3434
|
35-
LL | #![cfg_attr(clippy, deny(clippy::non_minimal_cfg))]
36-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `#![deny(clippy::non_minimal_cfg)]`
35+
LL | #[cfg_attr(clippy, deny(clippy::non_minimal_cfg))]
36+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `#[deny(clippy::non_minimal_cfg)]`
3737

3838
error: no need to put clippy lints behind a `clippy` cfg
39-
--> tests/ui/unnecessary_clippy_cfg.rs:6:37
39+
--> tests/ui/unnecessary_clippy_cfg.rs:15:36
4040
|
41-
LL | #![cfg_attr(clippy, deny(dead_code, clippy::non_minimal_cfg))]
42-
| ^^^^^^^^^^^^^^^^^^^^^^^
41+
LL | #[cfg_attr(clippy, deny(dead_code, clippy::non_minimal_cfg))]
42+
| ^^^^^^^^^^^^^^^^^^^^^^^
4343
|
44-
= note: write instead: `#![deny(clippy::non_minimal_cfg)]`
44+
= note: write instead: `#[deny(clippy::non_minimal_cfg)]`
4545

4646
error: no need to put clippy lints behind a `clippy` cfg
47-
--> tests/ui/unnecessary_clippy_cfg.rs:8:37
47+
--> tests/ui/unnecessary_clippy_cfg.rs:17:36
4848
|
49-
LL | #![cfg_attr(clippy, deny(dead_code, clippy::non_minimal_cfg))]
50-
| ^^^^^^^^^^^^^^^^^^^^^^^
49+
LL | #[cfg_attr(clippy, deny(dead_code, clippy::non_minimal_cfg))]
50+
| ^^^^^^^^^^^^^^^^^^^^^^^
5151
|
52-
= note: write instead: `#![deny(clippy::non_minimal_cfg)]`
52+
= note: write instead: `#[deny(clippy::non_minimal_cfg)]`
5353

5454
error: no need to put clippy lints behind a `clippy` cfg
55-
--> tests/ui/unnecessary_clippy_cfg.rs:10:1
55+
--> tests/ui/unnecessary_clippy_cfg.rs:19:1
5656
|
57-
LL | #![cfg_attr(clippy, deny(clippy::non_minimal_cfg))]
58-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `#![deny(clippy::non_minimal_cfg)]`
57+
LL | #[cfg_attr(clippy, deny(clippy::non_minimal_cfg))]
58+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `#[deny(clippy::non_minimal_cfg)]`
5959

6060
error: duplicated attribute
6161
--> tests/ui/unnecessary_clippy_cfg.rs:8:26

0 commit comments

Comments
 (0)