submodules: update clippy from be5d17f to 868f168

matthiaskrgr · matthiaskrgr · commit 3ba9ac912538 · 2019-06-18T15:43:41.000+02:00
Changes: ```` rustup rust-lang/rust#61836 fix suggestion for floating points inequality ````
diff --git a/clippy_lints/src/derive.rs b/clippy_lints/src/derive.rs
@@ -114,7 +114,7 @@ fn check_hash_peq<'a, 'tcx>(
                         cx, DERIVE_HASH_XOR_EQ, span,
                         mess,
                         |db| {
-                        if let Some(node_id) = cx.tcx.hir().as_local_node_id(impl_id) {
+                        if let Some(node_id) = cx.tcx.hir().as_local_hir_id(impl_id) {
                             db.span_note(
                                 cx.tcx.hir().span(node_id),
                                 "`PartialEq` implemented here"
diff --git a/clippy_lints/src/enum_glob_use.rs b/clippy_lints/src/enum_glob_use.rs
@@ -32,7 +32,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for EnumGlobUse {
         let map = cx.tcx.hir();
         // only check top level `use` statements
         for item in &m.item_ids {
-            self.lint_item(cx, map.expect_item(map.hir_to_node_id(item.id)));
+            self.lint_item(cx, map.expect_item(item.id));
         }
     }
 }
diff --git a/clippy_lints/src/escape.rs b/clippy_lints/src/escape.rs
@@ -94,7 +94,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for BoxedLocal {
             span_lint(
                 cx,
                 BOXED_LOCAL,
-                cx.tcx.hir().span_by_hir_id(node),
+                cx.tcx.hir().span(node),
                 "local variable doesn't need to be boxed here",
             );
         }
diff --git a/clippy_lints/src/lifetimes.rs b/clippy_lints/src/lifetimes.rs
@@ -346,7 +346,7 @@ impl<'a, 'tcx> Visitor<'tcx> for RefVisitor<'a, 'tcx> {
             },
             TyKind::Def(item, _) => {
                 let map = self.cx.tcx.hir();
-                if let ItemKind::Existential(ref exist_ty) = map.expect_item(map.hir_to_node_id(item.id)).node {
+                if let ItemKind::Existential(ref exist_ty) = map.expect_item(item.id).node {
                     for bound in &exist_ty.bounds {
                         if let GenericBound::Outlives(_) = *bound {
                             self.record(&None);
diff --git a/clippy_lints/src/methods/mod.rs b/clippy_lints/src/methods/mod.rs
@@ -947,7 +947,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Methods {
         }
         let name = implitem.ident.name.as_str();
         let parent = cx.tcx.hir().get_parent_item(implitem.hir_id);
-        let item = cx.tcx.hir().expect_item_by_hir_id(parent);
+        let item = cx.tcx.hir().expect_item(parent);
         let def_id = cx.tcx.hir().local_def_id_from_hir_id(item.hir_id);
         let ty = cx.tcx.type_of(def_id);
         if_chain! {
@@ -1070,7 +1070,7 @@ fn lint_or_fun_call<'a, 'tcx: 'a>(
 
             if call_found {
                 // don't lint for constant values
-                let owner_def = self.cx.tcx.hir().get_parent_did_by_hir_id(expr.hir_id);
+                let owner_def = self.cx.tcx.hir().get_parent_did(expr.hir_id);
                 let promotable = self
                     .cx
                     .tcx
diff --git a/clippy_lints/src/misc.rs b/clippy_lints/src/misc.rs
@@ -387,7 +387,11 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MiscLints {
                         db.span_suggestion(
                             expr.span,
                             "consider comparing them within some error",
-                            format!("({}).abs() < error", lhs - rhs),
+                            format!(
+                                "({}).abs() {} error",
+                                lhs - rhs,
+                                if op == BinOpKind::Eq { '<' } else { '>' }
+                            ),
                             Applicability::MachineApplicable, // snippet
                         );
                         db.span_note(expr.span, "std::f32::EPSILON and std::f64::EPSILON are available.");
@@ -601,7 +605,7 @@ fn in_attributes_expansion(expr: &Expr) -> bool {
 /// Tests whether `res` is a variable defined outside a macro.
 fn non_macro_local(cx: &LateContext<'_, '_>, res: def::Res) -> bool {
     if let def::Res::Local(id) = res {
-        !in_macro_or_desugar(cx.tcx.hir().span_by_hir_id(id))
+        !in_macro_or_desugar(cx.tcx.hir().span(id))
     } else {
         false
     }
diff --git a/clippy_lints/src/new_without_default.rs b/clippy_lints/src/new_without_default.rs
@@ -146,8 +146,9 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NewWithoutDefault {
                                         if let Some(self_def) = cx.tcx.type_of(self_did).ty_adt_def();
                                         if self_def.did.is_local();
                                         then {
-                                            let self_id = cx.tcx.hir().local_def_id_to_node_id(self_def.did.to_local());
-                                            if impling_types.contains(&self_id) {
+                                            let self_id = cx.tcx.hir().local_def_id_to_hir_id(self_def.did.to_local());
+                                            let node_id = cx.tcx.hir().hir_to_node_id(self_id);
+                                            if impling_types.contains(&node_id) {
                                                 return;
                                             }
                                         }
diff --git a/clippy_lints/src/non_copy_const.rs b/clippy_lints/src/non_copy_const.rs
@@ -170,7 +170,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NonCopyConst {
     fn check_impl_item(&mut self, cx: &LateContext<'a, 'tcx>, impl_item: &'tcx ImplItem) {
         if let ImplItemKind::Const(hir_ty, ..) = &impl_item.node {
             let item_hir_id = cx.tcx.hir().get_parent_node_by_hir_id(impl_item.hir_id);
-            let item = cx.tcx.hir().expect_item_by_hir_id(item_hir_id);
+            let item = cx.tcx.hir().expect_item(item_hir_id);
             // Ensure the impl is an inherent impl.
             if let ItemKind::Impl(_, _, _, _, None, _, _) = item.node {
                 let ty = hir_ty_to_ty(cx.tcx, hir_ty);
diff --git a/clippy_lints/src/utils/mod.rs b/clippy_lints/src/utils/mod.rs
@@ -978,7 +978,7 @@ pub fn any_parent_is_automatically_derived(tcx: TyCtxt<'_>, node: HirId) -> bool
     let mut prev_enclosing_node = None;
     let mut enclosing_node = node;
     while Some(enclosing_node) != prev_enclosing_node {
-        if is_automatically_derived(map.attrs_by_hir_id(enclosing_node)) {
+        if is_automatically_derived(map.attrs(enclosing_node)) {
             return true;
         }
         prev_enclosing_node = Some(enclosing_node);
diff --git a/tests/ui/float_cmp.stderr b/tests/ui/float_cmp.stderr
@@ -2,7 +2,7 @@ error: strict comparison of f32 or f64
   --> $DIR/float_cmp.rs:60:5
    |
 LL |     ONE as f64 != 2.0;
-   |     ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ONE as f64 - 2.0).abs() < error`
+   |     ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ONE as f64 - 2.0).abs() > error`
    |
    = note: `-D clippy::float-cmp` implied by `-D warnings`
 note: std::f32::EPSILON and std::f64::EPSILON are available.
@@ -27,7 +27,7 @@ error: strict comparison of f32 or f64
   --> $DIR/float_cmp.rs:68:5
    |
 LL |     twice(x) != twice(ONE as f64);
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(twice(x) - twice(ONE as f64)).abs() < error`
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(twice(x) - twice(ONE as f64)).abs() > error`
    |
 note: std::f32::EPSILON and std::f64::EPSILON are available.
   --> $DIR/float_cmp.rs:68:5
diff --git a/tests/ui/float_cmp_const.stderr b/tests/ui/float_cmp_const.stderr
@@ -27,7 +27,7 @@ error: strict comparison of f32 or f64 constant
   --> $DIR/float_cmp_const.rs:20:5
    |
 LL |     TWO != ONE;
-   |     ^^^^^^^^^^ help: consider comparing them within some error: `(TWO - ONE).abs() < error`
+   |     ^^^^^^^^^^ help: consider comparing them within some error: `(TWO - ONE).abs() > error`
    |
 note: std::f32::EPSILON and std::f64::EPSILON are available.
   --> $DIR/float_cmp_const.rs:20:5
@@ -75,7 +75,7 @@ error: strict comparison of f32 or f64 constant
   --> $DIR/float_cmp_const.rs:27:5
    |
 LL |     v != ONE;
-   |     ^^^^^^^^ help: consider comparing them within some error: `(v - ONE).abs() < error`
+   |     ^^^^^^^^ help: consider comparing them within some error: `(v - ONE).abs() > error`
    |
 note: std::f32::EPSILON and std::f64::EPSILON are available.
   --> $DIR/float_cmp_const.rs:27:5

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for EnumGlobUse {`
`32`	`32`	`let map = cx.tcx.hir();`
`33`	`33`	// only check top level `use` statements
`34`	`34`	`for item in &m.item_ids {`
`35`		`- self.lint_item(cx, map.expect_item(map.hir_to_node_id(item.id)));`
	`35`	`+ self.lint_item(cx, map.expect_item(item.id));`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for BoxedLocal {`
`94`	`94`	`span_lint(`
`95`	`95`	`cx,`
`96`	`96`	`BOXED_LOCAL,`
`97`		`- cx.tcx.hir().span_by_hir_id(node),`
	`97`	`+ cx.tcx.hir().span(node),`
`98`	`98`	`"local variable doesn't need to be boxed here",`
`99`	`99`	`);`
`100`	`100`	`}`
Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,9 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NewWithoutDefault {`
`146`	`146`	`if let Some(self_def) = cx.tcx.type_of(self_did).ty_adt_def();`
`147`	`147`	`if self_def.did.is_local();`
`148`	`148`	`then {`
`149`		`- let self_id = cx.tcx.hir().local_def_id_to_node_id(self_def.did.to_local());`
`150`		`- if impling_types.contains(&self_id) {`
	`149`	`+ let self_id = cx.tcx.hir().local_def_id_to_hir_id(self_def.did.to_local());`
	`150`	`+ let node_id = cx.tcx.hir().hir_to_node_id(self_id);`
	`151`	`+ if impling_types.contains(&node_id) {`
`151`	`152`	`return;`
`152`	`153`	`}`
`153`	`154`	`}`
Original file line number	Diff line number	Diff line change
`@@ -978,7 +978,7 @@ pub fn any_parent_is_automatically_derived(tcx: TyCtxt<'_>, node: HirId) -> bool`
`978`	`978`	`let mut prev_enclosing_node = None;`
`979`	`979`	`let mut enclosing_node = node;`
`980`	`980`	`while Some(enclosing_node) != prev_enclosing_node {`
`981`		`- if is_automatically_derived(map.attrs_by_hir_id(enclosing_node)) {`
	`981`	`+ if is_automatically_derived(map.attrs(enclosing_node)) {`
`982`	`982`	`return true;`
`983`	`983`	`}`
`984`	`984`	`prev_enclosing_node = Some(enclosing_node);`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ error: strict comparison of f32 or f64`
`2`	`2`	`--> $DIR/float_cmp.rs:60:5`
`3`	`3`	`\|`
`4`	`4`	`LL \| ONE as f64 != 2.0;`
`5`		- \| ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ONE as f64 - 2.0).abs() < error`
	`5`	+ \| ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ONE as f64 - 2.0).abs() > error`
`6`	`6`	`\|`
`7`	`7`	= note: `-D clippy::float-cmp` implied by `-D warnings`
`8`	`8`	`note: std::f32::EPSILON and std::f64::EPSILON are available.`
`@@ -27,7 +27,7 @@ error: strict comparison of f32 or f64`
`27`	`27`	`--> $DIR/float_cmp.rs:68:5`
`28`	`28`	`\|`
`29`	`29`	`LL \| twice(x) != twice(ONE as f64);`
`30`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(twice(x) - twice(ONE as f64)).abs() < error`
	`30`	+ \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(twice(x) - twice(ONE as f64)).abs() > error`
`31`	`31`	`\|`
`32`	`32`	`note: std::f32::EPSILON and std::f64::EPSILON are available.`
`33`	`33`	`--> $DIR/float_cmp.rs:68:5`